From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1067C43458 for ; Thu, 2 Jul 2026 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CZVmKzrIdQYLuRwd8GzxpfU9Xi+Tvx4DJglySzOfH0k=; b=L951DQiK0PmmuE Uix2PcgQMg0OtbyrTq7cLcB2Qee1Vn0Unwjk3qLeOD4u5Z7K3MkFG0/65V/rlR4aticgfxwd+Hzlw cZ/wqU4KTE7oAgTMe6R8Psj/6trs0LnBVOFYG6QyqTRJJpX1B5itrTx1HhXmsvsnkoJze087YypJg HDDqH/mAJnnw0mbkcV7hYRvrrK+9uBenH+DtzGr2XjKUBW7DqZnQIHks4w3lx4Ly1ZBu2PVb5R8xS ECy9oZOF8UI2pijhaKJ3TZie8yvBL4k4pE8E1mKobAmRl2xiADo5mCCL1UEgnyl92fIa+8ZZFfaGT wvDeCSgj18Ty/8kFFq1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfERD-000000049Bz-1fYV; Thu, 02 Jul 2026 10:14:31 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfERC-000000049Bk-2XTZ for linux-phy@lists.infradead.org; Thu, 02 Jul 2026 10:14:30 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4663342D9D; Thu, 2 Jul 2026 10:14:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07141F00A3A; Thu, 2 Jul 2026 10:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782987270; bh=ZnQ3BPWD2sLXVOQ9o1oEN4tGqdYuwLCGKdjzo5zdpSo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=If5odQ3QTEH8iSDvU5xuZSbWJ3LaklsJwuaiOqATtdPZ7T0NexPW+19fxt4MW9Wvm LhRVxNKzD7Nf03e8uM8LDyMhIXtQXokXjpDVtJiB5Zcd5GU9q2BPkMyu0euqUR0VVy KEWNd6rmg4ZJ5rWAtCvKBwNPEvdO2M3+L3forR9a9cFA32B0xXsceov+aPkVprOYHh lgvNgyuZnm7kFnbEeOktdqfVYbR0oz+nrgxt2Ttsn85ZzmXW3sMhwxt4Ax2CUXRjOh iEhr+KVM5b5TeVRgqLeww8qB3QdrhGbV0La3vS/Cgc9L5Vq3hPqNpnuUQ+Ag5tcK0J ny/vRZod48imA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 4/5] phy: move and rename Airoha PCIe PHY driver to dedicated directory To: "Christian Marangi" Cc: linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260702093812.15918-5-ansuelsmth@gmail.com> References: <20260702093812.15918-1-ansuelsmth@gmail.com> <20260702093812.15918-5-ansuelsmth@gmail.com> Date: Thu, 02 Jul 2026 10:14:29 +0000 Message-Id: <20260702101429.B07141F00A3A@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGRyaXZlciBLY29u ZmlnIHN5bWJvbCwgZmlsZSBuYW1lcywgYW5kIHBsYXRmb3JtIGRyaXZlciBuYW1lIGFyZSBpbmNv cnJlY3RseSByZW5hbWVkIHVzaW5nIHRoZSAnQU43NTgxJyBwcmVmaXggaW5zdGVhZCBvZiAnRU43 NTgxJywgY3JlYXRpbmcgYSBtaXNtYXRjaCB3aXRoIHRoZSBoYXJkd2FyZSBuYW1lIGFuZCBkZXZp Y2UgdHJlZSBiaW5kaW5ncy4KLSBbTG93XSBUaGUgaW5jbHVkZSBndWFyZCBpbiBgcGh5LWFuNzU4 MS1wY2llLXJlZ3MuaGAgd2FzIG5vdCB1cGRhdGVkIGFmdGVyIHRoZSBmaWxlIHdhcyByZW5hbWVk LgotIFtMb3ddIEluY29ycmVjdCBTUERYLUxpY2Vuc2UtSWRlbnRpZmllciBjb21tZW50IHN0eWxl IGZvciBhIEMgaGVhZGVyIGZpbGUuCi0gW0xvd10gVGhlIG5ld2x5IGFkZGVkIGBLY29uZmlnYCBh bmQgYE1ha2VmaWxlYCBmb3IgdGhlIGBkcml2ZXJzL3BoeS9haXJvaGEvYCBkaXJlY3RvcnkgYXJl IG1pc3NpbmcgZnJvbSB0aGUgYE1BSU5UQUlORVJTYCBmaWxlLgotLQoKY29tbWl0IDZiN2M3MzY0 OGZjZWJjNDYyN2Q4MmM4YWIzMzEyODYyMzc1NmE0NTMKQXV0aG9yOiBDaHJpc3RpYW4gTWFyYW5n aSA8YW5zdWVsc210aEBnbWFpbC5jb20+CgpwaHk6IG1vdmUgYW5kIHJlbmFtZSBBaXJvaGEgUENJ ZSBQSFkgZHJpdmVyIHRvIGRlZGljYXRlZCBkaXJlY3RvcnkKClRoaXMgY29tbWl0IG1vdmVzIHRo ZSBQQ0llIFBIWSBkcml2ZXIgZm9yIHRoZSBBaXJvaGEgQU43NTgxIFNvQyB0byBhIGRlZGljYXRl ZApkaXJlY3RvcnkgdG8ga2VlcCB0aGUgZ2VuZXJpYyBQSFkgZGlyZWN0b3J5IHRpZHkuIEl0IGFs c28gcmVuYW1lcyB0aGUgZHJpdmVyCmFuZCBmaWxlcyB0byBpbmNsdWRlIHRoZSBzcGVjaWZpYyBT b0MgbmFtZSBpbiBwcmVwYXJhdGlvbiBmb3IgYWRkaW5nIEFONzU4MwpzdXBwb3J0LCBhbmQgdXBk YXRlcyB0aGUgS2NvbmZpZyBzeW1ib2wgYWNjb3JkaW5nbHkuCgo+IFRvIGtlZXAgdGhlIGdlbmVy aWMgUEhZIGRpcmVjdG9yeSB0aWR5LCBtb3ZlIHRoZSBQQ0llIFBIWSBkcml2ZXIgZm9yCj4gQWly b2hhIEFONzU4MSBTb0MgdG8gYSBkZWRpY2F0ZWQgZGlyZWN0b3J5Lgo+IAo+IEFsc28gcmVuYW1l IHRoZSBkcml2ZXIgYW5kIGFkZCB0aGUgcmVsZXZhbnQgU29DIG5hbWUgdG8gdGhlIC5jIGFuZCAu aAo+IGZpbGUgaW4gcHJlcGFyYXRpb24gZm9yIHN1cHBvcnQgb2YgUENJZSBhbmQgVVNCIFBIWSBk cml2ZXIgZm9yIEFpcm9oYQo+IEFONzU4MyBTb0MKCltTZXZlcml0eTogTG93XQpUaGlzIGlzbid0 IGEgYnVnLCBidXQgdGhlcmUgbWlnaHQgYmUgYSB0eXBvIGluIHRoZSBjb21taXQgbWVzc2FnZS4g SXMgdGhlClNvQyBuYW1lIEVONzU4MSBpbnN0ZWFkIG9mIEFONzU4MSwgZ2l2ZW4gdGhlIGV4aXN0 aW5nIGRldmljZSB0cmVlIGJpbmRpbmdzCm1lbnRpb24gZW43NTgxPwoKPiBkaWZmIC0tZ2l0IGEv TUFJTlRBSU5FUlMgYi9NQUlOVEFJTkVSUwo+IGluZGV4IGNiNzgzNmEyN2IxNzcuLmJiZmFjYTU3 MjExOGMgMTAwNjQ0Cj4gLS0tIGEvTUFJTlRBSU5FUlMKPiArKysgYi9NQUlOVEFJTkVSUwo+IEBA IC03NjUsOCArNzY1LDggQEAgTToJTG9yZW56byBCaWFuY29uaSA8bG9yZW56b0BrZXJuZWwub3Jn Pgo+ICBMOglsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcgKG1vZGVyYXRlZCBm b3Igbm9uLXN1YnNjcmliZXJzKQo+ICBTOglNYWludGFpbmVkCj4gIEY6CURvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvYWlyb2hhLGVuNzU4MS1wY2llLXBoeS55YW1sCj4gLUY6 CWRyaXZlcnMvcGh5L3BoeS1haXJvaGEtcGNpZS1yZWdzLmgKPiAtRjoJZHJpdmVycy9waHkvcGh5 LWFpcm9oYS1wY2llLmMKPiArRjoJZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1ODEtcGNpZS1y ZWdzLmgKPiArRjoJZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1ODEtcGNpZS5jCgpbU2V2ZXJp dHk6IExvd10KQnkgZXhwbGljaXRseSBsaXN0aW5nIG9ubHkgdGhlIHNvdXJjZSBmaWxlcywgdGhl IG5ld2x5IGFkZGVkIEtjb25maWcgYW5kCk1ha2VmaWxlIGluIHRoZSBkcml2ZXJzL3BoeS9haXJv aGEvIGRpcmVjdG9yeSBhcmUgbGVmdCB3aXRob3V0IGEgbWFpbnRhaW5lcgptYXBwaW5nLiBXb3Vs ZCBpdCBiZSBiZXR0ZXIgdG8gdXNlIGEgZGlyZWN0b3J5IHdpbGRjYXJkIGxpa2UKRjogZHJpdmVy cy9waHkvYWlyb2hhLyB0byBpbmNsdWRlIHRoZSBuZXcgYnVpbGQgZmlsZXM/Cgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3BoeS9haXJvaGEvS2NvbmZpZyBiL2RyaXZlcnMvcGh5L2Fpcm9oYS9LY29u ZmlnCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi45YTFiNjI1 YTc3MDEyCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvcGh5L2Fpcm9oYS9LY29uZmln Cj4gQEAgLTAsMCArMSwxMyBAQAo+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4w LW9ubHkKPiArIwo+ICsjIFBoeSBkcml2ZXJzIGZvciBBaXJvaGEgZGV2aWNlcwo+ICsjCj4gK2Nv bmZpZyBQSFlfQUlST0hBX0FONzU4MV9QQ0lFCj4gKwl0cmlzdGF0ZSAiQWlyb2hhIEFONzU4MSBQ Q0llLVBIWSBEcml2ZXIiCgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIEtjb25maWcgc3ltYm9s IGFuZCBwcm9tcHQgaW5jb3JyZWN0bHkgdXNlIHRoZSBBTjc1ODEgcHJlZml4CmRlc3BpdGUgdGhl IFNvQyBoYXJkd2FyZSBhbmQgZGV2aWNlIHRyZWUgYmluZGluZyBiZWluZyBuYW1lZCBFTjc1ODE/ Cgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9waHktYWlyb2hhLXBjaWUtcmVncy5oIGIvZHJp dmVycy9waHkvYWlyb2hhL3BoeS1hbjc1ODEtcGNpZS1yZWdzLmgKPiBzaW1pbGFyaXR5IGluZGV4 IDk5JQo+IHJlbmFtZSBmcm9tIGRyaXZlcnMvcGh5L3BoeS1haXJvaGEtcGNpZS1yZWdzLmgKPiBy ZW5hbWUgdG8gZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1ODEtcGNpZS1yZWdzLmgKPiBpbmRl eCA1ODU3MmM3OTM3MjIzLi5iOTM4YTdiNDY4ZmVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5 L3BoeS1haXJvaGEtcGNpZS1yZWdzLmgKPiArKysgYi9kcml2ZXJzL3BoeS9haXJvaGEvcGh5LWFu NzU4MS1wY2llLXJlZ3MuaAo+IEBAIC0xLDQgKzEsNCBAQAo+IC0vKiBTUERYLUxpY2Vuc2UtSWRl bnRpZmllcjogR1BMLTIuMC1vbmx5ICovCj4gKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBH UEwtMi4wLW9ubHkKCltTZXZlcml0eTogTG93XQpEb2VzIHRoaXMgY2hhbmdlIHRvIGEgQysrIHN0 eWxlIGxpbmUgY29tbWVudCB2aW9sYXRlIHRoZSBrZXJuZWwncyBTUERYCmxpY2Vuc2UgaWRlbnRp ZmllciBydWxlcyBmb3IgQyBoZWFkZXIgZmlsZXMsIHdoaWNoIHJlcXVpcmUgdGhlIC8qIC4uLiAq LwpibG9jayBjb21tZW50IHN0eWxlPwoKW1NldmVyaXR5OiBMb3ddCkFsc28sIHNpbmNlIHRoaXMg ZmlsZSB3YXMgcmVuYW1lZCwgZG9lcyB0aGUgaW5jbHVkZSBndWFyZCBmdXJ0aGVyIGRvd24gaW4g dGhlCmZpbGUgKGN1cnJlbnRseSAjaWZuZGVmIF9QSFlfQUlST0hBX1BDSUVfSCkgbmVlZCB0byBi ZSB1cGRhdGVkIHRvIG1hdGNoIHRoZQpuZXcgZmlsZW5hbWU/Cgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3BoeS9waHktYWlyb2hhLXBjaWUuYyBiL2RyaXZlcnMvcGh5L2Fpcm9oYS9waHktYW43NTgx LXBjaWUuYwo+IHNpbWlsYXJpdHkgaW5kZXggOTklCj4gcmVuYW1lIGZyb20gZHJpdmVycy9waHkv cGh5LWFpcm9oYS1wY2llLmMKPiByZW5hbWUgdG8gZHJpdmVycy9waHkvYWlyb2hhL3BoeS1hbjc1 ODEtcGNpZS5jCj4gaW5kZXggNTZlOWFkZThhOWZkMy4uODFkZGYwZTc2MzhiNyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL3BoeS9waHktYWlyb2hhLXBjaWUuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L2Fp cm9oYS9waHktYW43NTgxLXBjaWUuYwoKWyAuLi4gXQoKPiBAQCAtMTI3OSwxMiArMTI3OSwxMiBA QCBNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBhaXJvaGFfcGNpZV9waHlfb2ZfbWF0Y2gpOwo+ICBz dGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciBhaXJvaGFfcGNpZV9waHlfZHJpdmVyID0gewo+ ICAJLnByb2JlCT0gYWlyb2hhX3BjaWVfcGh5X3Byb2JlLAo+ICAJLmRyaXZlcgk9IHsKPiAtCQku bmFtZSA9ICJhaXJvaGEtcGNpZS1waHkiLAo+ICsJCS5uYW1lID0gImFpcm9oYS1hbjc1ODEtcGNp ZS1waHkiLAoKW1NldmVyaXR5OiBMb3ddCkRvZXMgdGhpcyBwbGF0Zm9ybSBkcml2ZXIgbmFtZSBp bmNvcnJlY3RseSB1c2UgdGhlIG1pc3NwZWxsZWQgYW43NTgxIHByZWZpeAppbnN0ZWFkIG9mIGVu NzU4MT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0 Y2hzZXQvMjAyNjA3MDIwOTM4MTIuMTU5MTgtMS1hbnN1ZWxzbXRoQGdtYWlsLmNvbT9wYXJ0PTQK Ci0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7870B30F7EA for ; Thu, 2 Jul 2026 10:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987271; cv=none; b=cTMr0E1Wmyr4SK4dVSaVSUBZGfpGJMEcFzge+6O1D2DQUfCq65124ywtdh9OaaHWdE6bK5doOEzc9ko3oGey3yxKjeFHYEnDFuhIYoFIlC1QIZikB2lBWQrOMO5TdQRFETQxbTAGQ3a1TqMwDFYKr+SVOPmP16q5NB1NFOow+jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782987271; c=relaxed/simple; bh=u6ETMTchOoN0b7cHQdwyqA+5c8Qn2b4VENKBRB4rEd8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=LdoJx7oy5in40kg+bhhZj4taRSCoMjRL1A8MZx17LKNU/YNk9fIX4NfvvxhRloH5r+DIH/QOyvlzHjacXQm8hPSbW92541p7M6zyqgD9669z4mT3yi4wx3XYYGgsd6h19tkRqAnsWm+VpaNX/pdas3v6cmWbqBxIxSNPNDogzms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=If5odQ3Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="If5odQ3Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07141F00A3A; Thu, 2 Jul 2026 10:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782987270; bh=ZnQ3BPWD2sLXVOQ9o1oEN4tGqdYuwLCGKdjzo5zdpSo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=If5odQ3QTEH8iSDvU5xuZSbWJ3LaklsJwuaiOqATtdPZ7T0NexPW+19fxt4MW9Wvm LhRVxNKzD7Nf03e8uM8LDyMhIXtQXokXjpDVtJiB5Zcd5GU9q2BPkMyu0euqUR0VVy KEWNd6rmg4ZJ5rWAtCvKBwNPEvdO2M3+L3forR9a9cFA32B0xXsceov+aPkVprOYHh lgvNgyuZnm7kFnbEeOktdqfVYbR0oz+nrgxt2Ttsn85ZzmXW3sMhwxt4Ax2CUXRjOh iEhr+KVM5b5TeVRgqLeww8qB3QdrhGbV0La3vS/Cgc9L5Vq3hPqNpnuUQ+Ag5tcK0J ny/vRZod48imA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 4/5] phy: move and rename Airoha PCIe PHY driver to dedicated directory Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Marangi" Cc: linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260702093812.15918-5-ansuelsmth@gmail.com> References: <20260702093812.15918-1-ansuelsmth@gmail.com> <20260702093812.15918-5-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 02 Jul 2026 10:14:29 +0000 Message-Id: <20260702101429.B07141F00A3A@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Low] The driver Kconfig symbol, file names, and platform driver name are= incorrectly renamed using the 'AN7581' prefix instead of 'EN7581', creatin= g a mismatch with the hardware name and device tree bindings. - [Low] The include guard in `phy-an7581-pcie-regs.h` was not updated after= the file was renamed. - [Low] Incorrect SPDX-License-Identifier comment style for a C header file. - [Low] The newly added `Kconfig` and `Makefile` for the `drivers/phy/airoh= a/` directory are missing from the `MAINTAINERS` file. -- commit 6b7c73648fcebc4627d82c8ab33128623756a453 Author: Christian Marangi phy: move and rename Airoha PCIe PHY driver to dedicated directory This commit moves the PCIe PHY driver for the Airoha AN7581 SoC to a dedica= ted directory to keep the generic PHY directory tidy. It also renames the driver and files to include the specific SoC name in preparation for adding AN7583 support, and updates the Kconfig symbol accordingly. > To keep the generic PHY directory tidy, move the PCIe PHY driver for > Airoha AN7581 SoC to a dedicated directory. >=20 > Also rename the driver and add the relevant SoC name to the .c and .h > file in preparation for support of PCIe and USB PHY driver for Airoha > AN7583 SoC [Severity: Low] This isn't a bug, but there might be a typo in the commit message. Is the SoC name EN7581 instead of AN7581, given the existing device tree bindings mention en7581? > diff --git a/MAINTAINERS b/MAINTAINERS > index cb7836a27b177..bbfaca572118c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -765,8 +765,8 @@ M: Lorenzo Bianconi > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml > -F: drivers/phy/phy-airoha-pcie-regs.h > -F: drivers/phy/phy-airoha-pcie.c > +F: drivers/phy/airoha/phy-an7581-pcie-regs.h > +F: drivers/phy/airoha/phy-an7581-pcie.c [Severity: Low] By explicitly listing only the source files, the newly added Kconfig and Makefile in the drivers/phy/airoha/ directory are left without a maintainer mapping. Would it be better to use a directory wildcard like F: drivers/phy/airoha/ to include the new build files? > diff --git a/drivers/phy/airoha/Kconfig b/drivers/phy/airoha/Kconfig > new file mode 100644 > index 0000000000000..9a1b625a77012 > --- /dev/null > +++ b/drivers/phy/airoha/Kconfig > @@ -0,0 +1,13 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# Phy drivers for Airoha devices > +# > +config PHY_AIROHA_AN7581_PCIE > + tristate "Airoha AN7581 PCIe-PHY Driver" [Severity: Low] Does this Kconfig symbol and prompt incorrectly use the AN7581 prefix despite the SoC hardware and device tree binding being named EN7581? > diff --git a/drivers/phy/phy-airoha-pcie-regs.h b/drivers/phy/airoha/phy-= an7581-pcie-regs.h > similarity index 99% > rename from drivers/phy/phy-airoha-pcie-regs.h > rename to drivers/phy/airoha/phy-an7581-pcie-regs.h > index 58572c7937223..b938a7b468fee 100644 > --- a/drivers/phy/phy-airoha-pcie-regs.h > +++ b/drivers/phy/airoha/phy-an7581-pcie-regs.h > @@ -1,4 +1,4 @@ > -/* SPDX-License-Identifier: GPL-2.0-only */ > +// SPDX-License-Identifier: GPL-2.0-only [Severity: Low] Does this change to a C++ style line comment violate the kernel's SPDX license identifier rules for C header files, which require the /* ... */ block comment style? [Severity: Low] Also, since this file was renamed, does the include guard further down in t= he file (currently #ifndef _PHY_AIROHA_PCIE_H) need to be updated to match the new filename? > diff --git a/drivers/phy/phy-airoha-pcie.c b/drivers/phy/airoha/phy-an758= 1-pcie.c > similarity index 99% > rename from drivers/phy/phy-airoha-pcie.c > rename to drivers/phy/airoha/phy-an7581-pcie.c > index 56e9ade8a9fd3..81ddf0e7638b7 100644 > --- a/drivers/phy/phy-airoha-pcie.c > +++ b/drivers/phy/airoha/phy-an7581-pcie.c [ ... ] > @@ -1279,12 +1279,12 @@ MODULE_DEVICE_TABLE(of, airoha_pcie_phy_of_match); > static struct platform_driver airoha_pcie_phy_driver =3D { > .probe =3D airoha_pcie_phy_probe, > .driver =3D { > - .name =3D "airoha-pcie-phy", > + .name =3D "airoha-an7581-pcie-phy", [Severity: Low] Does this platform driver name incorrectly use the misspelled an7581 prefix instead of en7581? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260702093812.1591= 8-1-ansuelsmth@gmail.com?part=3D4