[sudeep-holla:b4/acpi_scmi_pcc 19/23] drivers/firmware/arm_scmi/driver.c:3072:54: warning: pointer/integer type mismatch in conditional expression

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git b4/acpi_scmi_pcc
head:   bdcaa5728f17002c1091efd93dd082c9c23ddd39
commit: f17b84ab4e8011a39adfbbf053b2cac4433e6918 [19/23] firmware: arm_scmi: Fall back to ACPI HID when "compatible" is absent
config: arc-randconfig-002-20260702 (https://download.01.org/0day-ci/archive/20260702/202607021119.VLWpioPF-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260702/202607021119.VLWpioPF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607021119.VLWpioPF-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/firmware/arm_scmi/driver.c: In function 'scmi_debugfs_common_setup':
   drivers/firmware/arm_scmi/driver.c:3072:32: error: implicit declaration of function 'acpi_device_hid'; did you mean 'acpi_device_handle'? [-Werror=implicit-function-declaration]
    3072 |                 c_ptr = adev ? acpi_device_hid(adev) : "unknown";
         |                                ^~~~~~~~~~~~~~~
         |                                acpi_device_handle
>> drivers/firmware/arm_scmi/driver.c:3072:54: warning: pointer/integer type mismatch in conditional expression
    3072 |                 c_ptr = adev ? acpi_device_hid(adev) : "unknown";
         |                                                      ^
   cc1: some warnings being treated as errors


vim +3072 drivers/firmware/arm_scmi/driver.c

  3050	
  3051	static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info)
  3052	{
  3053		char top_dir[16];
  3054		struct dentry *trans, *top_dentry;
  3055		struct scmi_debug_info *dbg;
  3056		struct acpi_device *adev;
  3057		const char *c_ptr = NULL;
  3058	
  3059		dbg = devm_kzalloc(info->dev, sizeof(*dbg), GFP_KERNEL);
  3060		if (!dbg)
  3061			return NULL;
  3062	
  3063		dbg->name = kstrdup(fwnode_get_name(dev_fwnode(info->dev)), GFP_KERNEL);
  3064		if (!dbg->name) {
  3065			devm_kfree(info->dev, dbg);
  3066			return NULL;
  3067		}
  3068	
  3069		if (fwnode_property_read_string(dev_fwnode(info->dev), "compatible",
  3070						&c_ptr)) {
  3071			adev = ACPI_COMPANION(info->dev);
> 3072			c_ptr = adev ? acpi_device_hid(adev) : "unknown";
  3073		}
  3074		dbg->type = kstrdup(c_ptr, GFP_KERNEL);
  3075		if (!dbg->type) {
  3076			kfree(dbg->name);
  3077			devm_kfree(info->dev, dbg);
  3078			return NULL;
  3079		}
  3080	
  3081		snprintf(top_dir, 16, "%d", info->id);
  3082		top_dentry = debugfs_create_dir(top_dir, scmi_top_dentry);
  3083		trans = debugfs_create_dir("transport", top_dentry);
  3084	
  3085		dbg->is_atomic = info->desc->atomic_enabled &&
  3086					is_transport_polling_capable(info->desc);
  3087	
  3088		debugfs_create_str("instance_name", 0400, top_dentry,
  3089				   (char **)&dbg->name);
  3090	
  3091		debugfs_create_u32("atomic_threshold_us", 0400, top_dentry,
  3092				   (u32 *)&info->desc->atomic_threshold);
  3093	
  3094		debugfs_create_str("type", 0400, trans, (char **)&dbg->type);
  3095	
  3096		debugfs_create_bool("is_atomic", 0400, trans, &dbg->is_atomic);
  3097	
  3098		debugfs_create_u32("max_rx_timeout_ms", 0400, trans,
  3099				   (u32 *)&info->desc->max_rx_timeout_ms);
  3100	
  3101		debugfs_create_u32("max_msg_size", 0400, trans,
  3102				   (u32 *)&info->desc->max_msg_size);
  3103	
  3104		debugfs_create_u32("tx_max_msg", 0400, trans,
  3105				   (u32 *)&info->tx_minfo.max_msg);
  3106	
  3107		debugfs_create_u32("rx_max_msg", 0400, trans,
  3108				   (u32 *)&info->rx_minfo.max_msg);
  3109	
  3110		if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_COUNTERS))
  3111			scmi_debugfs_counters_setup(dbg, trans);
  3112	
  3113		dbg->top_dentry = top_dentry;
  3114	
  3115		if (devm_add_action_or_reset(info->dev,
  3116					     scmi_debugfs_common_cleanup, dbg))
  3117			return NULL;
  3118	
  3119		return dbg;
  3120	}
  3121	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki