Re: [LTP] Migrating the libhugetlbfs/testcases/quota.c - v2

[linuxtestproject.agent@gmail.com]

Hi Pavithra,

On Sat Apr  4 17:41:20 2026 +0530, Pavithra wrote:
> Migrating the libhugetlbfs/testcases/quota.c - v2

> Migrating the libhugetlbfs/testcases/quota.c - v2

The "- v2" suffix is a patch-revision marker that must be stripped from
the final commit subject before merging.

The subject should also follow the LTP convention of naming the
subsystem and what is being added, for example:

  hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting

> +/*\
> + * Test hugetlbfs quota accounting with filesystem size limits.
> + *
> + * The number of global huge pages available to a mounted hugetlbfs
> + * filesystem can be limited using a quota mechanism by setting the
> + * size attribute at mount time. Older kernels did not properly handle
> + * quota accounting in a number of cases (e.g., for MAP_PRIVATE pages,
> + * and with MAP_SHARED reservation).
> + *
> + * This test replays some scenarios on a privately mounted filesystem
> + * with quota to check for regressions in hugetlbfs quota accounting.
> + */

Ground Rule 4 requires that when a test sets .needs_root = 1, the
reason must be stated in the doc comment.  The test mounts a second
hugetlbfs instance with a quota limit in setup(), which requires
CAP_SYS_ADMIN, but the description block is silent on this.

A sentence like the following should be added:

  Root is required to mount the quota-limited hugetlbfs instance.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp