From: Jeff King <peff@peff.net>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 6/9] t7900: clean up large EXPENSIVE repository
Date: Thu, 2 Jul 2026 17:30:44 -0400 [thread overview]
Message-ID: <20260702213044.GD2051171@coredump.intra.peff.net> (raw)
In-Reply-To: <20260702-b4-pks-t-fixes-for-GIT-TEST-LONG-v1-6-76b4d7bab3d0@pks.im>
On Thu, Jul 02, 2026 at 02:00:59PM +0200, Patrick Steinhardt wrote:
> One of the tests in t7900 is marked with EXPENSIVE because we create a
> repository with 2GB of data that we end up repacking. We never clean up
> that repository though, so we occupy the full 2GB of data until the end
> of the test suite. Besides clogging our disk, it also means that all
> subsequent tests may have to repack this data multiple times.
Hmm, I hoped this would drop the time to run t7900 with --long, but it
takes about 1m40s both before and after your patch (vs ~6s without
--long). Just looking at the script, I'd guess that it's because the
subsequent repacks are mostly incremental or geometric, so they don't
need to write the big pack.
Oh well. It still seems like an obvious improvement, though, both in
terms of peak disk usage and avoiding unwanted surprises when more tests
are added later.
-Peff
next prev parent reply other threads:[~2026-07-02 21:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 12:00 [PATCH 0/9] t: fixes and improvements for GIT_TEST_LONG Patrick Steinhardt
2026-07-02 12:00 ` [PATCH 1/9] README: add GitLab CI badge to make it more discoverable Patrick Steinhardt
2026-07-02 12:00 ` [PATCH 2/9] t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT Patrick Steinhardt
2026-07-02 12:00 ` [PATCH 3/9] t4141: fix inefficient use of dd(1) Patrick Steinhardt
2026-07-02 17:49 ` SZEDER Gábor
2026-07-03 5:42 ` Patrick Steinhardt
2026-07-02 21:16 ` Jeff King
2026-07-03 5:42 ` Patrick Steinhardt
2026-07-03 7:00 ` Jeff King
2026-07-02 12:00 ` [PATCH 4/9] t5608: reduce maximum disk usage Patrick Steinhardt
2026-07-02 12:00 ` [PATCH 5/9] t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT Patrick Steinhardt
2026-07-02 21:22 ` Jeff King
2026-07-02 22:18 ` Jeff King
2026-07-02 12:00 ` [PATCH 6/9] t7900: clean up large EXPENSIVE repository Patrick Steinhardt
2026-07-02 21:30 ` Jeff King [this message]
2026-07-03 5:42 ` Patrick Steinhardt
2026-07-03 7:00 ` Jeff King
2026-07-02 12:01 ` [PATCH 7/9] t: use `test_bool_env` to parse GIT_TEST_LONG Patrick Steinhardt
2026-07-02 12:01 ` [PATCH 8/9] gitlab-ci: disable RAM disk on macOS jobs Patrick Steinhardt
2026-07-02 12:01 ` [PATCH 9/9] gitlab-ci: enable "GIT_TEST_LONG" Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 0/9] t: fixes and improvements for GIT_TEST_LONG Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 1/9] README: add GitLab CI badge to make it more discoverable Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 2/9] t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT Patrick Steinhardt
2026-07-03 17:36 ` Junio C Hamano
2026-07-06 6:23 ` Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 3/9] t4141: fix inefficient use of dd(1) Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 4/9] t5608: reduce maximum disk usage Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 5/9] t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_32BIT Patrick Steinhardt
2026-07-03 17:38 ` Junio C Hamano
2026-07-03 9:24 ` [PATCH v2 6/9] t7900: clean up large EXPENSIVE repository Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 7/9] t: use `test_bool_env` to parse GIT_TEST_LONG Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 8/9] gitlab-ci: disable RAM disk on macOS jobs Patrick Steinhardt
2026-07-03 9:24 ` [PATCH v2 9/9] gitlab-ci: enable "GIT_TEST_LONG" Patrick Steinhardt
2026-07-06 6:23 ` [PATCH v3 0/9] t: fixes and improvements for GIT_TEST_LONG Patrick Steinhardt
2026-07-06 6:23 ` [PATCH v3 1/9] README: add GitLab CI badge to make it more discoverable Patrick Steinhardt
2026-07-06 6:23 ` [PATCH v3 2/9] t0021: skip EXPENSIVE test that is broken without SIZE_T_IS_64BIT Patrick Steinhardt
2026-07-06 6:23 ` [PATCH v3 3/9] t4141: fix inefficient use of dd(1) Patrick Steinhardt
2026-07-06 6:23 ` [PATCH v3 4/9] t5608: reduce maximum disk usage Patrick Steinhardt
2026-07-06 6:24 ` [PATCH v3 5/9] t7508: skip EXPENSIVE test that is broken without SIZE_T_IS_64BIT Patrick Steinhardt
2026-07-06 6:24 ` [PATCH v3 6/9] t7900: clean up large EXPENSIVE repository Patrick Steinhardt
2026-07-06 6:24 ` [PATCH v3 7/9] t: use `test_bool_env` to parse GIT_TEST_LONG Patrick Steinhardt
2026-07-06 6:24 ` [PATCH v3 8/9] gitlab-ci: disable RAM disk on macOS jobs Patrick Steinhardt
2026-07-06 6:24 ` [PATCH v3 9/9] gitlab-ci: enable "GIT_TEST_LONG" Patrick Steinhardt
2026-07-06 20:29 ` [PATCH v3 0/9] t: fixes and improvements for GIT_TEST_LONG Junio C Hamano
2026-07-07 4:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702213044.GD2051171@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.