Re: [RFC PATCH v2 01/10] drm/vino: add DisplayLink DL3 dock skeleton and protocol framing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The `DRM_VINO` Kconfig selects a non-existent symbol `CRYPTO_LIB_RSA`.
- [Medium] Selecting `RUST_DRM_GEM_SHMEM_HELPER` without inheriting its `MMU` dependency.
- [Low] Enabling `CONFIG_DRM_VINO` breaks the kernel build because the module's root source file is missing.
--

commit 06fb786f2554d0076260c52a80817260c6d10437
Author: Mike Lothian <mike@fireburn.co.uk>

drm/vino: add DisplayLink DL3 dock skeleton and protocol framing

This commit introduces the module skeleton for the new DisplayLink DL3 USB
dock driver. It adds Kconfig and Makefile entries and includes standalone
wire framing protocol and randomness wrapper code.

> diff --git a/drivers/gpu/drm/vino/Kconfig b/drivers/gpu/drm/vino/Kconfig
> new file mode 100644
> index 0000000000000..f5fe6670a4886
> --- /dev/null
> +++ b/drivers/gpu/drm/vino/Kconfig
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0
> +config DRM_VINO
> +	tristate "DisplayLink DL3 (Vino) open driver"
> +	depends on USB
> +	depends on DRM
> +	depends on RUST
> +	select DRM_KMS_HELPER
> +	select RUST_DRM_GEM_SHMEM_HELPER

[Severity: Medium]
Does DRM_VINO also need to depend on MMU? RUST_DRM_GEM_SHMEM_HELPER depends on
DRM and MMU. Selecting it without inheriting the MMU dependency can trigger
unmet direct dependency warnings and potential build failures on MMU-less
architectures.

> +	select CRYPTO_LIB_RSA

[Severity: Medium]
Is CRYPTO_LIB_RSA the correct Kconfig symbol? It appears this symbol does not
exist in the kernel tree, and the correct symbol might be CRYPTO_RSA. Selecting
a non-existent symbol causes the directive to be ignored and can silently leave
crypto dependencies disabled.

> +	help
> +	  Open in-kernel Rust driver for DisplayLink DL3 USB docks (Dell

[ ... ]

> diff --git a/drivers/gpu/drm/vino/Makefile b/drivers/gpu/drm/vino/Makefile
> new file mode 100644
> index 0000000000000..6e39668040f30
> --- /dev/null
> +++ b/drivers/gpu/drm/vino/Makefile
> @@ -0,0 +1,2 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-$(CONFIG_DRM_VINO) += vino.o

[Severity: Low]
Could this break the build if CONFIG_DRM_VINO is enabled at this specific
commit? It looks like there is no corresponding vino.rs or vino.c added yet,
which causes a missing target error.

I noticed the missing source file is introduced in the subsequent commit
"drm/vino: add the DisplayLink DL3 dock driver", but this temporary state might
break kernel bisectability.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703030217.2886-1-mike@fireburn.co.uk?part=1