From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2AA9433E90 for ; Fri, 3 Jul 2026 03:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783049778; cv=none; b=cQh20dJq17jbpL3+hYqm8NGs4vzgIKhkMTD6+EigALFGNPqsaHYMGXcugLI6UJ9c/5eMBLtWwIYAem3qewK4h/blPPtHlBQYU6apLtvI1eQaWu2EtxXGkv16xwh39EaTRSFrPh1o4eUqE4Uf8apzWMLQkBgqyLRpXr9lVE3cUhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783049778; c=relaxed/simple; bh=wN3lEVyKOMHyjDD6acY7nyX/t554l+VvLqmIJ4eBF6s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dkeguMxlrHYZX886ceAmdEO8hMHMUSHS4OPf6DBZTjkc3NgafQPMv8UQsOleFFjCP+u/fkoFbbwcLWwdg2hDkrvkh151j3JkJ11/Y6AooT+srAevO4wjbv18hfyOTcCnoD4aj7ruYPvBxuNWUrMkyDwLrrEkPtcVAM6NWuDcowI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AHT44WUp; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AHT44WUp" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8f0e5e36912so360146d6.2 for ; Thu, 02 Jul 2026 20:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783049768; x=1783654568; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bPgdxMTOh9PJ/MITH4rM9z6UY/LwynPrTFaYmN69gIQ=; b=AHT44WUp/crhBOO+FQNO1gOovi5rhVVdA5ajXYSASBTHlVyIY2wCIdptwkh9T1xKM/ 3lUPiSRNMWixEvtz83yRFHV2V87VZFWlfXuKsA3/qnYWCcx+r/6LKA1VZgWuj4di7JMG KIfH4m9w2Ty3pY9UtLizYs5MS4g3sI+fV5KQDEvUsszkaO0UT2ToOUsJmBBiMOfF59Wm LOncyA7LPl5bk8zvitaUrUdvYS5HIWZMqPwjKS1VTCwScesfeNAPTUcVpptBSv4zLbr8 rh3Ils8QBpE1F0GNQ6DMa8PEWsyGzL442S1Ak7zJi88wpaMjAbQP5H6KFpx51tjcJksc 0Rzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783049768; x=1783654568; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bPgdxMTOh9PJ/MITH4rM9z6UY/LwynPrTFaYmN69gIQ=; b=jwg3Z+Q+J+q0Hj03loholBTymuA9rB85UYTPCM64NR0fctXjBJdiQ0ENmYDya31Zar tzD3FR7WZqGlAjYJkVEdGUdOyxr/j1SwsV774jLyI2IRR0NYXaYOfsH2CuQEY6WBNowX cUT4+xC3cVDmZVtiAIaMSsAmKWfz7zsCRirAaDo736BfIKlAJedf9PjGOfR8b/c4mzsN WUjK25a8rEK7p5aJiO2JiHK1Bkl8WjTyz9X9mPZyRKnnLlnwqxhkNcY/dG9QEdzsBRhJ eup3xs/cEhyTuWDAX+4DIh0a9fcTAAOFVX73j6SfN8D5nAGLI1M0G2QDOJtjxVr8ckbG ArGg== X-Forwarded-Encrypted: i=1; AHgh+RrfCh+Fr7+6+mJvfIkcprASAvhT4vOzS9ddTUMQfZW45n34ZSEgb/S3PkACgUgsPW5yWrU3P+siquGR2Nk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7uShS3lqVyf+8RAeAbSI5/IqHTtSHw5pDGVOll9DunhGoqp4M opdIW5428L3jp+XgoeFtYM/C2+uCken4RM4WgYmevCxsW4bAPfETY8kN X-Gm-Gg: AfdE7cko5Dv8q8AR/JeDKY+oyT8ysa/qt3FsOP1Eu55Yq3hGjMF10+ZUcJEYo2hM1AK WbSe+QUd4K/QXEAFyG4qR417hsb+PzstVaaYcInbovEgSs6gCWGFd5FYXIZaBdDBWVu+qFxd/OG BZY8ShzcDtjyFrWsnAJ/GzPC60qnbYsBcVGSypFPMNgjnoBpv1R+jU3QMm2pxMZ5wRA1pgOUrvU gdMiHXACuYrz4kXVWYDZ71tOXx6XyrXy+PyybtOxWLeGSKWKUkpXWngSarA4Bj7kaeuyUq4WhOF nycrhi+3UwnjzyBBQq2Pfyq9y/thFZotNcki0QySA6VWyx24QSRb1zVkeRe1ClOkZQm7nQNCigK hkYCxADjRT/l/D4uXg7ImL1s9pLSjrpj8udkVp7O5/N683gU1bYFytggcrvQS7ydHjP59GcyYzC 5H51lGLPvHPrGOWDzthssU3P+J4j3hFpks5KsJ2V0yZcGqpMtIsUycb8FkEczrMVKtM8kj9Cxlw WPJam40xsQfiKc= X-Received: by 2002:a05:6214:4841:b0:8cc:de2:3b5d with SMTP id 6a1803df08f44-8f3c789bc75mr102073386d6.16.1783049767890; Thu, 02 Jul 2026 20:36:07 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46e27d533sm43682316d6.8.2026.07.02.20.36.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 20:36:07 -0700 (PDT) From: Yuho Choi To: "Rafael J . Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] PNP: Fix card device cleanup on registration failure Date: Thu, 2 Jul 2026 23:36:03 -0400 Message-ID: <20260703033603.114931-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit pnp_add_card() ignores __pnp_add_device() failures. If device_register() fails there, the device is removed from the global and protocol lists, but remains on the card list and its device reference is not dropped. Remove the failed device from the card list and call put_device() before continuing with the remaining card devices. Signed-off-by: Yuho Choi --- drivers/pnp/card.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c index 87f5af454751..df5e3d3cbf6c 100644 --- a/drivers/pnp/card.c +++ b/drivers/pnp/card.c @@ -254,9 +254,16 @@ int pnp_add_card(struct pnp_card *card) /* we wait until now to add devices in order to ensure the drivers * will be able to use all of the related devices on the card * without waiting an unreasonable length of time */ - list_for_each(pos, &card->devices) { + list_for_each_safe(pos, temp, &card->devices) { struct pnp_dev *dev = card_to_pnp_dev(pos); - __pnp_add_device(dev); + error = __pnp_add_device(dev); + if (error) { + mutex_lock(&pnp_lock); + list_del(&dev->card_list); + dev->card = NULL; + mutex_unlock(&pnp_lock); + put_device(&dev->dev); + } } /* match with card drivers */ -- 2.43.0