From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C5835200D for ; Fri, 3 Jul 2026 05:03:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783055029; cv=none; b=DZlFf/Ga/YxM55oRKan12KXNBqGsDshk5mliAqMfdLA4+zX6UATbokntvnQed4yjbUGu4CYiS6hmkIuSVLHlLELKXnebAVrw82e0pdz65Rb3YI3DgGAVrnKKuIcQq8uM6e7WjkX0BBqQjtXkRX2b9JCdpYjsFtn2mIrr+2DDjo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783055029; c=relaxed/simple; bh=TuAAEPv2FnYqfxCkiAndHbEEgXy00kllWlsTVXvwO0A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uv0f66MweNvH6sstyUbdQYnyEGAiqC8Z+3in4mFqRcTriZOCble27dzrmCckVkkMCcpw3XadvBEE+wewfWvizjU4nM8W5vCSMEq/DdHmkE/lDwfQILEvHNG9LPEqY/QydNUizBUKhkbzWk2D9fuOh0c5b2a4MsluwyF884x5Mbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tJl/oIGT; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJl/oIGT" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-8efbafa1bacso781836d6.1 for ; Thu, 02 Jul 2026 22:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783055017; x=1783659817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4mjd3S3mD4H3ly0J/O0woiYTVd9pmAc7B7F5gVF6+rg=; b=tJl/oIGTGD+lO0KDWPtrlFYl6y4dGEv0kDXOjHu4LH2NE9lhmcYe0MlJncT4LKPO5c bPBdrzBe88tsjqUu0gc1KZ43fTyYzkzoCRde8pMyt7gOCaIKVTwKNS4rSpqTnUmzBUdR nw6C8e+1FbY7qdhE4NrUtzLzSu9UuxJM+NbAVHM/2T60byP606fD9UVR+sHAkiAnc9/k Goq/kPgDkXCSMG49hPfgGSrOakQt1X4iawgWICVzXsgRjzgGNQ0tNoGkAoTaxd0Jvcey 7eaSL3IRmwOHEwgKq1eQuEt7YbTgegTanxL6mRgcLt0w0IPtPZQ0HBKBNY/49xpXwqVK 3pyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783055017; x=1783659817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4mjd3S3mD4H3ly0J/O0woiYTVd9pmAc7B7F5gVF6+rg=; b=pFWg8vq78L3bFaySJOYHHTBlNf4vwvmYSBComhNhpu3bJkAI0fxu9C6Atwjt9xnUk6 uNZPI+pHVT52Zj0wwxdmtvO2V3N4ZTejLbpsBxetpdWjis7vLUHmxZ3/ueqeLyJBG3Lz JrZOm1yCQOTP9RWwcghuLhhZ8ErrrC/CsN5i0hy4s9Sv2V7yQqhI2xq7rdQl0jDIGA8g y1sfWU72g1zLVHYbOtvsE78C0eHohBWqbt3dFms1v2A+5PnZa5j8En+J/KgLQxdGe0FD UULyry1rrmHtSeIXbpybGfmbHK0Y04pyhwn8d5kP1XWIDZMD9y5atboEi5m3/Clop1g+ lr6w== X-Forwarded-Encrypted: i=1; AHgh+Rp7FXYk0WhoDAwdMb2M49Au78pzYAT0sftQl0hoMHNbZzfpJAdhSOPgbUD6fZa4kda5pAW9HIgck9mBHdE=@vger.kernel.org X-Gm-Message-State: AOJu0YzY2Jm2F5oPkUwIO7l8v3yIrUbJnLjXu8+7yJfFF7ka7iQ9cPw0 to+jglgqXD+IeIeJg2ZCUOLGmCvrkreDwSOW3nCl3SAozwlojDhKF68u X-Gm-Gg: AfdE7ckfstlKlru2Ef6dV+9FkpbIqH2FAqAKstwYc42BTKz4yPvJbTIWjrKOH1a9Xq0 C4TDCK8ZdRCBQB+HHrXQiB/gQbIqRJu6Is97q9ylSTzZ49hKlkUoH971MW1wwA8rqrn8s/VPNdG 7Cd0jJcyN4SmB7zYort2wR9R4Id0XQH2/fWOy4byW1TuQ0ARHdAHAJ+G+jO7vWhGgPjyGdWzp4o gVs+5V6JT+m4PP85JAloCnu9wWUJp9/CzFjdsblMK0+p8hOLxsfM2mtl3wwUq3vWCY/8f1XjRIt rqnWrs7jfSco2x68NPfwJ9C8lEjMY7ehQN+O2AOXXvoH1hIEaV6YRccw+2jjXk4L6T7YmtOMZ2K G3S9ruhMDK9nOGYrocZg6s/bqBF8XSNxJxSXxcjIg4jSfxYQKmTXeXr+spUcDsgsnbSEumHfq53 KGEguyXiqbww8ZljoD9KcFpuy1lYPqudWqGWdrxXrw4ieZRoLo055D+G8GItKrMwar+KNORp4dy kTBVfZi5FBhdmE= X-Received: by 2002:a05:6214:4302:b0:8e7:d752:ab34 with SMTP id 6a1803df08f44-8f3c66c558amr133708806d6.12.1783055017034; Thu, 02 Jul 2026 22:03:37 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46e27d53fsm46576866d6.5.2026.07.02.22.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 22:03:36 -0700 (PDT) From: Yuho Choi To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH net v2] idpf: Fix mailbox IRQ name leak on request failure Date: Fri, 3 Jul 2026 01:03:32 -0400 Message-ID: <20260703050332.121551-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit idpf_mb_intr_req_irq() allocates the mailbox IRQ name before calling request_irq(). On success, the name is released later through kfree(free_irq()), but request_irq() failure returns without freeing it. Free the allocated name on the request_irq() failure path. Fixes: 4930fbf419a7 ("idpf: add core init and interrupt request") Signed-off-by: Yuho Choi --- Changes in v2: - Add net tag for the patch subject line. drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index cf966fe6c759..bb81e620c5c8 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -139,7 +139,7 @@ static int idpf_mb_intr_req_irq(struct idpf_adapter *adapter) if (err) { dev_err(&adapter->pdev->dev, "IRQ request for mailbox failed, error: %d\n", err); - + kfree(name); return err; } -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52DA5C44500 for ; Mon, 6 Jul 2026 15:23:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0FD3540519; Mon, 6 Jul 2026 15:23:35 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id mIe5Qkblt51Q; Mon, 6 Jul 2026 15:23:34 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8F6C540A65 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1783351414; bh=4mjd3S3mD4H3ly0J/O0woiYTVd9pmAc7B7F5gVF6+rg=; h=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=KE8FsvOYt9r1TP845RU5F9uA4HlYTf/CVhqGUvcfKeaVHKszb4Ttrfdy1rWeM5jKC OYA92tBQQA97GeCU3kWZvdTYNvyeZ7WKg9vpdKqpE7nUN9Dwikb0T4sEmEQrNX+XLq dB2LFGhg/l84IwTLlSDRAGRYllCkHclS+WwBH1n8EbnIz6u5S5YZbd4GMnT2gd2VFN qQtf5J4TMRzjXy9MXlzPsKS0n4yDWxldVgjuP8sTNOMDgYY6d9uMq+m/puji64EY0G bNEvBzNr1EDCBgRNJnjm7lRhifGbJCcSnL+XCaiFtw1LZeEXkCkWkYS3yxeg+f9vsR YDnf/UnqcSSpQ== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 8F6C540A65; Mon, 6 Jul 2026 15:23:34 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 5E5DA316 for ; Fri, 3 Jul 2026 05:03:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 5C727403C4 for ; Fri, 3 Jul 2026 05:03:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id yqu1uih1ycAE for ; Fri, 3 Jul 2026 05:03:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::f33; helo=mail-qv1-xf33.google.com; envelope-from=dbgh9129@gmail.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 935D040378 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 935D040378 Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by smtp2.osuosl.org (Postfix) with ESMTPS id 935D040378 for ; Fri, 3 Jul 2026 05:03:38 +0000 (UTC) Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-8e9c9d63815so364046d6.2 for ; Thu, 02 Jul 2026 22:03:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783055017; x=1783659817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4mjd3S3mD4H3ly0J/O0woiYTVd9pmAc7B7F5gVF6+rg=; b=bWNiEzAFKDM3vYJdAHv/KmGrsTT/06WbRK6oX3xSRKPzIhL4E07rG5zqEph7GmL8mK H95laNtHgKvFSYYw0j6U+JwtUkSntE9kZQPX6LC+bUnb1ZjLhtwj4sgIbfZDW0NY6tFW gDiwLAz6BIVaitrqPrlyLtJfSXb7X/elHIo+R8TLakBOHPxb/Q1NQ+JdwNBTDwY8D830 dfYznUenTuFbzbf+MxRwWhij278/JIkGkAZaDNWszI7FgcAZ/d6c2xY/99/+c46UDAu/ mZMkz2TQXFJG0HzUuor5YVYartaiK050yDbgft1BrWqxSDSlfFveb4hsA8KtcqViScXE zMMA== X-Gm-Message-State: AOJu0YwLUdItSEOk8+iVhpMzMgTrdD6nLky6yCK4HQ8l7WR0yPuQhoF5 li3k+mGmyaQZ6iWQSmT4BRMd0pjoqLwrOac1ncVM33e9HtOFM2zh8vQC X-Gm-Gg: AfdE7cn6rtaMckG41dnZ5KCHbvNC55TYjKLqS7bVC4Oxxn5xjyU8xriIeq+5am36mUV 0uG8cuNzOOJ3C0fv31gHiqpkWjYj13F6pRcGd46BI33yyBs8CL8sqJyAmQFXVZggSLyF8YlGGsM cn/iyx+VyVUcHHX97Dz4OfMgj43/I9KqVpLqudZzDpGY6/brpdPZH3drfdqLww9Xys7YBFIs9C6 9CRbJCKNs2AgnjtmgKFhRJk6lpn+hJ/bcL9HiCcx0Gy9KJL1LRBVFQgEcnYhs4AbYfzoIR/auAC imKPpAfRHozS4CAfarQQMnaas4ZiwTSYfYjZbjgmF2T/5xwB6kkMtljXn5LCT+MZXpTaDTESzGE ITNDIGxg7Ssi78iHTgD5fKDVF1V+5xgZdG16T43bOpUZrLykAk2uQRUJQJ+70mrmxt4ylWXO1tg c7Qe4JAsyOsEvUVfAn1zNRq3YtSTQPN/gYC1xhCvHLMETD1QljPqEg+//mlL28uX4iRNepk7VP/ OVbzoD2Zds/BFw= X-Received: by 2002:a05:6214:4302:b0:8e7:d752:ab34 with SMTP id 6a1803df08f44-8f3c66c558amr133708806d6.12.1783055017034; Thu, 02 Jul 2026 22:03:37 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8f46e27d53fsm46576866d6.5.2026.07.02.22.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2026 22:03:36 -0700 (PDT) From: Yuho Choi To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yuho Choi Date: Fri, 3 Jul 2026 01:03:32 -0400 Message-ID: <20260703050332.121551-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 06 Jul 2026 15:23:32 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783055017; x=1783659817; darn=lists.osuosl.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4mjd3S3mD4H3ly0J/O0woiYTVd9pmAc7B7F5gVF6+rg=; b=ZGqevHAYh79OWJpqRaFkkLbZVMD2120Wg7EbWD6McGpFPg/fah1FqpiogNJAU1jJWv 3sldtoXyCSPihCSChOrE/imJ1vsN2cIuaeQumbHcnP30t8+Jo4BokIdgKGPU9PnOloX9 Xs8tlGr6cXiK64QfC67R9Q6mtvE/w/3vfFVzPN/Va/eUKFRghMA2QxxI6RqqMf4GK1+m Hl2cX1aN58k0/A4hL9J5l597klnHpzX6Ly+4WH0YLT4H/QyRSGNY8TYMZVzFnoexnPiZ oQ/YvuGVGbNeah6qcVmxhyyS0BvHrVr/l2nCmiuM5Mg1UBOBwPlpeO315sZ7uO2ej/rr XMwQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=gmail.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ZGqevHAY Subject: [Intel-wired-lan] [PATCH net v2] idpf: Fix mailbox IRQ name leak on request failure X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" idpf_mb_intr_req_irq() allocates the mailbox IRQ name before calling request_irq(). On success, the name is released later through kfree(free_irq()), but request_irq() failure returns without freeing it. Free the allocated name on the request_irq() failure path. Fixes: 4930fbf419a7 ("idpf: add core init and interrupt request") Signed-off-by: Yuho Choi --- Changes in v2: - Add net tag for the patch subject line. drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c index cf966fe6c759..bb81e620c5c8 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -139,7 +139,7 @@ static int idpf_mb_intr_req_irq(struct idpf_adapter *adapter) if (err) { dev_err(&adapter->pdev->dev, "IRQ request for mailbox failed, error: %d\n", err); - + kfree(name); return err; } -- 2.43.0