Re: [PATCH v3 5/6] arm64: dts: qcom: ipq5018: add nodes required for Bluetooth support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Adding the 'syscon' compatible string to the 'apcs_glb' node without updating the device tree binding schema violates the schema and causes dtbs_check failures.
--

commit 8f9212782ff3d8470d83aca03720126dc8c3c25b
Author: George Moussalem <george.moussalem@outlook.com>

arm64: dts: qcom: ipq5018: add nodes required for Bluetooth support

This commit adds device tree nodes for the reserved memory carveout and
Bluetooth on the ipq5018 platform. It also modifies the apcs_glb
mailbox node to include "syscon" in its compatible list.

> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index 6f8004a22a1ff..65a47ba7d3a34 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi

[ ... ]

> @@ -647,7 +669,8 @@ watchdog: watchdog@b017000 {
>  
>  		apcs_glb: mailbox@b111000 {
>  			compatible = "qcom,ipq5018-apcs-apps-global",
> -				     "qcom,ipq6018-apcs-apps-global";
> +				     "qcom,ipq6018-apcs-apps-global",
> +				     "syscon";
                     ^^^^^^^^

[Severity: Low]
Will adding "syscon" here without updating the device tree binding schema
cause a make dtbs_check validation failure?

Looking at Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml,
the schema currently restricts the compatible list for this hardware to exactly
two items:

      - items:
          - enum:
              - qcom,ipq5018-apcs-apps-global
              - qcom,ipq5332-apcs-apps-global
              - qcom,ipq5424-apcs-apps-global
              - qcom,ipq8074-apcs-apps-global
              - qcom,ipq9574-apcs-apps-global
          - const: qcom,ipq6018-apcs-apps-global

Does the yaml binding need to be updated alongside this patch to permit
"syscon" as a third compatible string for this device?

>  			reg = <0x0b111000 0x1000>;
>  			#clock-cells = <1>;
>  			clocks = <&a53pll>, <&xo_board_clk>, <&gcc GPLL0>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-ipq5018-bluetooth-v3-0-62da72818ab3@outlook.com?part=5