All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Tzung-Bi Shih <tzungbi@kernel.org>,
	David Rhodes <david.rhodes@cirrus.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Cheng-Yi Chiang <cychiang@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	povik+lin@cutebit.org, u.kleine-koenig@baylibre.com,
	kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com,
	Linus Walleij <linusw@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Thorsten Blum <thorsten.blum@linux.dev>,
	Chris Morgan <macromorgan@hotmail.com>,
	Dan Carpenter <error27@gmail.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Rosen Penev <rosenp@gmail.com>,
	Weidong Wang <wangweidong.a@awinic.com>,
	Teguh Sobirin <teguh@sobir.in>, Val Packett <val@packett.cool>,
	Luca Weiss <luca.weiss@fairphone.com>,
	wangdicheng <wangdicheng@kylinos.cn>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com, chrome-platform@lists.linux.dev,
	asahi@lists.linux.dev, bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 23/24] ASoC: codecs: cs48l32: Use guard() for mutex locks
Date: Fri,  3 Jul 2026 12:53:54 +0700	[thread overview]
Message-ID: <20260703055355.244898-24-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260703055355.244898-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

Changes in v2:
  Removed the unnecessary else block so update_bits() 
  is not called when no changes are needed. 

 sound/soc/codecs/cs48l32.c | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/sound/soc/codecs/cs48l32.c b/sound/soc/codecs/cs48l32.c
index 086ed0f57a85..a9967771124e 100644
--- a/sound/soc/codecs/cs48l32.c
+++ b/sound/soc/codecs/cs48l32.c
@@ -8,6 +8,7 @@
 #include <dt-bindings/sound/cs48l32.h>
 #include <linux/array_size.h>
 #include <linux/build_bug.h>
+#include <linux/cleanup.h>
 #include <linux/clk.h>
 #include <linux/container_of.h>
 #include <linux/delay.h>
@@ -236,15 +237,13 @@ static int cs48l32_rate_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_v
 	int ret;
 
 	/* Prevent any mixer mux changes while we do this */
-	mutex_lock(&cs48l32_codec->rate_lock);
+	guard(mutex)(&cs48l32_codec->rate_lock);
 
 	/* The write must be guarded by a number of SYSCLK cycles */
 	cs48l32_spin_sysclk(cs48l32_codec);
 	ret = snd_soc_put_enum_double(kcontrol, ucontrol);
 	cs48l32_spin_sysclk(cs48l32_codec);
 
-	mutex_unlock(&cs48l32_codec->rate_lock);
-
 	return ret;
 }
 
@@ -2242,7 +2241,6 @@ static int cs48l32_dai_set_sysclk(struct snd_soc_dai *dai,
 	struct cs48l32_dai_priv *dai_priv = &cs48l32_codec->dai[dai->id - 1];
 	unsigned int base = dai->driver->base;
 	unsigned int current_asp_rate, target_asp_rate;
-	bool change_rate_domain = false;
 	int ret;
 
 	if (clk_id == dai_priv->clk)
@@ -2284,19 +2282,15 @@ static int cs48l32_dai_set_sysclk(struct snd_soc_dai *dai,
 
 		if ((current_asp_rate & CS48L32_ASP_RATE_MASK) !=
 		    (target_asp_rate & CS48L32_ASP_RATE_MASK)) {
-			change_rate_domain = true;
-
-			mutex_lock(&cs48l32_codec->rate_lock);
 			/* Guard the rate change with SYSCLK cycles */
-			cs48l32_spin_sysclk(cs48l32_codec);
-		}
-
-		snd_soc_component_update_bits(component, base + CS48L32_ASP_CONTROL1,
-					      CS48L32_ASP_RATE_MASK, target_asp_rate);
-
-		if (change_rate_domain) {
-			cs48l32_spin_sysclk(cs48l32_codec);
-			mutex_unlock(&cs48l32_codec->rate_lock);
+			scoped_guard(mutex, &cs48l32_codec->rate_lock) {
+				cs48l32_spin_sysclk(cs48l32_codec);
+				snd_soc_component_update_bits(component,
+							      base + CS48L32_ASP_CONTROL1,
+							      CS48L32_ASP_RATE_MASK,
+							      target_asp_rate);
+				cs48l32_spin_sysclk(cs48l32_codec);
+			}
 		}
 	}
 
-- 
2.43.0


  parent reply	other threads:[~2026-07-03  5:57 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03  5:53 [PATCH v2 00/24] ASoC: codecs: Use guard() for mutex & spin lock - part 1 phucduc.bui
2026-07-03  5:53 ` [PATCH v2 01/24] ASoC: codecs: ab8500: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 02/24] ASoC: codecs: ak4613: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers phucduc.bui
2026-07-06 12:58   ` Charles Keepax
2026-07-07  2:29     ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 04/24] ASoC: codecs: arizona: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 05/24] ASoC: codecs: aw87390: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 06/24] ASoC: codecs: aw88081: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 07/24] ASoC: codecs: aw88166: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 08/24] ASoC: codecs: aw88261: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 09/24] ASoC: codecs: aw88395: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 10/24] ASoC: codecs: aw88399: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 11/24] ASoC: codecs: cros_ec_codec: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 12/24] ASoC: codecs: cs-amp-lib: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 13/24] ASoC: codecs: cs35l56: Use guard() and PM runtime scope helpers phucduc.bui
2026-07-06  9:38   ` Richard Fitzgerald
2026-07-06 10:12   ` Cezary Rojewski
2026-07-06 10:46     ` Bui Duc Phuc
2026-07-06 10:58       ` Richard Fitzgerald
2026-07-06 12:37         ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 14/24] ASoC: codecs: cs42l42: Use guard() cleanup helpers phucduc.bui
2026-07-03  5:53 ` [PATCH v2 15/24] ASoC: codecs: cs42l43: Use guard() and PM runtime scope helpers phucduc.bui
2026-07-06 13:18   ` Charles Keepax
2026-07-07  3:59     ` Bui Duc Phuc
2026-07-03  5:53 ` [PATCH v2 16/24] ASoC: codecs: cs42l84: Use guard() for mutex locks phucduc.bui
2026-07-03  5:53 ` [PATCH v2 17/24] ASoC: codecs: cs43130: " phucduc.bui
2026-07-06 13:20   ` Charles Keepax
2026-07-03  5:53 ` [PATCH v2 18/24] ASoC: codecs: cs47l15: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 19/24] ASoC: codecs: cs47l35: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 20/24] ASoC: codecs: cs47l85: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 21/24] ASoC: codecs: cs47l90: " phucduc.bui
2026-07-03  5:53 ` [PATCH v2 22/24] ASoC: codecs: cs47l92: " phucduc.bui
2026-07-03  5:53 ` phucduc.bui [this message]
2026-07-06 13:23   ` [PATCH v2 23/24] ASoC: codecs: cs48l32: " Charles Keepax
2026-07-03  5:53 ` [PATCH v2 24/24] ASoC: codecs: cs2072x: " phucduc.bui
2026-07-06 10:21 ` [PATCH v2 00/24] ASoC: codecs: Use guard() for mutex & spin lock - part 1 Cezary Rojewski
2026-07-07  4:40   ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703055355.244898-24-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=arnd@arndb.de \
    --cc=asahi@lists.linux.dev \
    --cc=bleung@chromium.org \
    --cc=broonie@kernel.org \
    --cc=christian.ehrhardt@codasip.com \
    --cc=chrome-platform@lists.linux.dev \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=cychiang@chromium.org \
    --cc=david.rhodes@cirrus.com \
    --cc=error27@gmail.com \
    --cc=groeck@chromium.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=macromorgan@hotmail.com \
    --cc=marco.crivellari@suse.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=rf@opensource.cirrus.com \
    --cc=rosenp@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=teguh@sobir.in \
    --cc=thorsten.blum@linux.dev \
    --cc=tiwai@suse.com \
    --cc=tzungbi@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=val@packett.cool \
    --cc=wangdicheng@kylinos.cn \
    --cc=wangweidong.a@awinic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.