Re: [RFC PATCH 1/6] selftests/vfio: allow selecting IOMMU backend from environment

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] A syntax error is introduced at the end of the file due to stray duplicated code.
- [Low] The macro `MODE_VFIO_SPAPR_TCE_V2_IOMMU` is referenced but never defined, breaking the build on PowerPC.
--

commit 711defe4ecc8034b88efefbbf07a52494153b474
Author: Narayana Murty N <nnmlinux@linux.ibm.com>

selftests/vfio: allow selecting IOMMU backend from environment
    
This commit adds support for selecting the IOMMU mode through the
VFIO_SELFTESTS_IOMMU_MODE environment variable. It validates the environment
variable against a list of supported modes, including sPAPR TCE v2 on PowerPC.

> diff --git a/tools/testing/selftests/vfio/lib/libvfio.c b/tools/testing/selftests/vfio/lib/libvfio.c
> index 3a3d1ed635c1d..617c8dc7288ca 100644
> --- a/tools/testing/selftests/vfio/lib/libvfio.c
> +++ b/tools/testing/selftests/vfio/lib/libvfio.c

[ ... ]

> @@ -101,3 +101,42 @@ void *mmap_reserve(size_t size, size_t align, size_t offset)
>  
>  	return map_align;
>  }
> +
> +static const char *get_iommu_mode_env(void)
> +{
> +	const char *mode;
> +	static const char * const valid_modes[] = {
> +		MODE_VFIO_TYPE1_IOMMU,
> +		MODE_VFIO_TYPE1V2_IOMMU,
> +		MODE_IOMMUFD_COMPAT_TYPE1,
> +		MODE_IOMMUFD_COMPAT_TYPE1V2,
> +		MODE_IOMMUFD,
> +#ifdef __powerpc__
> +		MODE_VFIO_SPAPR_TCE_V2_IOMMU,

[Severity: Low]
Does this break the build on PowerPC because MODE_VFIO_SPAPR_TCE_V2_IOMMU is
referenced but never defined?

I notice this is fixed in a later commit
8dfc3e7df9b7153c07746fbc4679447d70174937 ("selftests/vfio: add sPAPR TCE v2
IOMMU mode"), but introducing an undefined identifier here will cause git
bisect failures for PowerPC builds.

> +#endif
> +	};

[ ... ]

> +const char *vfio_selftests_get_iommu_mode(void)
> +{
> +	return get_iommu_mode_env();
> +}
> +
> +	return map_align;
> +}

[Severity: Low]
Is this stray return statement and closing brace a copy-paste error?

It causes a syntax error at the file scope. I see this is removed in a later
commit 2deeaa397a1d09614f068ff5ae82a0732c573cd4 ("selftests/vfio: add sPAPR
TCE v2 DMA window helpers"), but having it in this patch breaks the build
and git bisect.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703032806.40946-1-nnmlinux@linux.ibm.com?part=1