Re: [PATCH v1 1/1] arm64: dts: freescale: imx95-var-dart: enable NETC block control

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing dependency for `netc_blk_ctrl` causing a potential system hang on boot.
--

commit 14e353bd1da7516058662c0b4b79b720409b4211
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: freescale: imx95-var-dart: enable NETC block control

This commit enables the NETC block control node on the DART-MX95 SoM,
which is necessary for the NETC Ethernet ports to function.

> diff --git a/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi b/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
> index a20fadacaa6d8..7c29082a40c5b 100644
> --- a/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx95-var-dart.dtsi
> @@ -176,6 +176,10 @@ &mu7 {
>  	status = "okay";
>  };
>  
> +&netc_blk_ctrl {
> +	status = "okay";
> +};
> +

[Severity: High]
Does missing the netcmix_blk_ctrl dependency here risk a system hang on boot?

The nxp,imx95-netc-blk-ctrl driver maps the netcmix memory block and writes
to it unconditionally during probe. Accessing this region safely requires
the IMX95_CLK_BUSNETCMIX bus clock to be enabled.

Since that clock is exclusively requested and managed by the
nxp,imx95-netcmix-blk-ctrl clock controller driver, leaving netcmix_blk_ctrl
disabled means the kernel won't enable the required bus clock.

If the bootloader leaves the clock off, this will crash with an SError /
asynchronous external abort during netc_blk_ctrl_probe(). Even if the
bootloader leaves it on, clk_disable_unused() might turn it off later,
crashing the system on any subsequent accesses.

Should netcmix_blk_ctrl be enabled alongside netc_blk_ctrl to satisfy this
hardware dependency?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703144922.231608-1-stefano.r@variscite.com?part=1