From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [agd5f:amd-staging-drm-next 3205/3402] drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c:537 amdgpu_device_ip_soft_reset() error: we previously assumed 'ip_block' could be null (see line 536)
Date: Fri, 03 Jul 2026 17:43:38 +0800 [thread overview]
Message-ID: <202607031711.yLwFhGfp-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: "Timur Kristóf" <timur.kristof@gmail.com>
CC: Alexander Deucher <alexander.deucher@amd.com>
tree: https://gitlab.freedesktop.org/agd5f/linux.git amd-staging-drm-next
head: e3cc8c108f9a91728f9ff6e24cbf3b41c58b8f8b
commit: a6319ac34a1322cc70c8aa7a3b06a558dc4f68a5 [3205/3402] drm/amdgpu: Add IP block soft reset as a GPU recovery method
:::::: branch date: 2 days ago
:::::: commit date: 2 weeks ago
config: i386-randconfig-r073-20260702 (https://download.01.org/0day-ci/archive/20260703/202607031711.yLwFhGfp-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9185-gbcc58b9c
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202607031711.yLwFhGfp-lkp@intel.com/
smatch warnings:
drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c:537 amdgpu_device_ip_soft_reset() error: we previously assumed 'ip_block' could be null (see line 536)
vim +/ip_block +537 drivers/gpu/drm/amd/amdgpu/amdgpu_ip.c
a6319ac34a1322 Timur Kristóf 2026-06-17 505
a6319ac34a1322 Timur Kristóf 2026-06-17 506 /**
a6319ac34a1322 Timur Kristóf 2026-06-17 507 * amdgpu_device_ip_soft_reset() - Perform a graceful soft reset on an IP block.
a6319ac34a1322 Timur Kristóf 2026-06-17 508 *
a6319ac34a1322 Timur Kristóf 2026-06-17 509 * @guilty_ring: The ring which is guilty of causing a reset.
a6319ac34a1322 Timur Kristóf 2026-06-17 510 * @guilty_fence: The fence which didn't signal.
a6319ac34a1322 Timur Kristóf 2026-06-17 511 *
a6319ac34a1322 Timur Kristóf 2026-06-17 512 * IP block soft reset is used when attempting to recover
a6319ac34a1322 Timur Kristóf 2026-06-17 513 * from a GPU hang in a situation where a more fine grained
a6319ac34a1322 Timur Kristóf 2026-06-17 514 * reset type isn't available or didn't work. This effectively
a6319ac34a1322 Timur Kristóf 2026-06-17 515 * resets all rings that belong to the same device IP block
a6319ac34a1322 Timur Kristóf 2026-06-17 516 * and re-initializes the device IP block.
a6319ac34a1322 Timur Kristóf 2026-06-17 517 *
a6319ac34a1322 Timur Kristóf 2026-06-17 518 * The reset is handled gracefully, meaning that we try to
a6319ac34a1322 Timur Kristóf 2026-06-17 519 * minimize collateral damage (ie. avoid rejecting non-guilty jobs)
a6319ac34a1322 Timur Kristóf 2026-06-17 520 * as well as back up and restore the contents of all rings
a6319ac34a1322 Timur Kristóf 2026-06-17 521 * so that the system can move on from the hang.
a6319ac34a1322 Timur Kristóf 2026-06-17 522 */
a6319ac34a1322 Timur Kristóf 2026-06-17 523 int amdgpu_device_ip_soft_reset(struct amdgpu_ring *guilty_ring,
a6319ac34a1322 Timur Kristóf 2026-06-17 524 struct amdgpu_fence *guilty_fence)
a6319ac34a1322 Timur Kristóf 2026-06-17 525 {
a6319ac34a1322 Timur Kristóf 2026-06-17 526 struct amdgpu_device *adev = guilty_ring->adev;
a6319ac34a1322 Timur Kristóf 2026-06-17 527 struct amdgpu_ring *rings[AMDGPU_MAX_RINGS];
a6319ac34a1322 Timur Kristóf 2026-06-17 528 struct amdgpu_ip_block *ip_block;
a6319ac34a1322 Timur Kristóf 2026-06-17 529 enum amd_ip_block_type ip_type;
a6319ac34a1322 Timur Kristóf 2026-06-17 530 u32 num_rings, ring_type_mask;
a6319ac34a1322 Timur Kristóf 2026-06-17 531 int r;
a6319ac34a1322 Timur Kristóf 2026-06-17 532
a6319ac34a1322 Timur Kristóf 2026-06-17 533 ip_type = amdgpu_ip_from_ring(guilty_ring->funcs->type);
a6319ac34a1322 Timur Kristóf 2026-06-17 534 ip_block = amdgpu_device_ip_get_ip_block(adev, ip_type);
a6319ac34a1322 Timur Kristóf 2026-06-17 535
a6319ac34a1322 Timur Kristóf 2026-06-17 @536 if (!ip_block || !ip_block->version->funcs->soft_reset) {
a6319ac34a1322 Timur Kristóf 2026-06-17 @537 dev_warn(adev->dev, "IP block soft reset not supported on %s\n",
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-07-03 9:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202607031711.yLwFhGfp-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.