From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 657C3C43458 for ; Fri, 3 Jul 2026 23:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bl9vJ762PS3tOGzev8EYglrLouITcPOsVIwfYKH+KAM=; b=tFHdVwh940r+k/ 1/B7rFyFj9uhAxPXuC16vJf4PLB7aAFni184rO3ueuq9U/YX6oNbqDXyigMdXWumbhKnio+qdD8p2 LPU4Gr3fHH2JlQMASXhqZyn1DMk8htBWlD8FjjEhxZJcTB9CQr6r2D4oYr4jYjG1L7WL1JdmrHzaC CJMD4uS5JVlFHZW8yLvrhAIgdtT864c1JwoHGNmPoXuc+oVb6NmYBNMYErZTPwEizJa/0CUISd9tp uM8ZQKS/Knvwcjno6gkBFrDAcZ1lkClT37W51/qSjWNsjOWfZGEX9qoboTUj0trodAXTDaqsuAIvs 2gzitphUuDnNoidB7B1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfndk-000000081mI-00uR; Fri, 03 Jul 2026 23:49:48 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfndi-000000081mA-0Mt4 for linux-phy@lists.infradead.org; Fri, 03 Jul 2026 23:49:46 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 16E3D4323F; Fri, 3 Jul 2026 23:49:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96D701F000E9; Fri, 3 Jul 2026 23:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783122584; bh=/x3PSLlONBl/BZ7lR2rqsLDqhhtW/0J64dFPP+tzcPc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ahnGbnQixx0Eck3NjfsJPbWf10bFXFGR2xaFJ2dtVv3qvIFhdaaipMaH8UQ00ViMB ljfcCzUYBNX2k3f8u9Jbj+63oCqA45Aj/XxUxLmoPHi0GYv/fANvQVbY7X5c9MgbjG 9m67RY7Bkt11oho79SbHMDPb4yWN+gKCtLl37i7MuM88LvgB1S//WdIs1IYZAyJPVf VnqFgDcPT6ex5YCOgBLT3MmcHST/XsNqt4Du04J0sMEZnNnRHJWiqCNR0rqsSDWWVi O5Ev+isXUa7H5Jb1/A2LaGhwVFleZx0FqtccIrE8vSeI9eB1uOlJgfCSsmJAe8Wdv/ tYL2+4DlYmP8A== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 23/36] phy: rockchip: usbdp: Clear USB status on PHY exit To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-23-a392711ca8a9@collabora.com> References: <20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com> <20260703-rockchip-usbdp-cleanup-v10-23-a392711ca8a9@collabora.com> Date: Fri, 03 Jul 2026 23:49:43 +0000 Message-Id: <20260703234943.96D701F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIENsZWFyaW5nIGB1ZHBo eS0+c3RhdHVzYCBkaXJlY3RseSB3aXRob3V0IGNoZWNraW5nIGlmIHRoZSBQSFkgaGFyZHdhcmUg c2hvdWxkIGJlIGRpc2FibGVkIGNhdXNlcyBhbiB1bmJvdW5kZWQgY2xvY2sgcmVmZXJlbmNlIGNv dW50IGxlYWsuCi0tCgpjb21taXQgZTgzNmMzZDliOTI5OTYxMTNjYjg1OTNmOTNiZjQ4MTUyZWQ1 ZGU2YwpBdXRob3I6IFNlYmFzdGlhbiBSZWljaGVsIDxzZWJhc3RpYW4ucmVpY2hlbEBjb2xsYWJv cmEuY29tPgoKcGh5OiByb2NrY2hpcDogdXNiZHA6IENsZWFyIFVTQiBzdGF0dXMgb24gUEhZIGV4 aXQKClRoaXMgY29tbWl0IGVuc3VyZXMgdGhlIFVTQiBzdGF0dXMgZmxhZyBpcyBjbGVhcmVkIHdo ZW4gdGhlIFVTQjMgUEhZIGlzCmV4aXRlZCB3aGlsZSB0aGUgc3lzdGVtIGlzIGluIERQLW9ubHkg bW9kZS4gVGhpcyBoYXBwZW5zIGlmIHRoZSBVU0IzCmNvbnRyb2xsZXIgZGV2aWNlIGlzIHVuYm91 bmQgd2hpbGUgYSBEUC1vbmx5IGFkYXB0ZXIgaXMgcGx1Z2dlZCBpbi4KCkNsb3NlczogaHR0cHM6 Ly9zYXNoaWtvLmRldi8jL21lc3NhZ2UvMjAyNjA2MjUtcm9ja2NoaXAtdXNiZHAtY2xlYW51cC12 Ny0yNC0zOGViM2NmNjU0ZmQlNDBjb2xsYWJvcmEuY29tCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYyBiL2RyaXZlcnMvcGh5L3JvY2tjaGlw L3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gLS0tIGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLXVzYmRwLmMKPiArKysgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAt dXNiZHAuYwo+IEBAIC0xMjczLDggKzEyNzMsMTAgQEAgc3RhdGljIGludCBya191ZHBoeV91c2Iz X3BoeV9leGl0KHN0cnVjdCBwaHkgKnBoeSkKPiAgCWd1YXJkKG11dGV4KSgmdWRwaHktPm11dGV4 KTsKPiAgCj4gIAkvKiBEUCBvbmx5IG9yIGhpZ2gtc3BlZWQgKi8KPiAtCWlmICghKHVkcGh5LT5t b2RlICYgVURQSFlfTU9ERV9VU0IpIHx8IHVkcGh5LT5ocykKPiArCWlmICghKHVkcGh5LT5tb2Rl ICYgVURQSFlfTU9ERV9VU0IpIHx8IHVkcGh5LT5ocykgewo+ICsJCXVkcGh5LT5zdGF0dXMgJj0g flVEUEhZX01PREVfVVNCOwo+ICAJCXJldHVybiAwOwo+ICsJfQo+ICAKPiAgCXJrX3VkcGh5X3Bv d2VyX29mZih1ZHBoeSwgVURQSFlfTU9ERV9VU0IpOwoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIGNs ZWFyaW5nIHVkcGh5LT5zdGF0dXMgd2l0aG91dCBhY3R1YWxseSBkaXNhYmxpbmcgdGhlIGhhcmR3 YXJlIGNhdXNlIGFuCnVuYm91bmRlZCBjbG9jayByZWZlcmVuY2UgY291bnQgbGVhaz8KCldoZW4g dGhlIHN5c3RlbSBzd2l0Y2hlcyB0byBEUC1vbmx5IG1vZGUsIHVkcGh5LT5tb2RlIGxvc2VzIHRo ZQpVRFBIWV9NT0RFX1VTQiBiaXQuIElmIHRoZSBVU0IgY29udHJvbGxlciBpcyB0aGVuIHVuYm91 bmQsIHdlIGhpdCB0aGlzIHBhdGgKYW5kIGNsZWFyIFVEUEhZX01PREVfVVNCIGZyb20gdWRwaHkt PnN0YXR1cywgYnV0IHJldHVybiBlYXJseS4gVGhlIGhhcmR3YXJlCmNsb2NrcyByZW1haW4gZW5h YmxlZCBzaW5jZSB3ZSBieXBhc3MgdGhlIGhhcmR3YXJlIGRpc2FibGUgY2FsbC4KCklmIHRoZSBz eXN0ZW0gdGhlbiBzd2l0Y2hlcyBiYWNrIHRvIFVTQiBtb2RlLCBya191ZHBoeV91c2IzX3BoeV9p bml0KCkgd2lsbApzZWUgdWRwaHktPnN0YXR1cyBhcyBVRFBIWV9NT0RFX05PTkUgYW5kIGNhbGwg cmtfdWRwaHlfc2V0dXAoKS4gVGhpcyBjYWxscwpjbGtfYnVsa19wcmVwYXJlX2VuYWJsZSgpIGFn YWluLCBpbmNyZW1lbnRpbmcgdGhlIGNsb2NrIHJlZmNvdW50IGluZGVmaW5pdGVseQpvbiBldmVy eSBjeWNsZS4KCkkgc2VlIHRoaXMgaXNzdWUgaXMgYWRkcmVzc2VkIGxhdGVyIGluIHRoZSBzZXJp ZXMgYnkgY29tbWl0CmUwMjE5ZmQ1ZjRkNzg0ZTc4ZmY5NjlhZjI2NmUxMDE5NjM2N2JlNjkgKCJw aHk6IHJvY2tjaGlwOiB1c2JkcDogU2ltcGxpZnkKcG93ZXIgc3RhdGUgaGFuZGxpbmciKSwgYnV0 IGRvZXNuJ3QgdGhpcyBwYXRjaCBpbnRyb2R1Y2UgYSByZWdyZXNzaW9uIGhlcmUKdGhhdCBicmVh a3MgYmlzZWN0YWJpbGl0eT8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hp a28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MDMtcm9ja2NoaXAtdXNiZHAtY2xlYW51cC12MTAtMC1h MzkyNzExY2E4YTlAY29sbGFib3JhLmNvbT9wYXJ0PTIzCgotLSAKbGludXgtcGh5IG1haWxpbmcg bGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52199313E24 for ; Fri, 3 Jul 2026 23:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783122585; cv=none; b=GoZM5ky8yYnHbN40niNJp8EbuGtFdAuSql4p6Ok3fIBtgvSHx83l3Rxye//cnVUYqYg3YDswAh8TND3deDbvpbxwTXyv8qz8SxksE5+oL2nqVc24ZCytJrSGFRZVAcpCv8xxGxAiybIOHjv38THi5nH2CSyoHHksUnLD+bd7Sn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783122585; c=relaxed/simple; bh=C603AokNqB7ed/6FkL9oSaakLVFSA5waCRoM1ace6Xo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=DHZWnmBCMsZdL6cCcE3S45aYGM5IPce5etRy8PjuUkt5V5SzqeNuE3qqmSyHY/YF/6n25Yokjln1HwKv0Y9pQjqmeqx75B2N9Xz929JgbCw+rwpvjAh5A78sMf7pwQeAqonWe5s1wY4Na/+W9DaoFRetV8rFePJsa4twHnkRD1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ahnGbnQi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ahnGbnQi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96D701F000E9; Fri, 3 Jul 2026 23:49:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783122584; bh=/x3PSLlONBl/BZ7lR2rqsLDqhhtW/0J64dFPP+tzcPc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ahnGbnQixx0Eck3NjfsJPbWf10bFXFGR2xaFJ2dtVv3qvIFhdaaipMaH8UQ00ViMB ljfcCzUYBNX2k3f8u9Jbj+63oCqA45Aj/XxUxLmoPHi0GYv/fANvQVbY7X5c9MgbjG 9m67RY7Bkt11oho79SbHMDPb4yWN+gKCtLl37i7MuM88LvgB1S//WdIs1IYZAyJPVf VnqFgDcPT6ex5YCOgBLT3MmcHST/XsNqt4Du04J0sMEZnNnRHJWiqCNR0rqsSDWWVi O5Ev+isXUa7H5Jb1/A2LaGhwVFleZx0FqtccIrE8vSeI9eB1uOlJgfCSsmJAe8Wdv/ tYL2+4DlYmP8A== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 23/36] phy: rockchip: usbdp: Clear USB status on PHY exit Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: devicetree@vger.kernel.org, vkoul@kernel.org, robh@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, conor+dt@kernel.org In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-23-a392711ca8a9@collabora.com> References: <20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com> <20260703-rockchip-usbdp-cleanup-v10-23-a392711ca8a9@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 03 Jul 2026 23:49:43 +0000 Message-Id: <20260703234943.96D701F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Clearing `udphy->status` directly without checking if the PHY hard= ware should be disabled causes an unbounded clock reference count leak. -- commit e836c3d9b92996113cb8593f93bf48152ed5de6c Author: Sebastian Reichel phy: rockchip: usbdp: Clear USB status on PHY exit This commit ensures the USB status flag is cleared when the USB3 PHY is exited while the system is in DP-only mode. This happens if the USB3 controller device is unbound while a DP-only adapter is plugged in. Closes: https://sashiko.dev/#/message/20260625-rockchip-usbdp-cleanup-v7-24= -38eb3cf654fd%40collabora.com > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -1273,8 +1273,10 @@ static int rk_udphy_usb3_phy_exit(struct phy *phy) > guard(mutex)(&udphy->mutex); > =20 > /* DP only or high-speed */ > - if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) > + if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) { > + udphy->status &=3D ~UDPHY_MODE_USB; > return 0; > + } > =20 > rk_udphy_power_off(udphy, UDPHY_MODE_USB); [Severity: High] Does clearing udphy->status without actually disabling the hardware cause an unbounded clock reference count leak? When the system switches to DP-only mode, udphy->mode loses the UDPHY_MODE_USB bit. If the USB controller is then unbound, we hit this path and clear UDPHY_MODE_USB from udphy->status, but return early. The hardware clocks remain enabled since we bypass the hardware disable call. If the system then switches back to USB mode, rk_udphy_usb3_phy_init() will see udphy->status as UDPHY_MODE_NONE and call rk_udphy_setup(). This calls clk_bulk_prepare_enable() again, incrementing the clock refcount indefinite= ly on every cycle. I see this issue is addressed later in the series by commit e0219fd5f4d784e78ff969af266e10196367be69 ("phy: rockchip: usbdp: Simplify power state handling"), but doesn't this patch introduce a regression here that breaks bisectability? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260703-rockchip-u= sbdp-cleanup-v10-0-a392711ca8a9@collabora.com?part=3D23