From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7686BC43458 for ; Fri, 3 Jul 2026 23:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m9w3pZTmhhz6xzUlKJ/evMWURc0TXb1LsEFf5fyOKBE=; b=X7JotWz9SNfMxB M6WUtNHiQZKYbzmng/05OKSxQ3J2h152Gk9ERhqvGl9+EvZTZzoYKZlcbMd1CWAeD0pDjhn77wZAH pQP+aayYRzSddxL+Ts2UAak5b8aNnb0SzJVkHCqmBHUKdLl/Zfs2uMxto6nmoTbiEmraN+Xv625iZ d38+ZWQ2ddD3D1LrwNZmA0VcKt6m6yOncpxlfxHw8FetoJmiDvcUrfvwoU+yrQCdBeT8ydn71CTP2 hlIxp3bkTL4YsnKht8IAsmq/sUNqEeS1+JWvX43O4rENuzN04O8CArbd5a+PyEQtvpEo4TfP8uQB8 FW1RRdu96R+SpcQ5wPJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfnfT-000000081ql-112t; Fri, 03 Jul 2026 23:51:35 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfnfR-000000081qf-2URb for linux-phy@lists.infradead.org; Fri, 03 Jul 2026 23:51:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D26B1600AF; Fri, 3 Jul 2026 23:51:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A671F000E9; Fri, 3 Jul 2026 23:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783122692; bh=UPfEXxLHhA+P7h6eArkgTVJ6+sIdc4LAfYITKWYSX/U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UTATIyXZuvn9LqERurVtfT5+2NgAB3GvV+yk8ADSon05vw/9S18+XpvMWNm7ARRBk SJI1josmgr9F8ZHQmsOOf1tjIC3ZJUt14bdTm2Gps8CVfUWqRRXzxw62jL/q8S2pTA PtCRLBd6Doj2EszjJ6fIBiX+pDZ5ERAtIEm0uPeyFzmo8xOqRJRt0j+kSUy8+kcG9p SEwrL3WCb5tTG3a7wOdVpHI2DHollw2kjWLqnuygPJeFxmr4TgIw2cK0GdbixZgBAL skjfrWUxAcR0TZn6fg3Bf3WCNCRA9gZCdDEFW/bZQqw1DQrMf7kfkGYpwRyjW6c1gP KbrvXX1ZQCuZA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 19/36] phy: rockchip: usbdp: Re-init the PHY on orientation change To: "Sebastian Reichel" Cc: linux-phy@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-19-a392711ca8a9@collabora.com> References: <20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com> <20260703-rockchip-usbdp-cleanup-v10-19-a392711ca8a9@collabora.com> Date: Fri, 03 Jul 2026 23:51:31 +0000 Message-Id: <20260703235132.15A671F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFRoZSBwYXRjaCBkZWZl cnMgUEhZIGhhcmR3YXJlIHJlLWluaXRpYWxpemF0aW9uIGR1cmluZyBUeXBlLUMgb3JpZW50YXRp b24gY2hhbmdlcyBieSBzZXR0aW5nIGEgYHBoeV9uZWVkc19yZWluaXRgIGZsYWcsIGFzc3VtaW5n IGEgc3Vic2VxdWVudCBjYWxsIHRvIGBya191ZHBoeV91cGRhdGVfcG93ZXJfc3RhdGUoKWAgd2ls bCBhcHBseSB0aGUgY2hhbmdlLiBIb3dldmVyLCBmb3IgVVNCMy1vbmx5IGNvbm5lY3Rpb25zLCB0 aGlzIHN1YnNlcXVlbnQgY2FsbCBpcyBvZnRlbiBuZXZlciBtYWRlLCByZXN1bHRpbmcgaW4gYnJv a2VuIFVTQjMgZnVuY3Rpb25hbGl0eS4KLS0KCmNvbW1pdCBhZjcxMmVjYzQ4OWRlNWM2NDdhOGUz MDVjN2JlY2E0YjFjNmRkNWNiCkF1dGhvcjogU2ViYXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5y ZWljaGVsQGNvbGxhYm9yYS5jb20+CgpwaHk6IHJvY2tjaGlwOiB1c2JkcDogUmUtaW5pdCB0aGUg UEhZIG9uIG9yaWVudGF0aW9uIGNoYW5nZQoKVGhpcyBwYXRjaCB1cGRhdGVzIHRoZSByb2NrY2hp cCB1c2JkcCBQSFkgZHJpdmVyIHRvIHRyYWNrIG9yaWVudGF0aW9uCmNoYW5nZXMgYnkgY2hlY2tp bmcgaWYgdGhlIGNhYmxlIG9yaWVudGF0aW9uIGlzIHJldmVyc2VkLiBJZiB0aGUgb3JpZW50YXRp b24KY2hhbmdlcywgaXQgZmxhZ3MgdGhlIFBIWSBhcyBuZWVkaW5nIHJlLWluaXRpYWxpemF0aW9u IHNvIHRoYXQgdGhlIGxhbmUgCm11eGluZyBjYW4gYmUgcmVjb25maWd1cmVkLgoKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMgYi9kcml2ZXJz L3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYwo+IGluZGV4IGU0NGQxOWM5ZDExOTMu LjRiNDU0Nzk4YzRlZDQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLXVzYmRwLmMKPiArKysgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAt dXNiZHAuYwo+IEBAIC02MjAsNiArNjIwLDcgQEAgc3RhdGljIGludCBya191ZHBoeV9vcmllbl9z d19zZXQoc3RydWN0IHR5cGVjX3N3aXRjaF9kZXYgKnN3LAo+ICAJCQkJIGVudW0gdHlwZWNfb3Jp ZW50YXRpb24gb3JpZW4pCj4gIHsKPiAgCXN0cnVjdCBya191ZHBoeSAqdWRwaHkgPSB0eXBlY19z d2l0Y2hfZ2V0X2RydmRhdGEoc3cpOwo+ICsJYm9vbCBmbGlwcGVkID0gb3JpZW4gPT0gVFlQRUNf T1JJRU5UQVRJT05fUkVWRVJTRTsKPiAgCj4gIAltdXRleF9sb2NrKCZ1ZHBoeS0+bXV0ZXgpOwo+ ICAKPiBAQCAtNjMxLDcgKzYzMiwxMCBAQCBzdGF0aWMgaW50IHJrX3VkcGh5X29yaWVuX3N3X3Nl dChzdHJ1Y3QgdHlwZWNfc3dpdGNoX2RldiAqc3csCj4gIAkJZ290byB1bmxvY2tfcmV0Owo+ICAJ fQo+ICAKPiAtCXVkcGh5LT5mbGlwID0gb3JpZW4gPT0gVFlQRUNfT1JJRU5UQVRJT05fUkVWRVJT RTsKPiArCWlmICh1ZHBoeS0+ZmxpcCAhPSBmbGlwcGVkKQo+ICsJCXVkcGh5LT5waHlfbmVlZHNf cmVpbml0ID0gdHJ1ZTsKPiArCgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdGhpcyBkZWZlcnJhbCBv ZiBQSFkgaW5pdGlhbGl6YXRpb24gYnJlYWsgVVNCMy1vbmx5IGNvbm5lY3Rpb25zPwoKQnkgb25s eSBzZXR0aW5nIHRoZSBwaHlfbmVlZHNfcmVpbml0IGZsYWcgaGVyZSwgdGhlIGFjdHVhbCBoYXJk d2FyZSB1cGRhdGUKYXBwZWFycyB0byBiZSBkZWZlcnJlZCB1bnRpbCBya191ZHBoeV91cGRhdGVf cG93ZXJfc3RhdGUoKSBpcyBjYWxsZWQgdG8gCmNvbnN1bWUgaXQuCgpGb3IgVVNCMy1vbmx5IGNv bm5lY3Rpb25zIChlc3BlY2lhbGx5IG9uIGZpeGVkLXJvbGUgcG9ydHMgb3IgYm9hcmRzIHdpdGhv dXQgYQptb2RlLXN3aXRjaCBwcm9wZXJ0eSksIGlzIHJrX3VkcGh5X3VwZGF0ZV9wb3dlcl9zdGF0 ZSgpIGd1YXJhbnRlZWQgdG8gYmUKY2FsbGVkIGFmdGVyIHRoaXMgb3JpZW50YXRpb24gY2hhbmdl PyAKCklmIGl0IGlzbid0IGNhbGxlZCwgaXQgc2VlbXMgYSByZXZlcnNlLXBsdWdnZWQgVVNCMyBk ZXZpY2UgbWlnaHQgZmFpbCB0bwpjb25uZWN0IGJlY2F1c2UgdGhlIHJldmVyc2UgbGFuZSByb3V0 aW5nIGlzIG5ldmVyIHdyaXR0ZW4gdG8gdGhlIGhhcmR3YXJlLiAKQWRkaXRpb25hbGx5LCBpZiBh IERpc3BsYXlQb3J0IGRldmljZSAod2hpY2ggZG9lcyB0cmlnZ2VyIGEgcG93ZXIgc3RhdGUgCnVw ZGF0ZSkgaXMgcGx1Z2dlZCBpbiByZXZlcnNlIGFuZCB0aGVuIHJlcGxhY2VkIHdpdGggYSBub3Jt YWwgVVNCMyBkZXZpY2UsIApjb3VsZCB0aGUgc29mdHdhcmUgc3RhdGUgcmVzZXQgdG8gbm9ybWFs IHdoaWxlIHRoZSBoYXJkd2FyZSByZW1haW5zIHN0dWNrIAppbiByZXZlcnNlPwoKPiArCXVkcGh5 LT5mbGlwID0gZmxpcHBlZDsKPiAgCXJrX3VkcGh5X3NldF90eXBlY19kZWZhdWx0X21hcHBpbmco dWRwaHkpOwo+ICAJcmtfdWRwaHlfdXNiX2J2YWxpZF9lbmFibGUodWRwaHksIHRydWUpOwo+Cgot LSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYwNzAzLXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjEwLTAtYTM5MjcxMWNhOGE5QGNvbGxhYm9y YS5jb20/cGFydD0xOQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5B74347BD9 for ; Fri, 3 Jul 2026 23:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783122694; cv=none; b=mnZSMFS2j9FUA9PZC6+Dupp+FQzm4L17zYLhj8QlMrKNSH7ELVH+rRmiOgn5L5faKxYwj2DpGJom/sJ9/1Jgp3p91HHs2q7fOlC7W6agLUSXOypiME2pZpoGZ+Ugm2UedxUCFPqa16P4r/NDgA5Htmn1mjQ1sY3hMiGLFqXO73I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783122694; c=relaxed/simple; bh=lEJ+rW2uS8TqYig//Hbf/9A+xPzsiO0/w0QsRz++RFY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=nFIMq8wjeQrrDWTHdy+REwPpl1Xu0FxOsw2ekl8sRN9h8GGwM10iZiffQqNFDDpanyU8h6zD9enXxLncGhgLIFedrfIc3s7CEHC1j1PSr/4mxM9SgQmYkm8i6xTa30Eg9NG+cM23fI1naHU0kvk3P+TWE76K5ufnto1FycQ4spY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UTATIyXZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UTATIyXZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15A671F000E9; Fri, 3 Jul 2026 23:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783122692; bh=UPfEXxLHhA+P7h6eArkgTVJ6+sIdc4LAfYITKWYSX/U=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UTATIyXZuvn9LqERurVtfT5+2NgAB3GvV+yk8ADSon05vw/9S18+XpvMWNm7ARRBk SJI1josmgr9F8ZHQmsOOf1tjIC3ZJUt14bdTm2Gps8CVfUWqRRXzxw62jL/q8S2pTA PtCRLBd6Doj2EszjJ6fIBiX+pDZ5ERAtIEm0uPeyFzmo8xOqRJRt0j+kSUy8+kcG9p SEwrL3WCb5tTG3a7wOdVpHI2DHollw2kjWLqnuygPJeFxmr4TgIw2cK0GdbixZgBAL skjfrWUxAcR0TZn6fg3Bf3WCNCRA9gZCdDEFW/bZQqw1DQrMf7kfkGYpwRyjW6c1gP KbrvXX1ZQCuZA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 19/36] phy: rockchip: usbdp: Re-init the PHY on orientation change Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: linux-phy@lists.infradead.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org In-Reply-To: <20260703-rockchip-usbdp-cleanup-v10-19-a392711ca8a9@collabora.com> References: <20260703-rockchip-usbdp-cleanup-v10-0-a392711ca8a9@collabora.com> <20260703-rockchip-usbdp-cleanup-v10-19-a392711ca8a9@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 03 Jul 2026 23:51:31 +0000 Message-Id: <20260703235132.15A671F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] The patch defers PHY hardware re-initialization during Type-C orie= ntation changes by setting a `phy_needs_reinit` flag, assuming a subsequent= call to `rk_udphy_update_power_state()` will apply the change. However, fo= r USB3-only connections, this subsequent call is often never made, resultin= g in broken USB3 functionality. -- commit af712ecc489de5c647a8e305c7beca4b1c6dd5cb Author: Sebastian Reichel phy: rockchip: usbdp: Re-init the PHY on orientation change This patch updates the rockchip usbdp PHY driver to track orientation changes by checking if the cable orientation is reversed. If the orientation changes, it flags the PHY as needing re-initialization so that the lane=20 muxing can be reconfigured. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index e44d19c9d1193..4b454798c4ed4 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -620,6 +620,7 @@ static int rk_udphy_orien_sw_set(struct typec_switch_= dev *sw, > enum typec_orientation orien) > { > struct rk_udphy *udphy =3D typec_switch_get_drvdata(sw); > + bool flipped =3D orien =3D=3D TYPEC_ORIENTATION_REVERSE; > =20 > mutex_lock(&udphy->mutex); > =20 > @@ -631,7 +632,10 @@ static int rk_udphy_orien_sw_set(struct typec_switch= _dev *sw, > goto unlock_ret; > } > =20 > - udphy->flip =3D orien =3D=3D TYPEC_ORIENTATION_REVERSE; > + if (udphy->flip !=3D flipped) > + udphy->phy_needs_reinit =3D true; > + [Severity: High] Does this deferral of PHY initialization break USB3-only connections? By only setting the phy_needs_reinit flag here, the actual hardware update appears to be deferred until rk_udphy_update_power_state() is called to=20 consume it. For USB3-only connections (especially on fixed-role ports or boards without= a mode-switch property), is rk_udphy_update_power_state() guaranteed to be called after this orientation change?=20 If it isn't called, it seems a reverse-plugged USB3 device might fail to connect because the reverse lane routing is never written to the hardware.= =20 Additionally, if a DisplayPort device (which does trigger a power state=20 update) is plugged in reverse and then replaced with a normal USB3 device,= =20 could the software state reset to normal while the hardware remains stuck=20 in reverse? > + udphy->flip =3D flipped; > rk_udphy_set_typec_default_mapping(udphy); > rk_udphy_usb_bvalid_enable(udphy, true); > --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260703-rockchip-u= sbdp-cleanup-v10-0-a392711ca8a9@collabora.com?part=3D19