From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35839C43458 for ; Sat, 4 Jul 2026 07:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KiaocM1HJsFjU5HwtjepXue2FGWOG0jeWmDLyWV/Omg=; b=BDG72ablFQ6FM4 XhJNRocp4+anceF83bay/0PuWed5Z/k1f5g+3cU/KM0NtklUj4XbsjFcC+qC9aL8vYhVzuml5mL0f k/dbkn2RIg4l1urBgiA+82a9grerbTnY6A7yseGVdvREnGTdoOWgEjuVH5cZ6Mz2G8IAL3hfbdYkh hl02Qj4U+0CRFH2Xxo4OzeFlWiqn3ns/Pi2oArXHjT4wD++HSh/yKcdb0QGyKfY/Jhge66DDoRmL2 T+EqlqzjJgW/zSb2J1SpZg5/Jz7ArWLL1OQ3CW5hpVPgsTIrnk9jM6R5ZCV2irhqd2ntTSPIY22tv Gpn9tFLx7nGsacsxGBnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfv5z-00000008GtU-42fB; Sat, 04 Jul 2026 07:47:27 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfv5z-00000008GtK-1QPY for linux-phy@lists.infradead.org; Sat, 04 Jul 2026 07:47:27 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D2DD340821; Sat, 4 Jul 2026 07:47:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D29E81F000E9; Sat, 4 Jul 2026 07:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783151245; bh=2ZlEqYHlxV635tgf86j0RXWU9JLveQzZciEPDdxrRgU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=derLkDQcX3up4lcF0amOaw2dRwnFFwSM+51AOCTEiTlnVr3uh9FLi+wNkjZQp1Zi+ L/nkfEGp6F8HlUxlZ3GvQS1tyjg9WHyvnK47eqOwSqn8FgqCEKzSMhoaOxx+uBE24H O/K+oO0CSAtM1TStLhEeelEye2VcbX3pSTEHoDDd6AAXJtgC8SJTEtI6kFKh+yZveF kJ7ZK0i1szl7s+5XyjzWZjjJqUYe2Y38XkbrCnvIz4/FZEOwUuFc0NBn5hynNzRjDD lJE1NZtBKi3vtLCfM/TteGtkWJxvE2rRW6WzBObGNLuBrAVbZJE9ZOpZQs8hkbVbz8 ym0/toJAzjoQg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/5] dt-bindings: phy: motorola,cpcap-usb: replace se1 interrupt with chrg_det To: "Ivaylo Dimitrov" Cc: vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260704073843.1750458-4-ivo.g.dimitrov.75@gmail.com> References: <20260704073843.1750458-1-ivo.g.dimitrov.75@gmail.com> <20260704073843.1750458-4-ivo.g.dimitrov.75@gmail.com> Date: Sat, 04 Jul 2026 07:47:24 +0000 Message-Id: <20260704074724.D29E81F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtDcml0aWNh bF0gRGV2aWNlIFRyZWUgQUJJIGJyZWFrYWdlOiByZXBsYWNpbmcgJ3NlMScgaW50ZXJydXB0IHdp dGggJ2NocmdfZGV0JyBicmVha3MgcHJvYmUgb24gb2xkZXIgRFRCcy4KLSBbTWVkaXVtXSBHbG9i YWwgU3lzUnEgc3RhdGUgaXMgcGVybWFuZW50bHkgZGlzYWJsZWQgb24gZXJyb3IgcGF0aHMuCgpQ cmUtZXhpc3RpbmcgaXNzdWVzOgotIFtIaWdoXSBSYWNlIGNvbmRpdGlvbiBpbiBkcml2ZXIgcmVt b3ZhbCBhbGxvd3MgdGhlIHRocmVhZGVkIElSUSBoYW5kbGVyIHRvIHNjaGVkdWxlIHdvcmsgb24g ZnJlZWQgbWVtb3J5IChVc2UtQWZ0ZXItRnJlZSkuCi0tCgpjb21taXQgZDdiMmE1MWMzZjgyZWJk YjJmMzI2MzEzZjEzZGRmMmQzZWRkZTFhNwpBdXRob3I6IEl2YXlsbyBEaW1pdHJvdiA8aXZvLmcu ZGltaXRyb3YuNzVAZ21haWwuY29tPgoKZHQtYmluZGluZ3M6IHBoeTogbW90b3JvbGEsY3BjYXAt dXNiOiByZXBsYWNlIHNlMSBpbnRlcnJ1cHQgd2l0aCBjaHJnX2RldAoKVGhlIENQQ0FQIFVTQiBQ SFkgZHJpdmVyIHVzZXMgdGhlIENQQ0FQIGNoYXJnZXIgZGV0ZWN0aW9uIGludGVycnVwdCBmb3Ig RENQCmRldGVjdGlvbiByYXRoZXIgdGhhbiB0aGUgU0UxIGludGVycnVwdC4gVGhpcyBjb21taXQg dXBkYXRlcyB0aGUgYmluZGluZyBhbmQKZXhhbXBsZSBEVFMgdG8gdXNlIHRoZSBjb3JyZXNwb25k aW5nICJjaHJnX2RldCIgaW50ZXJydXB0IG5hbWUuCgo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L21vdG9yb2xhLGNwY2FwLXVzYi1waHkueWFtbCBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvbW90b3JvbGEsY3BjYXAtdXNi LXBoeS55YW1sCj4gaW5kZXggZGQzNDVjYmQwYTBiNC4uZDU0Y2Y3ZmJmMTFhNyAxMDA2NDQKPiAt LS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L21vdG9yb2xhLGNwY2Fw LXVzYi1waHkueWFtbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w aHkvbW90b3JvbGEsY3BjYXAtdXNiLXBoeS55YW1sCj4gQEAgLTI3LDcgKzI3LDcgQEAgcHJvcGVy dGllczoKPiAgICAgICAgLSBkZXNjcmlwdGlvbjogdmJ1c3ZsZCBpbnRlcnJ1cHQKPiAgICAgICAg LSBkZXNjcmlwdGlvbjogc2Vzc3ZsZCBpbnRlcnJ1cHQKPiAgICAgICAgLSBkZXNjcmlwdGlvbjog c2Vzc2VuZCBpbnRlcnJ1cHQKPiAtICAgICAgLSBkZXNjcmlwdGlvbjogc2UxIGludGVycnVwdAo+ ICsgICAgICAtIGRlc2NyaXB0aW9uOiBjaGFyZ2VyIGRldGVjdGlvbiBpbnRlcnJ1cHQKPiAgICAg ICAgLSBkZXNjcmlwdGlvbjogZG0gaW50ZXJydXB0Cj4gICAgICAgIC0gZGVzY3JpcHRpb246IGRw IGludGVycnVwdAo+ICAKPiBAQCAtNDAsNyArNDAsNyBAQCBwcm9wZXJ0aWVzOgo+ICAgICAgICAt IGNvbnN0OiB2YnVzdmxkCj4gICAgICAgIC0gY29uc3Q6IHNlc3N2bGQKPiAgICAgICAgLSBjb25z dDogc2Vzc2VuZAo+IC0gICAgICAtIGNvbnN0OiBzZTEKPiArICAgICAgLSBjb25zdDogY2hyZ19k ZXQKCltTZXZlcml0eTogQ3JpdGljYWxdCkRvZXMgcmVwbGFjaW5nICdzZTEnIHdpdGggJ2Nocmdf ZGV0JyBicmVhayBwcm9iZSBmb3Igb2xkZXIgZGV2aWNlIHRyZWVzPwoKU2luY2UgY3BjYXBfdXNi X2luaXRfaXJxKCkgaW4gZHJpdmVycy9waHkvbW90b3JvbGEvcGh5LWNwY2FwLXVzYi5jIGZhaWxz IHRoZQpwcm9iZSBpZiBhbiBleHBlY3RlZCBpbnRlcnJ1cHQgaXMgbm90IGZvdW5kLCB1cGRhdGlu ZyB0aGUgYmluZGluZyB0byByZXF1aXJlCidjaHJnX2RldCcgaW5zdGVhZCBvZiAnc2UxJyBtZWFu cyBib290aW5nIGEgbmV3IGtlcm5lbCB3aXRoIGFuIG9sZGVyIERUQgood2hpY2ggb25seSBwcm92 aWRlcyAnc2UxJykgY291bGQgZmFpbCB0byBwcm9iZSB0aGUgVVNCIFBIWS4KCj4gICAgICAgIC0g Y29uc3Q6IGRtCj4gICAgICAgIC0gY29uc3Q6IGRwCj4gIAoKWyAuLi4gXQoKV2hpbGUgcmV2aWV3 aW5nIHRoaXMsIEkgbm90aWNlZCBhIGZldyBvdGhlciByZWdyZXNzaW9ucyBpbgpkcml2ZXJzL3Bo eS9tb3Rvcm9sYS9waHktY3BjYXAtdXNiLmM6CgpbU2V2ZXJpdHk6IE1lZGl1bV0KQ2FuIHRoaXMg ZXJyb3IgcGF0aCBpbiBjcGNhcF91c2Jfc2V0X2lkbGVfbW9kZSgpIGxlYXZlIHRoZSBnbG9iYWwg U3lzUnEgc3RhdGUKcGVybWFuZW50bHkgZGlzYWJsZWQ/Cgpkcml2ZXJzL3BoeS9tb3Rvcm9sYS9w aHktY3BjYXAtdXNiLmM6Y3BjYXBfdXNiX3NldF9pZGxlX21vZGUoKSB7CiAgICAuLi4KICAgIHN5 c3JxID0gc3lzcnFfbWFzaygpOwogICAgaWYgKHN5c3JxICYgMSkKICAgICAgICBzeXNycV90b2dn bGVfc3VwcG9ydChzeXNycSAmIH4xKTsKICAgIC4uLgpvdXRfZXJyOgogICAgZGV2X2VycihkZGF0 YS0+ZGV2LCAiJXMgZmFpbGVkIHdpdGggJWlcbiIsIF9fZnVuY19fLCBlcnJvcik7CgogICAgcmV0 dXJuIGVycm9yOwp9CgpJZiBhbiBlcnJvciBvY2N1cnMgKGUuZy4sIGR1cmluZyBwaW5jdHJsX3Nl bGVjdF9zdGF0ZSksIHRoZSBmdW5jdGlvbiBqdW1wcyB0bwpvdXRfZXJyIGFuZCByZXR1cm5zIHdp dGhvdXQgY2FsbGluZyBzeXNycV90b2dnbGVfc3VwcG9ydChzeXNycSkgdG8gcmVzdG9yZSBpdC4K CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBjb3Vs ZCB0aGVyZSBiZSBhIHJhY2UgY29uZGl0aW9uIGR1cmluZwpkcml2ZXIgcmVtb3ZhbCB0aGF0IGFs bG93cyB0aGUgdGhyZWFkZWQgSVJRIGhhbmRsZXIgdG8gc2NoZWR1bGUgd29yayBvbiBmcmVlZApt ZW1vcnk/CgpEdXJpbmcgZHJpdmVyIHJlbW92YWwsIGNwY2FwX3VzYl9waHlfcmVtb3ZlKCkgY2Fu Y2VscyB0aGUgd29yayB3aXRob3V0CmRpc2FibGluZyB0aGUgSVJRIGZpcnN0OgoKZHJpdmVycy9w aHkvbW90b3JvbGEvcGh5LWNwY2FwLXVzYi5jOmNwY2FwX3VzYl9waHlfcmVtb3ZlKCkgewogICAg Li4uCiAgICBhdG9taWNfc2V0KCZkZGF0YS0+YWN0aXZlLCAwKTsKICAgIC4uLgogICAgY2FuY2Vs X2RlbGF5ZWRfd29ya19zeW5jKCZkZGF0YS0+ZGV0ZWN0X3dvcmspOwogICAgcmVndWxhdG9yX2Rp c2FibGUoZGRhdGEtPnZ1c2IpOwp9CgpDb25jdXJyZW50bHksIGlmIGFuIElSUSBmaXJlcyBhbmQg Y3BjYXBfcGh5X2lycV90aHJlYWQoKSBjaGVja3MgJ2FjdGl2ZScgYnV0CmlzIHByZWVtcHRlZCBi ZWZvcmUgc2NoZWR1bGluZyB0aGUgd29yazoKCmRyaXZlcnMvcGh5L21vdG9yb2xhL3BoeS1jcGNh cC11c2IuYzpjcGNhcF9waHlfaXJxX3RocmVhZCgpIHsKICAgIC4uLgogICAgaWYgKCFhdG9taWNf cmVhZCgmZGRhdGEtPmFjdGl2ZSkpCiAgICAgICAgcmV0dXJuIElSUV9OT05FOwoKICAgIHNjaGVk dWxlX2RlbGF5ZWRfd29yaygmZGRhdGEtPmRldGVjdF93b3JrLCBtc2Vjc190b19qaWZmaWVzKDEp KTsKICAgIC4uLgp9CgpDb3VsZCB0aGUgSVJRIHRocmVhZCByZXN1bWUgYWZ0ZXIgY2FuY2VsX2Rl bGF5ZWRfd29ya19zeW5jKCkgaGFzIGNvbXBsZXRlZCwKc2NoZWR1bGluZyB0aGUgZGVsYXllZCB3 b3JrIG9uIGEgZnJlZWQgJ2RkYXRhJyBvYmplY3Q/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcg aHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzA0MDczODQzLjE3NTA0NTgtMS1p dm8uZy5kaW1pdHJvdi43NUBnbWFpbC5jb20/cGFydD0zCgotLSAKbGludXgtcGh5IG1haWxpbmcg bGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F15CE2DEA64 for ; Sat, 4 Jul 2026 07:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783151251; cv=none; b=k7ettVMwODhVxm7wcpEePmHKUNLz7NJAc+8QrihmHHu69pDY177Hk7B6/orBV1V9aP5sb/ZNqdZgalfn6HYpk+izYhoWD2i1tguJXSNExh0wZXGLkcxBHbF7C5AXkShC2WTBmAvCn5KtCYR5H4BvUDhvA65hhLgmc+0l7M7mmCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783151251; c=relaxed/simple; bh=0OATkkDWp9veuMDYpSUmeH+tWw1ome6OjiD0dqc70dk=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Yw7XTtx+A9FrQmRGf9AxGERiCthLBkmy8tKlWfHnh+POY4e/eWhT/LfBHdBAHhpphn+aCBjoqQ2K/nkmCdjxxcz2+gbTSrp18BgdO3AX9gciz1kDb3SviYJHMmMTmti1m8kDRwJ4rX7ooAVJIzWC/dvP9T74NHKVSbT7a49Gffs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=derLkDQc; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="derLkDQc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D29E81F000E9; Sat, 4 Jul 2026 07:47:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783151245; bh=2ZlEqYHlxV635tgf86j0RXWU9JLveQzZciEPDdxrRgU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=derLkDQcX3up4lcF0amOaw2dRwnFFwSM+51AOCTEiTlnVr3uh9FLi+wNkjZQp1Zi+ L/nkfEGp6F8HlUxlZ3GvQS1tyjg9WHyvnK47eqOwSqn8FgqCEKzSMhoaOxx+uBE24H O/K+oO0CSAtM1TStLhEeelEye2VcbX3pSTEHoDDd6AAXJtgC8SJTEtI6kFKh+yZveF kJ7ZK0i1szl7s+5XyjzWZjjJqUYe2Y38XkbrCnvIz4/FZEOwUuFc0NBn5hynNzRjDD lJE1NZtBKi3vtLCfM/TteGtkWJxvE2rRW6WzBObGNLuBrAVbZJE9ZOpZQs8hkbVbz8 ym0/toJAzjoQg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/5] dt-bindings: phy: motorola,cpcap-usb: replace se1 interrupt with chrg_det Reply-To: sashiko-reviews@lists.linux.dev To: "Ivaylo Dimitrov" Cc: vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260704073843.1750458-4-ivo.g.dimitrov.75@gmail.com> References: <20260704073843.1750458-1-ivo.g.dimitrov.75@gmail.com> <20260704073843.1750458-4-ivo.g.dimitrov.75@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 04 Jul 2026 07:47:24 +0000 Message-Id: <20260704074724.D29E81F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: New issues: - [Critical] Device Tree ABI breakage: replacing 'se1' interrupt with 'chrg= _det' breaks probe on older DTBs. - [Medium] Global SysRq state is permanently disabled on error paths. Pre-existing issues: - [High] Race condition in driver removal allows the threaded IRQ handler t= o schedule work on freed memory (Use-After-Free). -- commit d7b2a51c3f82ebdb2f326313f13ddf2d3edde1a7 Author: Ivaylo Dimitrov dt-bindings: phy: motorola,cpcap-usb: replace se1 interrupt with chrg_det The CPCAP USB PHY driver uses the CPCAP charger detection interrupt for DCP detection rather than the SE1 interrupt. This commit updates the binding and example DTS to use the corresponding "chrg_det" interrupt name. > diff --git a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy= .yaml b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > index dd345cbd0a0b4..d54cf7fbf11a7 100644 > --- a/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/motorola,cpcap-usb-phy.yaml > @@ -27,7 +27,7 @@ properties: > - description: vbusvld interrupt > - description: sessvld interrupt > - description: sessend interrupt > - - description: se1 interrupt > + - description: charger detection interrupt > - description: dm interrupt > - description: dp interrupt > =20 > @@ -40,7 +40,7 @@ properties: > - const: vbusvld > - const: sessvld > - const: sessend > - - const: se1 > + - const: chrg_det [Severity: Critical] Does replacing 'se1' with 'chrg_det' break probe for older device trees? Since cpcap_usb_init_irq() in drivers/phy/motorola/phy-cpcap-usb.c fails the probe if an expected interrupt is not found, updating the binding to require 'chrg_det' instead of 'se1' means booting a new kernel with an older DTB (which only provides 'se1') could fail to probe the USB PHY. > - const: dm > - const: dp > =20 [ ... ] While reviewing this, I noticed a few other regressions in drivers/phy/motorola/phy-cpcap-usb.c: [Severity: Medium] Can this error path in cpcap_usb_set_idle_mode() leave the global SysRq sta= te permanently disabled? drivers/phy/motorola/phy-cpcap-usb.c:cpcap_usb_set_idle_mode() { ... sysrq =3D sysrq_mask(); if (sysrq & 1) sysrq_toggle_support(sysrq & ~1); ... out_err: dev_err(ddata->dev, "%s failed with %i\n", __func__, error); return error; } If an error occurs (e.g., during pinctrl_select_state), the function jumps = to out_err and returns without calling sysrq_toggle_support(sysrq) to restore = it. [Severity: High] This is a pre-existing issue, but could there be a race condition during driver removal that allows the threaded IRQ handler to schedule work on fre= ed memory? During driver removal, cpcap_usb_phy_remove() cancels the work without disabling the IRQ first: drivers/phy/motorola/phy-cpcap-usb.c:cpcap_usb_phy_remove() { ... atomic_set(&ddata->active, 0); ... cancel_delayed_work_sync(&ddata->detect_work); regulator_disable(ddata->vusb); } Concurrently, if an IRQ fires and cpcap_phy_irq_thread() checks 'active' but is preempted before scheduling the work: drivers/phy/motorola/phy-cpcap-usb.c:cpcap_phy_irq_thread() { ... if (!atomic_read(&ddata->active)) return IRQ_NONE; schedule_delayed_work(&ddata->detect_work, msecs_to_jiffies(1)); ... } Could the IRQ thread resume after cancel_delayed_work_sync() has completed, scheduling the delayed work on a freed 'ddata' object? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260704073843.1750= 458-1-ivo.g.dimitrov.75@gmail.com?part=3D3