From: John Olender <john.olender@gmail.com>
To: amd-gfx@lists.freedesktop.org
Cc: kenneth.feng@amd.com, alexander.deucher@amd.com,
asad.kamal@amd.com, lijo.lazar@amd.com, hawking.zhang@amd.com,
kevinyang.wang@amd.com, John Olender <john.olender@gmail.com>
Subject: [PATCH] drm/amd/pm: Remove vbios bounds check from pp_entries_max()
Date: Sat, 4 Jul 2026 06:11:20 -0400 [thread overview]
Message-ID: <20260704101120.674980-1-john.olender@gmail.com> (raw)
The soft_pp_table is not contained within the vbios when using a
pp_table override since commit 3cfe433630508 ("drm/amd/pm: Use uploaded
size for legacy custom PPTable").
Fixes: e30b3e3ab51ad ("drm/amdgpu/pm: add pp_entries_max() helper")
Signed-off-by: John Olender <john.olender@gmail.com>
---
drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
index 7ebc1344023ff..19023a850e882 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
+++ b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
@@ -833,14 +833,10 @@ static inline uint32_t pp_entries_max(const struct pp_hwmgr *hwmgr,
const void *sub_table,
size_t hdr_size, size_t rec_size)
{
- struct amdgpu_device *adev = (struct amdgpu_device *)hwmgr->adev;
- const char *bios_end = (const char *)adev->bios + adev->bios_size;
const char *pp_end = (const char *)hwmgr->soft_pp_table
+ hwmgr->soft_pp_table_size;
const char *entries = (const char *)sub_table + hdr_size;
- if (pp_end > bios_end)
- return 0;
if (!rec_size || entries >= pp_end)
return 0;
return (uint32_t)((pp_end - entries) / rec_size);
base-commit: e3cc8c108f9a91728f9ff6e24cbf3b41c58b8f8b
--
2.47.3
next reply other threads:[~2026-07-04 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 10:11 John Olender [this message]
2026-07-08 16:37 ` [PATCH] drm/amd/pm: Remove vbios bounds check from pp_entries_max() Alex Deucher
2026-07-09 9:57 ` Kamal, Asad
2026-07-09 10:38 ` John Olender
2026-07-09 12:19 ` Kamal, Asad
2026-07-09 13:38 ` John Olender
2026-07-10 15:41 ` Kamal, Asad
2026-07-11 11:07 ` John Olender
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260704101120.674980-1-john.olender@gmail.com \
--to=john.olender@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asad.kamal@amd.com \
--cc=hawking.zhang@amd.com \
--cc=kenneth.feng@amd.com \
--cc=kevinyang.wang@amd.com \
--cc=lijo.lazar@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.