All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: openembedded-devel@lists.openembedded.org
Subject: [PATCH 1/2] gd: restore png, zlib, and tiff in the default PACKAGECONFIG
Date: Sat,  4 Jul 2026 09:13:53 -0400	[thread overview]
Message-ID: <20260704131354.463612-1-twoerner@gmail.com> (raw)

Before the PACKAGECONFIG conversion, png, zlib, and tiff support was
always enabled: those libraries were in DEPENDS and autoconf picked
them up automatically because no --without-* flag was passed for them.
The conversion introduced a regression by not including them in the
default PACKAGECONFIG, causing the mechanism to emit --without-png,
--without-zlib, and --without-tiff, silently disabling those features.

Evidence from the configure logs:

  pre-conversion:
    --with-jpeg=<sysroot>/usr/lib/.. --with-freetype=yes
    --without-fontconfig --without-webp --without-xpm --without-x
    (no --with/--without for png, zlib, or tiff; autoconf detects them)

  post-conversion, unfixed:
    --with-freetype --with-jpeg
    --without-png --without-tiff --without-zlib   <-- regression

  post-conversion, fixed:
    --with-freetype --with-jpeg
    --with-png --with-tiff --with-zlib             <-- restored

Add png, zlib, and tiff to the default PACKAGECONFIG so the out-of-
the-box feature set is unchanged from before the conversion.

Fixes: be9f029b6c10 ("gd: Support PACKAGECONFIG")
AI-Generated: codex/claude-sonnet 4.6 (high)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta-oe/recipes-support/gd/gd_2.3.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-oe/recipes-support/gd/gd_2.3.3.bb b/meta-oe/recipes-support/gd/gd_2.3.3.bb
index e7f8b56fd713..d3d13ee1e737 100644
--- a/meta-oe/recipes-support/gd/gd_2.3.3.bb
+++ b/meta-oe/recipes-support/gd/gd_2.3.3.bb
@@ -23,7 +23,7 @@ SRCREV = "b5319a41286107b53daa0e08e402aa1819764bdc"
 
 inherit autotools binconfig gettext pkgconfig
 
-PACKAGECONFIG ?= "jpeg freetype"
+PACKAGECONFIG ?= "jpeg png zlib tiff freetype"
 
 PACKAGECONFIG[avif] = "--with-avif,--without-avif"
 PACKAGECONFIG[fontconfig] = "--with-fontconfig,--without-fontconfig"
-- 
2.50.0.173.g8b6f19ccfc3a



             reply	other threads:[~2026-07-04 13:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-04 13:13 Trevor Woerner [this message]
2026-07-04 13:13 ` [PATCH 2/2] gd: add missing library deps to PACKAGECONFIG entries Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260704131354.463612-1-twoerner@gmail.com \
    --to=twoerner@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.