All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Bryan O'Donoghue" <bryan.odonoghue@linaro.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [bod:qcom-laptops-v6.18-rc4-camss-icp-bps-ipe-icp-boots+stats-b4 96/121] drivers/media/platform/qcom/camss/camss-csiphy.c:798:29: warning: unused variable 'np'
Date: Sun, 05 Jul 2026 08:34:27 +0800	[thread overview]
Message-ID: <202607050850.EEDhuMeG-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/bod/linux.git qcom-laptops-v6.18-rc4-camss-icp-bps-ipe-icp-boots+stats-b4
head:   ebd1e440443121d18f730ab2aeea5586a754f36f
commit: 2fcf15956bf417c391c1946d3fd091d926185ece [96/121] media: qcom: camss: Add support for PHY API devices
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20260705/202607050850.EEDhuMeG-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260705/202607050850.EEDhuMeG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607050850.EEDhuMeG-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/media/platform/qcom/camss/camss-csiphy.c: In function 'msm_csiphy_subdev_init':
>> drivers/media/platform/qcom/camss/camss-csiphy.c:798:29: warning: unused variable 'np' [-Wunused-variable]
     798 |         struct device_node *np;
         |                             ^~


vim +/np +798 drivers/media/platform/qcom/camss/camss-csiphy.c

   784	
   785	/*
   786	 * msm_csiphy_subdev_init - Initialize CSIPHY device structure and resources
   787	 * @csiphy: CSIPHY device
   788	 * @res: CSIPHY module resources table
   789	 * @id: CSIPHY module id
   790	 *
   791	 * Return 0 on success or a negative error code otherwise
   792	 */
   793	int msm_csiphy_subdev_init(struct camss *camss,
   794				   struct csiphy_device *csiphy,
   795				   const struct camss_subdev_resources *res, u8 id)
   796	{
   797		struct device *dev = camss->dev;
 > 798		struct device_node *np;
   799		struct of_phandle_args args;
   800		u8 combo_mode;
   801		int idx;
   802		int ret;
   803	
   804		snprintf(csiphy->name, ARRAY_SIZE(csiphy->name), "csiphy%d", id);
   805	
   806		idx = of_property_match_string(dev->of_node, "phy-names", csiphy->name);
   807		if (idx < 0) {
   808			dev_err(dev, "%s not found\n", csiphy->name);
   809			return idx;
   810		}
   811	
   812		ret = of_parse_phandle_with_args(dev->of_node, "phys", "#phy-cells", idx, &args);
   813		if (ret < 0) {
   814			dev_err(dev, "unable to parase phys args %s\n", csiphy->name);
   815			return ret;
   816		}
   817	
   818		if (!of_device_is_available(args.np))
   819			goto put_np;
   820	
   821		combo_mode = args.args[0];
   822		if (combo_mode != PHY_TYPE_DPHY) {
   823			dev_err(dev, "%s mode %d not supported\n", csiphy->name, combo_mode);
   824			ret = -ENOTSUPP;
   825			goto put_np;
   826		}
   827	
   828		csiphy->phy = devm_phy_get(dev, csiphy->name);
   829		if (IS_ERR(csiphy->phy)) {
   830			ret = PTR_ERR(csiphy->phy);
   831			goto put_np;
   832		}
   833	
   834		csiphy->camss = camss;
   835		csiphy->id = id;
   836		csiphy->cfg.combo_mode = combo_mode;
   837		csiphy->res = &res->csiphy;
   838	
   839		ret = phy_init(csiphy->phy);
   840		if (ret)
   841			dev_err(dev, "phy %s init fail %d\n", csiphy->name, ret);
   842	
   843	put_np:
   844		of_node_put(args.np);
   845	
   846		return ret;
   847	}
   848	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-07-05  0:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202607050850.EEDhuMeG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.