Re: [PATCH v2 for-next 22/24] RDMA/hfi2: Make it build and add TODO list

[Leon Romanovsky <leon@kernel.org>]

On Sat, Jun 27, 2026 at 12:26:45PM -0400, Dennis Dalessandro wrote:
> Fix various compilation errors found when building the full driver for
> the first time: correct kzalloc_obj() dereference calls throughout,
> fix miscellaneous type and reference errors across multiple files, and
> update Kconfig entries for both hfi1 (Gen1/WFR) and hfi2 (Gen2/JKR)
> to clarify hardware scope. Also add a TODO list file.
> 
> Assisted-by: Claude:claude-sonnet-4-5
> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> 
> ---
> Changes since v3:
> - Add TODO file
> Changes since v2:
> - Restrict hfi2 PCI device table to JKR (CN5000) only; WFR (Intel 0x24f0/0x24f1)
>   is handled exclusively by hfi1. This separation is temporary: hfi2 will
>   eventually support both WFR and JKR at which point hfi1 will be removed.
> - Update Kconfig title and help text to reflect JKR-only scope.
> ---
>  drivers/infiniband/hw/hfi1/Kconfig        |    5 -
>  drivers/infiniband/hw/hfi2/Kconfig        |   32 ++++
>  drivers/infiniband/hw/hfi2/TODO           |    6 +
>  drivers/infiniband/hw/hfi2/chip.c         |    2 
>  drivers/infiniband/hw/hfi2/chip_gen.c     |    2 
>  drivers/infiniband/hw/hfi2/cport.c        |    4 
>  drivers/infiniband/hw/hfi2/fault.c        |    2 
>  drivers/infiniband/hw/hfi2/file_ops.c     |  123 ++------------
>  drivers/infiniband/hw/hfi2/file_ops.h     |    5 -
>  drivers/infiniband/hw/hfi2/hfi2.h         |    2 
>  drivers/infiniband/hw/hfi2/init.c         |    6 -
>  drivers/infiniband/hw/hfi2/mad.c          |    4 
>  drivers/infiniband/hw/hfi2/pin_system.c   |    2 
>  drivers/infiniband/hw/hfi2/qsfp.c         |    2 
>  drivers/infiniband/hw/hfi2/sdma.c         |    4 
>  drivers/infiniband/hw/hfi2/tid_rdma.c     |    2 
>  drivers/infiniband/hw/hfi2/tid_system.c   |    2 
>  drivers/infiniband/hw/hfi2/user_exp_rcv.c |    2 
>  drivers/infiniband/hw/hfi2/uverbs.c       |  262 +++++++++++++++++++++++------
>  drivers/infiniband/hw/hfi2/uverbs.h       |   24 +++
>  drivers/infiniband/hw/hfi2/verbs.c        |    6 +
>  drivers/infiniband/hw/hfi2/vf2pf_lb.c     |    2 
>  22 files changed, 317 insertions(+), 184 deletions(-)
>  create mode 100644 drivers/infiniband/hw/hfi2/Kconfig
>  create mode 100644 drivers/infiniband/hw/hfi2/TODO
> 
> diff --git a/drivers/infiniband/hw/hfi1/Kconfig b/drivers/infiniband/hw/hfi1/Kconfig
> index 14b92e12bf29..a006dd112966 100644
> --- a/drivers/infiniband/hw/hfi1/Kconfig
> +++ b/drivers/infiniband/hw/hfi1/Kconfig
> @@ -1,12 +1,13 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config INFINIBAND_HFI1
> -	tristate "Cornelis OPX Gen1 support"
> +	tristate "Cornelis OPX Gen1 (WFR) support"
>  	depends on X86_64 && INFINIBAND_RDMAVT && I2C && !UML
>  	select MMU_NOTIFIER
>  	select CRC32
>  	select I2C_ALGOBIT
>  	help
> -	This is a low-level driver for Cornelis OPX Gen1 adapter.
> +	This is a low-level driver for Cornelis OPX Gen1 (WFR) adapters.
> +	For Gen2 (JKR) adapters use INFINIBAND_HFI2.
>  config HFI1_DEBUG_SDMA_ORDER
>  	bool "HFI1 SDMA Order debug"
>  	depends on INFINIBAND_HFI1
> diff --git a/drivers/infiniband/hw/hfi2/Kconfig b/drivers/infiniband/hw/hfi2/Kconfig
> new file mode 100644
> index 000000000000..7e3d80b3c459
> --- /dev/null
> +++ b/drivers/infiniband/hw/hfi2/Kconfig
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +# Copyright(c) 2025-2026 Cornelis Networks, Inc.
> +config INFINIBAND_HFI2
> +	tristate "Cornelis OPX Gen2 (JKR) support"
> +	depends on X86_64 && INFINIBAND_RDMAVT && I2C && !UML
> +	depends on PCI_IOV
> +	select MMU_NOTIFIER
> +	select CRC32
> +	select I2C_ALGOBIT
> +	help
> +	This is a low-level driver for Cornelis OPX Gen2 (JKR) adapters.
> +	For Gen1 (WFR) adapters use INFINIBAND_HFI1. This separation is
> +	temporary; hfi2 will eventually support both WFR and JKR hardware
> +	at which point hfi1 will be removed.
> +config HFI2_DEBUG_SDMA_ORDER
> +	bool "HFI2 SDMA Order debug"
> +	depends on INFINIBAND_HFI2
> +	default n
> +	help
> +	  Enable this debug flag to test for out-of-order SDMA completions
> +	  during unit testing. This option adds extra tracking to detect
> +	  when SDMA completions arrive out of sequence, which should not
> +	  happen in normal operation.
> +config HFI2_SDMA_VERBOSITY
> +	bool "Config SDMA Verbosity"
> +	depends on INFINIBAND_HFI2
> +	default n
> +	help
> +	  Enable this flag to turn on verbose SDMA debug logging. This
> +	  produces additional diagnostic output useful for debugging SDMA
> +	  issues. Should not be enabled in production as it generates
> +	  significant log output.

When working on Sashiko fixes, please add blank lines between
sections and remove "default n".

Thanks