All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v1.1 08/11] samples/damon/mtier: stop all contexts with single damon_stop() call
Date: Sun,  5 Jul 2026 09:01:35 -0700	[thread overview]
Message-ID: <20260705160142.97308-9-sj@kernel.org> (raw)
In-Reply-To: <20260705160142.97308-1-sj@kernel.org>

damon_stop() was theoretically able to return failure while keeping the
second context for mtier running.  mtier stops its contexts one by one
with two damon_stop() call for the reason.  damon_stop() is refactored
to always successfully stop all requested DAMON contexts.  The two calls
are unnecessary.  Use only single damon_stop() call for all contexts.

Signed-off-by: SJ Park <sj@kernel.org>
---
 samples/damon/mtier.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/samples/damon/mtier.c b/samples/damon/mtier.c
index 90881e8bd441f..ac9c24b92ead8 100644
--- a/samples/damon/mtier.c
+++ b/samples/damon/mtier.c
@@ -200,8 +200,7 @@ static int damon_sample_mtier_start(void)
 
 static void damon_sample_mtier_stop(void)
 {
-	damon_stop(ctxs, 1);
-	damon_stop(&ctxs[1], 1);
+	damon_stop(ctxs, 2);
 	damon_destroy_ctx(ctxs[0]);
 	damon_destroy_ctx(ctxs[1]);
 }
-- 
2.47.3

  parent reply	other threads:[~2026-07-05 16:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05 16:01 [RFC PATCH v1.1 00/11] mm/damon: refactor damon_{start,stop,commit}() for simple error handling SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 01/11] mm/damon/core: stop ctxs in damon_start() before returning an error SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 02/11] samples/damon/mtier: do not stop first context for damon_start() failure SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 03/11] mm/damon/core: make damon_stop() never fails SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 04/11] mm/damon/sysfs: ignore damon_stop() return value SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 05/11] mm/damon/reclaaim: " SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 06/11] mm/damon/lru_sort: " SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 07/11] mm/damon/core: change damon_stop() return type to void SJ Park
2026-07-05 16:01 ` SJ Park [this message]
2026-07-05 16:01 ` [RFC PATCH v1.1 09/11] mm/damon/core: wait ctx stop in damon_call() before reruning an error SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 10/11] samples/damon/wsse: do not stop ctx for damon_call() failure SJ Park
2026-07-05 16:01 ` [RFC PATCH v1.1 11/11] samples/damon/prcl: do not stop DAMON " SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260705160142.97308-9-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.