From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fscrypt: Simplify handling of errors during initcall
Date: Sun, 5 Jul 2026 12:11:58 -0700 [thread overview]
Message-ID: <20260705191158.GC41916@quark> (raw)
In-Reply-To: <20260619000030.166851-1-ebiggers@kernel.org>
On Thu, Jun 18, 2026 at 05:00:30PM -0700, Eric Biggers wrote:
> Since CONFIG_FS_ENCRYPTION is a bool, not a tristate, fs/crypto/ can
> only be builtin or absent entirely; it can't be a loadable module.
> Therefore, the error code that gets returned from the fscrypt_init()
> initcall is never used. If any part of the initcall does fail, which
> should never happen, the kernel will be left in a bad state.
>
> Following the usual convention for builtin code, just panic the kernel
> if any of part of the initcall fails. This simplifies the code.
>
> This closely mirrors commit e77000ccc531 ("fsverity: simplify handling
> of errors during initcall").
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
Applied to https://git.kernel.org/pub/scm/fs/fscrypt/linux.git/log/?h=for-next
- Eric
prev parent reply other threads:[~2026-07-05 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 0:00 [PATCH] fscrypt: Simplify handling of errors during initcall Eric Biggers
2026-07-05 19:11 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260705191158.GC41916@quark \
--to=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.