From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E783A1E67; Sun, 5 Jul 2026 19:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783280864; cv=none; b=lrcPgbmcdT+X5+46PfaW3mpPHA5bxQzOrZWfP2Ja3zJdJQmnawh9J+kSKOwhez0ripje8TAlgTYjtXnYc9UU24SV4EKMg5JFWPLjGK7cjcOdQRya2g8S6M3dq6+vEX8aP0NYKVuzrMBrKTbmCKIWznSi0B/Kw8lRuDr7rJV4/4A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783280864; c=relaxed/simple; bh=P5GMzOHJDDWmVeKXEaQCUlgkWe1RuXYujVlKi93mNjk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TwHL3Po1FdKTja4WnZCmESt+FYoVyJ8a/bwu9JzRVF0l7AjDsiUxrNN5NEtR2TeQ5FTcCPQvxr0nF0wYk/gT0K2ff0yAYeINa1vTZMDv0iPrAPNmDeBIJcR5xuhg8I+hxDBShP4pI6k0z1LtJ7p+g6ZeZW5HOhpNCe08zwFKvW4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=P0OsLQrb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="P0OsLQrb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9DBC1F00A3D; Sun, 5 Jul 2026 19:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783280863; bh=gfpz689V4pGfz5uZs3AyGXvqPghKUAJ1Vdt7trKNrUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P0OsLQrbKtGJbOjVdbuc6CA9XXOCTVbHVydNKM0DKH9f/LFbP/+VpH6I1ORHGvRqB rfYalun3Yy6GEPe5Hs+eUmiqkJ6V/Kd5YEErN6EtnBB4rMU784hkT3yw0KyXhSdcv0 mAUuiJFK+L93CMT7AXzG6PITXfdpBTT20C0LN+AfvcG/PFP8pTmbCEWhnvD/xJaC31 7Do5PYFE8KJaNgM2J8axm/OZ+6JPlWa8hkwRyAOvzCz5QydanVQsgqaLLRisgOSimq BWEQumtKNeqtyGhvu1j9kXWPWHiyVi2K8ba0/WhD5QXUBHqID/2LdjudLs5K4rxsaQ dBAm3ldcD71wQ== From: Eric Biggers To: linux-fscrypt@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, Christoph Hellwig , Theodore Ts'o , Andreas Dilger , Baokun Li , Jan Kara , Ojaswin Mujoo , Ritesh Harjani , Zhang Yi , Jaegeuk Kim , Chao Yu , Eric Biggers Subject: [PATCH v2 04/17] fscrypt: Fully disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE Date: Sun, 5 Jul 2026 12:45:41 -0700 Message-ID: <20260705194555.75030-5-ebiggers@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260705194555.75030-1-ebiggers@kernel.org> References: <20260705194555.75030-1-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE works only with the fs-layer implementation of file contents encryption, not blk-crypto. This is a problem for standardizing on blk-crypto. Fortunately, no one should be using this combination anyway. It doesn't make sense because the entire point of IV_INO_LBLK_32 is to support inline encryption hardware that is limited to 32-bit DUNs. Thus, fully disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE. Reviewed-by: Christoph Hellwig Signed-off-by: Eric Biggers --- Documentation/filesystems/fscrypt.rst | 3 +++ fs/crypto/inline_crypt.c | 13 ------------- fs/crypto/policy.c | 17 +++++++++++++++++ 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst index c0dd35f1af12..92b8f311e211 100644 --- a/Documentation/filesystems/fscrypt.rst +++ b/Documentation/filesystems/fscrypt.rst @@ -336,6 +336,9 @@ per I/O request and may have only a small number of keyslots. This format results in some level of IV reuse, so it should only be used when necessary due to hardware limitations. +IV_INO_LBLK_32 is supported only when the filesystem block size is +equal to the page size. + Key identifiers --------------- diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c index aaf71f6068b0..83dea8bc2c8c 100644 --- a/fs/crypto/inline_crypt.c +++ b/fs/crypto/inline_crypt.c @@ -112,19 +112,6 @@ int fscrypt_select_encryption_impl(struct fscrypt_inode_info *ci, if (!(sb->s_flags & SB_INLINECRYPT)) return 0; - /* - * When a page contains multiple logically contiguous filesystem blocks, - * some filesystem code only calls fscrypt_mergeable_bio() for the first - * block in the page. This is fine for most of fscrypt's IV generation - * strategies, where contiguous blocks imply contiguous IVs. But it - * doesn't work with IV_INO_LBLK_32. For now, simply exclude - * IV_INO_LBLK_32 with blocksize != PAGE_SIZE from inline encryption. - */ - if ((fscrypt_policy_flags(&ci->ci_policy) & - FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) && - sb->s_blocksize != PAGE_SIZE) - return 0; - /* * On all the filesystem's block devices, blk-crypto must support the * crypto configuration that the file would use. diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c index f40fb5924e75..a7322dba7557 100644 --- a/fs/crypto/policy.c +++ b/fs/crypto/policy.c @@ -177,6 +177,23 @@ static bool supported_iv_ino_lblk_policy(const struct fscrypt_policy_v2 *policy, type, sb->s_id); return false; } + + /* + * IV_INO_LBLK_32 isn't compatible with inline encryption when + * s_blocksize != PAGE_SIZE. In that case the DUN can wrap around in + * the middle of a page, but sometimes fscrypt_mergeable_bio() is called + * only for the first block per page. Since IV_INO_LBLK_32 exists only + * to support inline encryption hardware that is limited to 32-bit DUNs, + * just disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE entirely. + */ + if ((policy->flags & FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) && + sb->s_blocksize != PAGE_SIZE) { + fscrypt_warn(inode, + "Can't use %s policy on filesystem '%s' with block size != PAGE_SIZE", + type, sb->s_id); + return false; + } + return true; } -- 2.54.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9C2EC44501 for ; Sun, 5 Jul 2026 19:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:MIME-Version:References:In-Reply-To: Message-ID:Date:To:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=opSaUb90wgpB/QPKSYWI2mRwbhxSbKOqOPUOpv8MgYM=; b=N01EI2qS9G3axEm8kzDMhIWibH JaQ0tduVo5oPrZjXlQW8qB0V2tq+DTW3l/ivnDg2HohHJcvCmwUW2u/Uih9CJcGhGEsHJ3y5DFAE9 SEphfdXdN7LFOazSRvXtyIH1fXiwX59gqRu/mrsbKvJgT1VgOabI5MR0rWgucBKifuZw=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wgSp1-0004Qq-KV; Sun, 05 Jul 2026 19:48:09 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wgSoh-0004QB-Cl for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Jul 2026 19:47:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gfpz689V4pGfz5uZs3AyGXvqPghKUAJ1Vdt7trKNrUY=; b=UYIa129K+oDrHfW3NoivrY4cJB Rw1X/QJgnAHGAHxJCuGlfGnK+BWSeyIA3dwi2ry7B17Pj+A0YEmgWN0TGwSqtS4eIu1t8WqnZgkW6 yYGpJcxYUy+S1wXCqjub+jiO6jE3fl8ZnszihB9ndmZ0gj3N3i+SA2qij9YQGPbvFJ9c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gfpz689V4pGfz5uZs3AyGXvqPghKUAJ1Vdt7trKNrUY=; b=TktW1sfFzmW75wuHQDsaeVVeK8 vwEIcdsyqtQn0MgVpFyh2GOWC/ReAFXFmddK8BdF6RJ1ccs6S2PJnVI78hRFSodCTF4oIwN+Eu1pk MJBPMBTeHkr7FjoCKZvhjSSxUPmhVM2IdmdETkQyHl+KKy1yc8ROygum3sPENoEGAp2k=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wgSod-0001BX-Tu for linux-f2fs-devel@lists.sourceforge.net; Sun, 05 Jul 2026 19:47:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 2699A42DA7; Sun, 5 Jul 2026 19:47:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9DBC1F00A3D; Sun, 5 Jul 2026 19:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783280863; bh=gfpz689V4pGfz5uZs3AyGXvqPghKUAJ1Vdt7trKNrUY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=P0OsLQrbKtGJbOjVdbuc6CA9XXOCTVbHVydNKM0DKH9f/LFbP/+VpH6I1ORHGvRqB rfYalun3Yy6GEPe5Hs+eUmiqkJ6V/Kd5YEErN6EtnBB4rMU784hkT3yw0KyXhSdcv0 mAUuiJFK+L93CMT7AXzG6PITXfdpBTT20C0LN+AfvcG/PFP8pTmbCEWhnvD/xJaC31 7Do5PYFE8KJaNgM2J8axm/OZ+6JPlWa8hkwRyAOvzCz5QydanVQsgqaLLRisgOSimq BWEQumtKNeqtyGhvu1j9kXWPWHiyVi2K8ba0/WhD5QXUBHqID/2LdjudLs5K4rxsaQ dBAm3ldcD71wQ== To: linux-fscrypt@vger.kernel.org Date: Sun, 5 Jul 2026 12:45:41 -0700 Message-ID: <20260705194555.75030-5-ebiggers@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260705194555.75030-1-ebiggers@kernel.org> References: <20260705194555.75030-1-ebiggers@kernel.org> MIME-Version: 1.0 X-Headers-End: 1wgSod-0001BX-Tu Subject: [f2fs-dev] [PATCH v2 04/17] fscrypt: Fully disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: Ritesh Harjani , Theodore Ts'o , Zhang Yi , linux-f2fs-devel@lists.sourceforge.net, linux-block@vger.kernel.org, Andreas Dilger , Ojaswin Mujoo , Baokun Li , Jaegeuk Kim , linux-fsdevel@vger.kernel.org, Jan Kara , linux-ext4@vger.kernel.org, Christoph Hellwig , Eric Biggers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE works only with the fs-layer implementation of file contents encryption, not blk-crypto. This is a problem for standardizing on blk-crypto. Fortunately, no one should be using this combination anyway. It doesn't make sense because the entire point of IV_INO_LBLK_32 is to support inline encryption hardware that is limited to 32-bit DUNs. Thus, fully disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE. Reviewed-by: Christoph Hellwig Signed-off-by: Eric Biggers --- Documentation/filesystems/fscrypt.rst | 3 +++ fs/crypto/inline_crypt.c | 13 ------------- fs/crypto/policy.c | 17 +++++++++++++++++ 3 files changed, 20 insertions(+), 13 deletions(-) diff --git a/Documentation/filesystems/fscrypt.rst b/Documentation/filesystems/fscrypt.rst index c0dd35f1af12..92b8f311e211 100644 --- a/Documentation/filesystems/fscrypt.rst +++ b/Documentation/filesystems/fscrypt.rst @@ -336,6 +336,9 @@ per I/O request and may have only a small number of keyslots. This format results in some level of IV reuse, so it should only be used when necessary due to hardware limitations. +IV_INO_LBLK_32 is supported only when the filesystem block size is +equal to the page size. + Key identifiers --------------- diff --git a/fs/crypto/inline_crypt.c b/fs/crypto/inline_crypt.c index aaf71f6068b0..83dea8bc2c8c 100644 --- a/fs/crypto/inline_crypt.c +++ b/fs/crypto/inline_crypt.c @@ -112,19 +112,6 @@ int fscrypt_select_encryption_impl(struct fscrypt_inode_info *ci, if (!(sb->s_flags & SB_INLINECRYPT)) return 0; - /* - * When a page contains multiple logically contiguous filesystem blocks, - * some filesystem code only calls fscrypt_mergeable_bio() for the first - * block in the page. This is fine for most of fscrypt's IV generation - * strategies, where contiguous blocks imply contiguous IVs. But it - * doesn't work with IV_INO_LBLK_32. For now, simply exclude - * IV_INO_LBLK_32 with blocksize != PAGE_SIZE from inline encryption. - */ - if ((fscrypt_policy_flags(&ci->ci_policy) & - FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) && - sb->s_blocksize != PAGE_SIZE) - return 0; - /* * On all the filesystem's block devices, blk-crypto must support the * crypto configuration that the file would use. diff --git a/fs/crypto/policy.c b/fs/crypto/policy.c index f40fb5924e75..a7322dba7557 100644 --- a/fs/crypto/policy.c +++ b/fs/crypto/policy.c @@ -177,6 +177,23 @@ static bool supported_iv_ino_lblk_policy(const struct fscrypt_policy_v2 *policy, type, sb->s_id); return false; } + + /* + * IV_INO_LBLK_32 isn't compatible with inline encryption when + * s_blocksize != PAGE_SIZE. In that case the DUN can wrap around in + * the middle of a page, but sometimes fscrypt_mergeable_bio() is called + * only for the first block per page. Since IV_INO_LBLK_32 exists only + * to support inline encryption hardware that is limited to 32-bit DUNs, + * just disallow IV_INO_LBLK_32 with s_blocksize != PAGE_SIZE entirely. + */ + if ((policy->flags & FSCRYPT_POLICY_FLAG_IV_INO_LBLK_32) && + sb->s_blocksize != PAGE_SIZE) { + fscrypt_warn(inode, + "Can't use %s policy on filesystem '%s' with block size != PAGE_SIZE", + type, sb->s_id); + return false; + } + return true; } -- 2.54.0 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel