Re: [PATCH RFC 2/6] ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing NULL check on `codec_dai->component->name_prefix` causes a kernel panic if the device tree omits the `sound-name-prefix` property.
--

commit 34e4567f69218c8e1f7099e3d2b65d5ada37de5a
Author: David Heidelberg <david@ixit.cz>

ASoC: qcom: sdm845: use DSP_A format for TDM codec DAIs

This commit modifies sdm845_snd_startup() to use the DSP_A timing format
instead of DSP_B for TDM codec DAIs to match the expected hardware behavior.

> diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
> --- a/sound/soc/qcom/sdm845.c
> +++ b/sound/soc/qcom/sdm845.c
> @@ -385,7 +385,7 @@ static int sdm845_snd_startup(struct snd_pcm_substream *substream)
>  				TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
>  		}
>  
> -		codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> +		codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_A;
>  
>  		for_each_rtd_codec_dais(rtd, j, codec_dai) {
>  
>  			if (!strcmp(codec_dai->component->name_prefix,
>  				    "Left")) {

[Severity: High]
This is a pre-existing issue, but can this lead to a NULL pointer dereference?

If a codec's device tree node omits the sound-name-prefix property, the ASoC
core sets component->name_prefix to NULL. Passing this directly to strcmp()
will cause a kernel panic during driver startup.

The same pattern appears immediately below this for the "Right" channel
prefix, and also in sdm845_tdm_snd_hw_params(). Should there be a NULL check
added before comparing these prefixes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705-pixel3-audio-v1-0-3b66f33859f1@ixit.cz?part=2