Re: [PATCH 01/15] netlink: specs: Introduce multi-message blobs for SPDM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `bloblen` property in `genetlink-legacy.yaml` is missing its `type: string` specification, rendering the schema validation incomplete.
--

commit cab827e2cbb54e443717f126a29803e1306e23f6
Author: Dan Williams <djbw@kernel.org>

netlink: specs: Introduce multi-message blobs for SPDM

This commit introduces a netlink blob property to teach YNL that an attribute
may span multiple messages. It modifies the netlink schemas to allow YNL to
infer this structure and interrogate the total blob length to preallocate
buffers.

Link: http://lore.kernel.org/20260318170014.6650d2bf@kernel.org [1]

> diff --git a/Documentation/netlink/genetlink-legacy.yaml b/Documentation/netlink/genetlink-legacy.yaml
> index f9c44747729ae..fff9d7b76dbc9 100644
> --- a/Documentation/netlink/genetlink-legacy.yaml
> +++ b/Documentation/netlink/genetlink-legacy.yaml

[ ... ]

> @@ -239,6 +239,12 @@ properties:
>                  enum: [ little-endian, big-endian ]
>                multi-attr:
>                  type: boolean
> +              bloblen:
> +                description: |
> +                  Marks this attribute as a variable-length blob that may be split across
> +                  multiple messages. The value names a separate scalar attribute that carries
> +                  the total blob length, and which is sent ahead of the blob data so a consumer
> +                  can preallocate the full payload.

[Severity: Low]
Is this missing a type definition?

Unlike the additions in genetlink.yaml and netlink-raw.yaml, this property
does not specify that the type is a string. Without a specified type, the
schema validation defaults to allowing any data type for bloblen in legacy
families, which could bypass intended type validation.

>                nested-attributes:
>                  description: Name of the space (sub-space) used inside the attribute.
>                  type: string

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260705220819.2472765-1-djbw@kernel.org?part=1