All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fuad Tabba <fuad.tabba@linux.dev>
To: kvm@vger.kernel.org
Cc: kvmarm@lists.linux.dev, Will Deacon <will@kernel.org>,
	Alexandru Elisei <alexandru.elisei@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	Marc Zyngier <maz@kernel.org>, Fuad Tabba <tabba@google.com>
Subject: [PATCH kvmtool v1 3/5] Use kvm_userspace_memory_region2 for all memory registration
Date: Mon,  6 Jul 2026 09:35:53 +0100	[thread overview]
Message-ID: <20260706083555.302972-4-fuad.tabba@linux.dev> (raw)
In-Reply-To: <20260706083555.302972-1-fuad.tabba@linux.dev>

Switch kvm__register_mem() and kvm__destroy_mem() from
kvm_userspace_memory_region to kvm_userspace_memory_region2 and
KVM_SET_USER_MEMORY_REGION2 unconditionally. The v2 struct is a
superset; when the extra fields are zero, the ioctl behaves
identically to v1.

This prepares for adding guest_memfd support.

Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
 kvm.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/kvm.c b/kvm.c
index 95ccfcb..8a7fd09 100644
--- a/kvm.c
+++ b/kvm.c
@@ -189,7 +189,7 @@ core_exit(kvm__exit);
 int kvm__destroy_mem(struct kvm *kvm, u64 guest_phys, u64 size,
 		     void *userspace_addr)
 {
-	struct kvm_userspace_memory_region mem;
+	struct kvm_userspace_memory_region2 mem;
 	struct kvm_mem_bank *bank;
 	int ret;
 
@@ -213,14 +213,14 @@ int kvm__destroy_mem(struct kvm *kvm, u64 guest_phys, u64 size,
 		goto out;
 	}
 
-	mem = (struct kvm_userspace_memory_region) {
+	mem = (struct kvm_userspace_memory_region2) {
 		.slot			= bank->slot,
 		.guest_phys_addr	= guest_phys,
 		.memory_size		= 0,
 		.userspace_addr		= (unsigned long)userspace_addr,
 	};
 
-	ret = ioctl(kvm->vm_fd, KVM_SET_USER_MEMORY_REGION, &mem);
+	ret = ioctl(kvm->vm_fd, KVM_SET_USER_MEMORY_REGION2, &mem);
 	if (ret < 0) {
 		ret = -errno;
 		goto out;
@@ -239,7 +239,6 @@ out:
 int kvm__register_mem(struct kvm *kvm, u64 guest_phys, u64 size,
 		      void *userspace_addr, enum kvm_mem_type type)
 {
-	struct kvm_userspace_memory_region mem;
 	struct kvm_mem_bank *merged = NULL;
 	struct kvm_mem_bank *bank;
 	struct list_head *prev_entry;
@@ -320,7 +319,7 @@ int kvm__register_mem(struct kvm *kvm, u64 guest_phys, u64 size,
 		flags |= KVM_MEM_READONLY;
 
 	if (type != KVM_MEM_TYPE_RESERVED) {
-		mem = (struct kvm_userspace_memory_region) {
+		struct kvm_userspace_memory_region2 mem = {
 			.slot			= slot,
 			.flags			= flags,
 			.guest_phys_addr	= guest_phys,
@@ -328,7 +327,7 @@ int kvm__register_mem(struct kvm *kvm, u64 guest_phys, u64 size,
 			.userspace_addr		= (unsigned long)userspace_addr,
 		};
 
-		ret = ioctl(kvm->vm_fd, KVM_SET_USER_MEMORY_REGION, &mem);
+		ret = ioctl(kvm->vm_fd, KVM_SET_USER_MEMORY_REGION2, &mem);
 		if (ret < 0) {
 			ret = -errno;
 			goto out;
-- 
2.39.5


  parent reply	other threads:[~2026-07-06  8:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  8:35 [PATCH kvmtool v1 0/5] Add guest_memfd support for arm64 Fuad Tabba
2026-07-06  8:35 ` [PATCH kvmtool v1 1/5] Initialize the return value in kvm__for_each_mem_bank() Fuad Tabba
2026-07-06  8:35 ` [PATCH kvmtool v1 2/5] Remove newline from end of die() aborts Fuad Tabba
2026-07-06 10:53   ` Suzuki K Poulose
2026-07-06 10:57     ` Fuad Tabba
2026-07-06  8:35 ` Fuad Tabba [this message]
2026-07-06 10:23   ` [PATCH kvmtool v1 3/5] Use kvm_userspace_memory_region2 for all memory registration Suzuki K Poulose
2026-07-06 10:41     ` Fuad Tabba
2026-07-06 10:46       ` Will Deacon
2026-07-06 10:47         ` Fuad Tabba
2026-07-06 10:57     ` Alexandru Elisei
2026-07-06 10:59       ` Fuad Tabba
2026-07-06  8:35 ` [PATCH kvmtool v1 4/5] Add guest_memfd support to kvm__register_mem() Fuad Tabba
2026-07-06 11:00   ` Suzuki K Poulose
2026-07-06 11:13     ` Suzuki K Poulose
2026-07-06 11:25       ` Fuad Tabba
2026-07-06 12:34         ` Suzuki K Poulose
2026-07-06  8:35 ` [PATCH kvmtool v1 5/5] arm64: Add --guest-memfd option to back guest RAM with guest_memfd Fuad Tabba
2026-07-06 11:18   ` Suzuki K Poulose
2026-07-06 11:24     ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260706083555.302972-4-fuad.tabba@linux.dev \
    --to=fuad.tabba@linux.dev \
    --cc=alexandru.elisei@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.