Re: [PATCH v2 07/15] arm64: dts: freescale: imx8mn-var-som: Rework WiFi/BT and add legacy dts

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The legacy Symphony device tree (`imx8mn-var-som-symphony-legacy.dts`) fails to revert the `uart2` pinctrl configuration, permanently claiming the Bluetooth enable GPIO and breaking legacy Bluetooth initialization.
--

commit 31b3d797e663552df95cdacb42e55c6c3a65c79e
Author: Stefano Radaelli <stefano.r@variscite.com>

arm64: dts: freescale: imx8mn-var-som: Rework WiFi/BT and add legacy dts

This moves the IW61x wireless module configuration out of the base
imx8mn-var-som.dtsi into dedicated variant includes. It also adds a legacy
device tree to support older SOM revisions with Broadcom WiFi.

[ ... ]
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony-legacy.dts b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony-legacy.dts
> new file mode 100644
> index 0000000000000..5998ebcef4740
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-var-som-symphony-legacy.dts
> @@ -0,0 +1,19 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright 2026 Variscite Ltd.
> + */
> +
> +#include "imx8mn-var-som-symphony.dts"
> +#include "imx8mn-var-som-wifi-brcm-legacy.dtsi"
> +
> +&bluetooth_iw61x {
> +	status = "disabled";
> +};

[Severity: High]
Will this leave the pinctrl_bt group claimed by uart2?

Since this legacy device tree includes imx8mn-var-som-symphony.dts (which
includes the new IW61x setup), uart2 is initially configured with:

&uart2 {
        pinctrl-0 = <&pinctrl_uart2>, <&pinctrl_bt>;
        ...
}

Disabling bluetooth_iw61x here leaves the pinctrl-0 property on uart2
unchanged. Because the i.MX pinctrl driver uses strict pinmux claiming,
wouldn't this permanently claim the BT enable GPIO (GPIO2_IO6) and prevent
legacy userspace scripts or drivers from exporting or toggling it?

Does uart2 need an override here to drop pinctrl_bt?

> +
> +&iw61x_pwrseq {
> +	status = "disabled";
> +};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783330236.git.stefano.r@variscite.com?part=7