From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABD4441D4E6 for ; Mon, 6 Jul 2026 11:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783337936; cv=none; b=I1144XidUj55HSf3lTXLMpINGMESbIwpZ0Ko5gW8VedEShzzqOg3TkuHmX6TAoUc/Ka3RZxNGQ9Kdm4H7xc0vuVhKRjjsFmUjeGeXGMkMBeKLaMgtmVJnN68dBiuF43v8CxMkKy785QgarOU0X+CVlpKVBoPLcc7rBkVnR538mU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783337936; c=relaxed/simple; bh=7sAeWkd7EwlEsoCRUeUm175QpZ9wzHwghbd3UXK25OE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BGjxA0R2rQ202pCimBWA/tqE+VzhHMVSxpa1uRppIkXSqlXVj3emJaH944hRzR7YU6P9YJRgjU4onq+kcJAsBjUexo5D3/RiNGeU2gqxFdAXacqPl1fqPMb68EuxWPHZmRmkYrcwGLRq6JTnZuLodm7G+eonRRnURTg3E8PbnyU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvK/Hbn6; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvK/Hbn6" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-385b78b44a0so987762a91.0 for ; Mon, 06 Jul 2026 04:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783337934; x=1783942734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XPiB1VecAR3TN1u8hRdYEbrIAIhOnDTmSxtVCqyGQ3Y=; b=mvK/Hbn6C3GajLr04bOG/ecwTbmfmm6pHZZ7LY4p89pdJ3v3rdQzhDFRQW/A5HiMCw 9zULrIHngYM/c8fdUQWS+atr0E/rZuplm9GpBnoKhSOTJHo+JC7A8DQK2Kk0CwtDFFSS ufAkvVoMr4/zc+Vd1pB9tDGd1N+eXqj0ztn8snMpBezK3nse5dDIX6JFPl8X3eW6Z44/ BQgytokyVcUPVp9tpbNTRP5au9Wtx3HKvcITyrySvaOQJ7EIwULzOaL0FwMdQCS+kQ/v 2oZGCl+3X38vUrvWkWPgj2+8WG6DBBQw6Qn4sbqcOR8hRC8HEqtJCOZDEF/wF+lW7cLT Cc5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783337934; x=1783942734; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XPiB1VecAR3TN1u8hRdYEbrIAIhOnDTmSxtVCqyGQ3Y=; b=XKfQHp8ZoY5FCH3fODrQsSfcbRHJiMk5XY6XR3f8ZfBRFMK3cHYaGOImnb6F3gc+Yf t4+x1rpLWV3eDC4oiH9DcBBtzUKoBA0IVJk+iIaAbnFbntPHlSt3aQCmv2yqAVmR0HG1 +Boxp4Jq3rZD2cOdNVo1ATZcwLFWmJmj/PbxHDa+CqYeBVALnAl4xp3QKOlsPD5yXzMK FUjkDnkBYB4EgDbE5v1EWFErt6O9gS2I79Eg3VEfZSSRPdF7DsfqM/RZ0W8ykJzDzw3M n4T4y3yWnzmbm7JOAa1KIM5B12LGLzRxtcogrX4oEHx6LuxHvFMzebv7W0dt0UmTuYWu vbbQ== X-Forwarded-Encrypted: i=1; AHgh+Rrdh7pdIMsmRq2s0bpQmLveo8cHgilTVIG8rAtIA1waT9mU4X7eLvEQuq4lRXWKLzmbDfY64SBRRd8u/Z8=@vger.kernel.org X-Gm-Message-State: AOJu0YzDCfHfAgLB0Lwqp+XTtVsBaQV3rsqAlM2nmDQxdNwlAEiDCvhJ +KZ+WOEqlWidqK60QTdThCOkV+86+p6y15IhbuOufXtovSe+kFu6c07E X-Gm-Gg: AfdE7cn9bM2LXOPaotyY2MBOI20+POFrW3lL91dGwIQgVv03xX+12dlQ9Xyz5hxZdNl 4vm+w/XNKNxFbE+PwTvuIeGZXlx2aNn2pLL3IeJlNxuYbqlQfwsSz376ug3Ehx+hRa3kOIqA4yP RG+s3kZMSJVwhej3sYKFCdHpdb6vvxnfdVppB0WdEgyS92C89TXxUohulQ+DRV9RgBkiG08WGne LqOoKrUje0W/C371LdBDlb3F6yX+kVVUaNAlYnqgNGmxO95pAsC8WwypMvAuErfxx88MHOKC1U2 zulLSZWFfvlDOItGvfXFTpx9WBV636AfivHvTvcppsIQrn/0cAyztYVzjM/za6DYFf8s/HQjfK6 t3ccCGOpm9Ra/VhKhO5OdLxhRwrKYgJSPsXT3yjxMmEQZklURSiX297OIKlcUtNaxkG6pfQOtpI 6/woYdlq8j9jfOAFG78cXw4LX5Li6o4/YAd96sATwFLtLGgT+hmCn3eNQ6N6Am7yEttNnyakwYl 2V/VmtLvfTdN0RKAA0= X-Received: by 2002:a17:90b:51:b0:37f:9cdf:f0ab with SMTP id 98e67ed59e1d1-3829f9debb6mr8700704a91.26.1783337933770; Mon, 06 Jul 2026 04:38:53 -0700 (PDT) Received: from leonardoc-nb ([67.159.246.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31151fff32fsm18581752eec.21.2026.07.06.04.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 04:38:53 -0700 (PDT) From: Leonardo Costa To: leoreis.costa@gmail.com Cc: Laurent.pinchart@ideasonboard.com, airlied@gmail.com, andrzej.hajda@intel.com, dri-devel@lists.freedesktop.org, francesco@dolcini.it, jernej.skrabec@gmail.com, jonas@kwiboo.se, leonardo.costa@toradex.com, linux-kernel@vger.kernel.org, luca.ceresoli@bootlin.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, neil.armstrong@linaro.org, rfoss@kernel.org, simona@ffwll.ch, stable@vger.kernel.org, tomi.valkeinen@ideasonboard.com, tzimmermann@suse.de Subject: Re: [PATCH] drm/bridge: tc358768: Enforce input bus flags via atomic_check Date: Mon, 6 Jul 2026 08:38:36 -0300 Message-ID: <20260706113838.1586775-1-leoreis.costa@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260706105840.1582166-1-leoreis.costa@gmail.com> References: <20260706105840.1582166-1-leoreis.costa@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, > The tc358768 declares static bridge timings requiring pixel data to be > sampled on the positive clock edge. > > However, the DRM core default propagation simply copies the output-side > bus flags, coming from the next bridge, connector or panel, to the > input side. If the propagated flags are incompatible with the bridge > ones, the data is wrongly sampled, typically resulting in visual > artifacts on the panel. > > Implement the atomic_check hook, replacing the mutually exclusive > mode_fixup, and set the bridge state input bus flags to the ones > required by the tc358768. The sync polarity defaulting previously done > in mode_fixup is carried over into atomic_check unchanged. > > Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver") > Cc: stable@vger.kernel.org > Signed-off-by: Leonardo Costa > --- > drivers/gpu/drm/bridge/tc358768.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c > index 0d85120fcc7a3..0516a331e71ba 100644 > --- a/drivers/gpu/drm/bridge/tc358768.c > +++ b/drivers/gpu/drm/bridge/tc358768.c > @@ -1262,10 +1262,13 @@ tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge, > return input_fmts; > } > > -static bool tc358768_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static int tc358768_bridge_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > { > + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; > + > /* Default to positive sync */ > > if (!(adjusted_mode->flags & > @@ -1276,13 +1279,15 @@ static bool tc358768_mode_fixup(struct drm_bridge *bridge, > (DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_NVSYNC))) > adjusted_mode->flags |= DRM_MODE_FLAG_PVSYNC; > > - return true; > + bridge_state->input_bus_cfg.flags = bridge->timings->input_bus_flags; > + > + return 0; > } > > static const struct drm_bridge_funcs tc358768_bridge_funcs = { > .attach = tc358768_bridge_attach, > .mode_valid = tc358768_bridge_mode_valid, > - .mode_fixup = tc358768_mode_fixup, > + .atomic_check = tc358768_bridge_atomic_check, > .atomic_pre_enable = tc358768_bridge_atomic_pre_enable, > .atomic_enable = tc358768_bridge_atomic_enable, > .atomic_disable = tc358768_bridge_atomic_disable, Please ignore this, as it was not meant to be sent in reply to the thread above. That was an accident.