From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72A42C43602 for ; Mon, 6 Jul 2026 11:47:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2E0FE10E8FA; Mon, 6 Jul 2026 11:47:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=lankhorst.se header.i=@lankhorst.se header.b="M+4L+ymG"; dkim-atps=neutral Received: from lankhorst.se (unknown [141.105.120.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id B9EE310E336; Mon, 6 Jul 2026 11:47:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lankhorst.se; s=default; t=1783338465; bh=Oh1os3TsHNdW2Pq4AI0gYhWG24uRvSoJ0dx3b6zoRio=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M+4L+ymGabR91aKo0056F7egC/KOI6Id8ZkxK4ETjHbXoJErJ0TDdAV+oJYmNL8WO lB6pCKdBasAs7QHQ9U42TSIz0fY1ZMZOQPB2bRXD/zqeVZlagCKjWL2eh1yvfTSaqf /YnzpSTsEUDwuOgFd69ETuqEpOwhFwNvCjoiEVRNaZafC7FXaLlx7+eDX2x7P/fKbD eazofMO1FlWXXYNR1nueZx/wHi5+55KOTfYJDB/WyqhBn8jqOSJ0/7jaT9jFUHvJgQ nV2/vEpd8kthftb2KOt+vkvq7tuFnxXjw7HC/2RxOegMQSKf+80seEbaPgZ6OQRxoP oWbNbtQmTKCkQ== From: Maarten Lankhorst To: intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, Sebastian Andrzej Siewior , Maarten Lankhorst , Tvrtko Ursulin , Maarten Lankhorst Subject: [PATCH v4 2/7] drm/i915: Drop the irqs_disabled() check Date: Mon, 6 Jul 2026 13:48:18 +0200 Message-ID: <20260706114823.752313-3-dev@lankhorst.se> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706114823.752313-1-dev@lankhorst.se> References: <20260706114823.752313-1-dev@lankhorst.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Sebastian Andrzej Siewior The !irqs_disabled() check triggers on PREEMPT_RT even with i915_sched_engine::lock acquired. The reason is the lock is transformed into a sleeping lock on PREEMPT_RT and does not disable interrupts. There is no need to check for disabled interrupts. The lockdep annotation below already check if the lock has been acquired by the caller and will yell if the interrupts are not disabled. Remove the !irqs_disabled() check. Reported-by: Maarten Lankhorst Acked-by: Tvrtko Ursulin Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_request.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index d2c7b1090df08..f66f8efc70629 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -610,7 +610,6 @@ bool __i915_request_submit(struct i915_request *request) RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* @@ -719,7 +718,6 @@ void __i915_request_unsubmit(struct i915_request *request) */ RQ_TRACE(request, "\n"); - GEM_BUG_ON(!irqs_disabled()); lockdep_assert_held(&engine->sched_engine->lock); /* -- 2.53.0