From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v1] hwmon: (acpi_power_meter) Stop setting acpi_device_name/class()
Date: Mon, 06 Jul 2026 12:39:53 +0000 [thread overview]
Message-ID: <20260706123953.9DA9A1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <2297496.irdbgypaU6@rafael.j.wysocki>
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> The driver populates acpi_device_name() and acpi_device_class() that are
> never read afterward, so make it stop doing that and drop the symbols
> defined for this purpose.
>
> Since ACPI_POWER_METER_CLASS is also used for generating ACPI netlink
> events, use the "pwr_meter_resource" string literal directly instead of
> it for that.
>
> No intentional functional impact.
>
> This will facilitate the removal of device_name and device_class from
> struct acpi_device_pnp in the future.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/2297496.irdbgypaU6@rafael.j.wysocki?part=1
next prev parent reply other threads:[~2026-07-06 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:35 [PATCH v1] hwmon: (acpi_power_meter) Stop setting acpi_device_name/class() Rafael J. Wysocki
2026-07-06 12:39 ` sashiko-bot [this message]
2026-07-06 13:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706123953.9DA9A1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.