From: sashiko-bot@kernel.org
To: "Monish Chunara" <monish.chunara@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH V3 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD
Date: Mon, 06 Jul 2026 14:20:35 +0000 [thread overview]
Message-ID: <20260706142035.864841F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260706141346.4180348-5-mchunara@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] A trailing blank line was added at the end of the file.
--
commit 6ff53b628acc8752d158af919047602ffbc82460
Author: Monish Chunara <monish.chunara@oss.qualcomm.com>
arm64: dts: qcom: Enable SD card for Glymur CRD
This commit enables the SD card for the Glymur CRD platform by configuring
the vmmc/vqmmc regulators and setting up gpio-based card detection.
> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
> index c98dfb3941fa3..48407e47aaca2 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
[ ... ]
> @@ -427,3 +450,4 @@ &usb_mp_qmpphy1 {
>
> status = "okay";
> };
> +
[Severity: Low]
This isn't a bug, but it looks like a trailing blank line was added at the
end of the file here. Should this be removed to keep standard coding style
and avoid warnings from tools like git diff --check?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706141346.4180348-1-mchunara@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-07-06 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 14:13 [PATCH V3 0/4] arm64: dts: qcom: Add SD card support for Glymur Monish Chunara
2026-07-06 14:13 ` [PATCH V3 1/4] arm64: dts: qcom: glymur-crd: Update VREG l2b_e0 and l9b_e0 voltage for SD-card Monish Chunara
2026-07-06 14:13 ` [PATCH V3 2/4] dt-bindings: mmc: sdhci-msm: Document the Glymur compatible Monish Chunara
2026-07-08 6:48 ` Krzysztof Kozlowski
2026-07-06 14:13 ` [PATCH V3 3/4] arm64: dts: qcom: Add SD Card support for Glymur SoC Monish Chunara
2026-07-06 14:13 ` [PATCH V3 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD Monish Chunara
2026-07-06 14:20 ` sashiko-bot [this message]
2026-07-15 10:14 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706142035.864841F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=monish.chunara@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.