From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Longlong Xia <xialonglong2025@163.com>
Cc: Takashi Iwai <tiwai@suse.com>, linux-sound@vger.kernel.org
Subject: Re: [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes
Date: Mon, 6 Jul 2026 23:39:58 +0900 [thread overview]
Message-ID: <20260706143958.GA168076@sakamocchi.jp> (raw)
In-Reply-To: <20260706032639.273929-1-xialonglong2025@163.com>
Hi,
On Mon, Jul 06, 2026 at 12:26:39PM +0900, Longlong Xia wrote:
> The ALSA FireWire driver headers include <linux/firewire.h>, which
> already provides struct ieee1394_device_id via
> <linux/device-id/ieee1394.h>.
>
> Drop the now-redundant direct <linux/mod_devicetable.h> includes
> from the per-device headers.
>
> Signed-off-by: Longlong Xia <xialonglong2025@163.com>
> ---
> sound/firewire/bebob/bebob.h | 1 -
> sound/firewire/dice/dice.h | 1 -
> sound/firewire/digi00x/digi00x.h | 1 -
> sound/firewire/fireface/ff.h | 1 -
> sound/firewire/fireworks/fireworks.h | 1 -
> sound/firewire/motu/motu.h | 1 -
> sound/firewire/oxfw/oxfw.h | 1 -
> sound/firewire/tascam/tascam.h | 1 -
> 8 files changed, 8 deletions(-)
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Iwai-san, this patch should be applied to the tree which includes a
commit ecca1d63c1ea "Replace <linux/mod_devicetable.h> by more specific
<linux/device-id/*.h> (headers)" in v7.2-rc2. I would ask you to apply
it to your for-linus branch and send it for -rc3.
Thanks
Takashi Sakamoto
next prev parent reply other threads:[~2026-07-06 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 3:26 [PATCH] ALSA: firewire: Drop redundant mod_devicetable.h includes Longlong Xia
2026-07-06 14:39 ` Takashi Sakamoto [this message]
2026-07-07 14:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706143958.GA168076@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=linux-sound@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=xialonglong2025@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.