From: sashiko-bot@kernel.org
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] Documentation: Update after split of <linux/mod_devicetable.h>
Date: Mon, 06 Jul 2026 15:13:04 +0000 [thread overview]
Message-ID: <20260706151304.D44521F000E9@smtp.kernel.org> (raw)
In-Reply-To: <ede7ce64f20e10660ebf6bc1b41836dad750ae3b.1783349758.git.ukleinek@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The kernel-doc for the ACPI_DEVICE_CLASS macro is lost because include/linux/device-id/acpi.h is omitted from the new explicit header list in basics.rst.
--
commit c40d3b75cc5cb1e55623d0db318301a1e8676b9b
Author: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
Documentation: Update after split of <linux/mod_devicetable.h>
Most structs that were defined in include/linux/mod_devicetable.h before were
moved to a bus specific header. This commit follows the movement to get the
documentation back by using an explicit list of per-subsystem headers.
> diff --git a/Documentation/driver-api/basics.rst b/Documentation/driver-api/basics.rst
> index 8b6a5888cb11d..647e14254cfb8 100644
> --- a/Documentation/driver-api/basics.rst
> +++ b/Documentation/driver-api/basics.rst
> @@ -10,9 +10,36 @@ Driver Entry and Exit points
> Driver device table
> -------------------
>
> -.. kernel-doc:: include/linux/mod_devicetable.h
> +.. kernel-doc:: include/linux/device-id/amba.h
> + :internal:
[Severity: Low]
Does this new explicit list of headers miss include/linux/device-id/acpi.h?
It appears that leaving it out drops the kernel-doc for the ACPI_DEVICE_CLASS
macro from the generated documentation.
> +.. kernel-doc:: include/linux/device-id/cdx.h
> + :internal:
--
Sashiko AI review · https://sashiko.dev/#/patchset/ede7ce64f20e10660ebf6bc1b41836dad750ae3b.1783349758.git.ukleinek@kernel.org?part=1
prev parent reply other threads:[~2026-07-06 15:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 15:01 [PATCH v2] Documentation: Update after split of <linux/mod_devicetable.h> Uwe Kleine-König (The Capable Hub)
2026-07-06 15:13 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706151304.D44521F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.