From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24F623905EA for ; Mon, 6 Jul 2026 15:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783351841; cv=none; b=rjWSAsv65PX/SW2MgwoWvZR5yuotdgDh52YcEgfb05kcGO+E9q4aT+jgyXah+miL4tVHIg7H4cSI7DjrODulUHfJBVQijOspQYQr/f9MQmAxOHZ0qJ/ItgJfc4P0Y4nV9ItnyJQipbtVe7moN2Tjts05puVpdllYmEFzGSfI/5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783351841; c=relaxed/simple; bh=ZR3LA4anilcaggNo+I6EadE+x9RvKiaumZybpeHR+40=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GNoQuWrCfyXVeD+nbh0pA4AnCkDADGoZgyotU5z9JsjAH77cwG3MRx/k70nzuutQLUuBqEVj5ySLzto5d1t8H+nodR9qGZqqCkE95XzmAYoyV7gJ79Ig8jept8/dIayX1ij+X7uyB8zZGD7QzziTgeLpwI8uqG0vwkTemgivdM8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pbLOu0So; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pbLOu0So" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8479f1a86ecso2128912b3a.1 for ; Mon, 06 Jul 2026 08:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783351839; x=1783956639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=S8J+ABJmqKUknTKUb5C8LYheVifRDzKn3aTiLDOk7Io=; b=pbLOu0SoV6Y/wxXFNvw6iADwx6yDi4VEWLi+qz4vWcPlkT2+xInLeiVmO2AjFoSnk7 fH0/exJ+ktoUzfzJFO6YkJcYlKK9EhlX/ExO6/yaxvIB9ps5KJmNm4o11LwczgJ8mHzs r+5KQ4Cts0ep+q0MZEXpBKXyW1Mz+AWms8QT2CcqfUwXgLEWG6ioBHf7LsxefS06mzaw vxV+gprkJtlrespMw7b7rzR1XqKMBbA2/dDFoAY9sN0rAwL1TzrX7WwG07cSjAmg/t1F xPnkic+pNmEEGhSTu0K8rA+E2SGtWGeddxwPzmH5qS5w4Rp+SnRylsjrJx9JkrPTkKy5 h3ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783351839; x=1783956639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S8J+ABJmqKUknTKUb5C8LYheVifRDzKn3aTiLDOk7Io=; b=ObZsXrDwoa6SySacLz50+TceeyFXEcHzwHqYlJPf0lZRZhS30u0YV7CMKlAEhKfpVL jueKlBm65MQ3371Ge8kT/TwTedhrLlUWvL1jIlfCSWQJQiFU/YTCC2nMjUd5NSfveVgk cE+EIXAluMS1i9CZ+TIJbEXJ2X/97z3ItA7O2QPOniplGpVmni5AkmXOv1qV8UTgEyZo SMYi1beh0ayH9EUfUE26huUNbTknxHozTwavRAfiYcTzD0M7e7/7oBsFAasz6TH3yqAH L3FJT5A5xwKX0S5Br2V+Tkflrq9n3Rn9DnK00csSeOVk1V4WXGrDxKCMTcCsv6bIKXPJ 02EQ== X-Forwarded-Encrypted: i=1; AHgh+RpACtZ5cus2sgqtQ0mV3ooYesMihefwk+Jy/UEnv9E7vpiKaePjgHXlLtt7ZJwyTmDUue1Fj5lCevERVpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxI42SrqaEnvj0WNhP7Vg0uekDpY99ElMrb14yG3gGJEfOeNFeq wypkS9Vj0XHq0Mec68mGWJsmwyW2d8dIe/jbE0YMShCqEYulBfIcA3BH X-Gm-Gg: AfdE7cnBlbmh+Li0tzZlXNadS2osbuwhayooscCL8gdiGur5dm5FH3xy9IXgAtQwXcd kki1PDRNkO8itH3zTNEHUxofSYvZjE+bCgbVt6XG67jMXPJzdh+3FVojEbDz5UQsoXbpDTyiL5e z0QV8SZoBsfJNRgVfcbguiD/8t6UKHKwCMwahOd7Rn0ld+GNVAZjV9g+CRaBpXxL7al95tXZpiE ufs8fWwol+bEHFu7ZBNS1Atf01UQCUoZOCTt2hRYP6+mpq3xpd6rCwmoPjQGMIDamN1PbH3NsPF 7XFet2HXzr0OILKR8vY74nq9Yb2wVl/pN7D9qZKXq4VkU1Fl6fMbclfWg3u/EOxX8h1A8duoteB eLbzFJMKrBGijV2ovk+mtvtRfsRwS6wrkXN2RSM/5g9wZWnAitfQa4BVBE4cRnJn7arW43Sz++f HxbPmL/5+gydvWTQyUktSRvM2Btl2HFSZ6DjePHOf6zMBCJ9AW X-Received: by 2002:a05:6a21:4612:b0:3bf:c126:baf2 with SMTP id adf61e73a8af0-3c08eebb3f9mr1340098637.47.1783351839158; Mon, 06 Jul 2026 08:30:39 -0700 (PDT) Received: from steellegend ([2409:40c4:17a:52b2:cd9a:cdf:1ebc:5649]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f0bb7fe46sm61988548eec.14.2026.07.06.08.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 08:30:38 -0700 (PDT) From: Uday Khare To: Matt Ranostay Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH v2] media: video-i2c: fix kthread error pointer left in kthread_vid_cap on failure Date: Mon, 6 Jul 2026 20:58:33 +0530 Message-ID: <20260706152833.10568-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kthread_run() returns an ERR_PTR on failure, not NULL. When start_streaming() fails, data->kthread_vid_cap is left holding this error pointer instead of being cleared. This causes two subsequent bugs: 1. A future call to start_streaming() sees a non-NULL kthread_vid_cap and returns 0 (success) immediately, without actually starting the capture thread. 2. A call to stop_streaming() checks 'kthread_vid_cap == NULL' which is false for an error pointer, and proceeds to call kthread_stop() on the error pointer, leading to a kernel crash. Fix this by resetting kthread_vid_cap to NULL on failure before jumping to the error path. Fixes: 5cebaac60974 ("media: video-i2c: add video-i2c driver") Signed-off-by: Uday Khare --- v2: Fix Fixes: tag - use correct introducing commit hash (5cebaac60974) instead of the incorrect hash cited in v1. drivers/media/i2c/video-i2c.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/video-i2c.c b/drivers/media/i2c/video-i2c.c index 6b50fb422a61..4811a0489524 100644 --- a/drivers/media/i2c/video-i2c.c +++ b/drivers/media/i2c/video-i2c.c @@ -522,8 +522,12 @@ static int start_streaming(struct vb2_queue *vq, unsigned int count) data->kthread_vid_cap = kthread_run(video_i2c_thread_vid_cap, data, "%s-vid-cap", data->v4l2_dev.name); ret = PTR_ERR_OR_ZERO(data->kthread_vid_cap); - if (!ret) - return 0; + if (ret) { + data->kthread_vid_cap = NULL; + goto error_rpm_put; + } + + return 0; error_rpm_put: pm_runtime_put_autosuspend(dev); -- 2.55.0