From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org,
conor+dt@kernel.org, lee@kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635
Date: Mon, 06 Jul 2026 15:54:00 +0000 [thread overview]
Message-ID: <20260706155401.021DC1F00A3F@smtp.kernel.org> (raw)
In-Reply-To: <20260706-monza-leds-v3-1-37ea8c988363@oss.qualcomm.com>
> The pca9635 supports 16 LED channels, unlike the pca9634 which only
> supports 8. The allOf conditional grouped both chips under a single
> else branch capping reg at a maximum of 7.
>
> Give pca9634 its own if/then block and let pca9635 fall through the
> else branch with the correct maximum of 15.
>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-monza-leds-v3-0-37ea8c988363@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-06 15:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 15:49 [PATCH v3 0/4] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-07-06 15:49 ` [PATCH v3 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Loic Poulain
2026-07-06 15:54 ` sashiko-bot [this message]
2026-07-06 15:49 ` [PATCH v3 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-07-06 15:54 ` sashiko-bot
2026-07-06 16:56 ` Conor Dooley
2026-07-07 9:03 ` Loic Poulain
2026-07-07 16:19 ` Conor Dooley
2026-07-06 15:49 ` [PATCH v3 3/4] leds: pca963x: add multicolor LED class support Loic Poulain
2026-07-06 16:04 ` sashiko-bot
2026-07-06 15:49 ` [PATCH v3 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-07-06 15:57 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706155401.021DC1F00A3F@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.