From: Jonathan Cameron <jic23@kernel.org>
To: Maxwell Doose <m32285159@gmail.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list),
"Guenter Roeck" <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver
Date: Mon, 6 Jul 2026 16:53:34 +0100 [thread overview]
Message-ID: <20260706165334.69846485@jic23-huawei> (raw)
In-Reply-To: <20260704205717.137c506e@linuxescape>
On Sat, 4 Jul 2026 20:57:17 -0500
Maxwell Doose <m32285159@gmail.com> wrote:
> On Sun, 5 Jul 2026 00:00:53 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Sat, 4 Jul 2026 14:45:03 -0500
> > Maxwell Doose <m32285159@gmail.com> wrote:
> >
> > > Hi Jonathan,
> > >
> > > On Fri, 3 Jul 2026 01:05:32 +0100
> > > Jonathan Cameron <jic23@kernel.org> wrote:
> > >
> > > > On Sat, 20 Jun 2026 19:46:24 -0500
> > > > Maxwell Doose <m32285159@gmail.com> wrote:
> > > >
> > > > > Add a driver for the Sensirion STS30 family of temperature sensor
> > > > > drivers over I2C. The STS30 family of sensors includes the STS30, STS31,
> > > > > and STS35, all of which are supported by this driver, since they all
> > > > > share the same commands, etc. and only differ in accuracy and tolerance.
> > > > >
> > > > > The driver currently supports single-shot non-clock stretched readings,
> > > > > by using a specified delay based on the repeatability/delay specified
> > > > > by the user. The repeatability/delay can be changed at any time through
> > > > > sysfs.
> > > > >
> > > > > Additionally add Kconfig and Makefile entries for the driver as well as
> > > > > a MAINTAINERS entry.
> > > > >
> > > > > Signed-off-by: Maxwell Doose <m32285159@gmail.com>
> > > >
> > > > Big question first. Why IIO? These are fairly basic temperature sensors
> > > > which typically means hwmon is more appropriate. What does it need
> > > > that hwmon doesn't provide?
> > > >
> > >
> > > The datasheet says that the STS30 supports continuous reads which means
> > > that we can read it into a triggered buffer (which hwmon doesn't
> > > support) and at some point I'd like to implement that.
> >
> > Hmm. For a temperature chip that is often more about the monitors running
> > continuously than the ability to gather signals fast. Temperature changes
> > tend to be fairly slow when it's a physical sensor - gets less obvious when
> > infrared remote sensors are involved.
> >
> > Even more relevant - there is an existing driver I think.
> > See drivers/hwmon/sht3x.c which supports things under the wildcard sts3x as well.
> > Check if that covers this part.
> >
>
> I think the last time I checked the sts30 series wasn't listed in the
> dt-bindings but it may have changed since then. Oh well. I'll still go
> check it out. If it's (very very) similar I would probably consider
> dropping this one, otherwise I'll improve this one and resubmit once I
> get the hardware.
>
Unless that other driver is for a very different part, then it is a non
starter to have a driver in IIO. Perhaps there are features missing in
the hwmon driver though. +CC Guenter and hwmon so they are aware of
this discussion.
thanks,
Jonathan
next prev parent reply other threads:[~2026-07-06 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-21 0:46 [PATCH v2 0/2] iio: temperature: Add support for the STS30 temperature sensor Maxwell Doose
2026-06-21 0:46 ` [PATCH v2 1/2] dt-bindings: iio: temperature: Add STS30 devicetree bindings Maxwell Doose
2026-06-30 15:41 ` Rob Herring (Arm)
2026-07-02 23:36 ` Jonathan Cameron
2026-06-21 0:46 ` [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver Maxwell Doose
2026-06-21 18:33 ` Joshua Crofts
2026-06-22 0:05 ` Maxwell Doose
2026-06-22 0:09 ` Maxwell Doose
2026-07-02 23:31 ` Jonathan Cameron
2026-07-03 6:42 ` Joshua Crofts
2026-07-03 0:05 ` Jonathan Cameron
2026-07-04 19:45 ` Maxwell Doose
2026-07-04 23:00 ` Jonathan Cameron
2026-07-05 1:57 ` Maxwell Doose
2026-07-06 15:53 ` Jonathan Cameron [this message]
2026-07-06 16:03 ` Guenter Roeck
2026-06-22 15:45 ` [PATCH v2 0/2] iio: temperature: Add support for the STS30 temperature sensor David Lechner
2026-06-22 15:51 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260706165334.69846485@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.