Re: [PATCH bpf-next v3 03/15] bpf: Add bpf_struct_ops accessor helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function `bpf_struct_ops_kdata_map_id` is declared in `include/linux/bpf.h` but its implementation is missing.
--

commit 95521f3bc40fc850e1847bcb5fd4b12e698ebe45
Author: Martin KaFai Lau <martin.lau@kernel.org>

bpf: Add bpf_struct_ops accessor helpers

This commit adds helper functions in bpf_struct_ops.c for the upcoming
patch to create a struct_ops to cgroup attachment link. It also exposes
existing validation logic as new helper functions.

> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index 91b8479121fa3..1a1e8d0885c8e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -2252,6 +2252,12 @@ u32 bpf_struct_ops_id(const void *kdata);
>  int bpf_struct_ops_for_each_prog(const void *kdata,
>  				 int (*cb)(struct bpf_prog *prog, void *data),
>  				 void *data);
> +void *bpf_struct_ops_map_kdata(struct bpf_map *map);
> +u32 bpf_struct_ops_kdata_map_id(void *kdata);

[Severity: Low]
Is the implementation for bpf_struct_ops_kdata_map_id() missing? 

The prototype is added here and a dummy version is provided for the 
non-CONFIG_NET case further down in this file, but there doesn't appear to be 
an actual definition in kernel/bpf/bpf_struct_ops.c. This would cause a linker 
error if the function were called.

> +void *bpf_struct_ops_map_cfi_stubs(struct bpf_map *map);
> +bool bpf_struct_ops_valid_to_reg(struct bpf_map *map);
> +int bpf_struct_ops_link_update_check(struct bpf_map *new_map, struct bpf_map *old_map,
> +				     struct bpf_map *expected_old_map);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706171918.317102-1-ameryhung@gmail.com?part=3