Re: [PATCH v4 2/3] media: iris: Add support for Milos (VPU v2.0)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The devicetree compatible string uses the internal codename 'milos' instead of the SoC name, violating DT naming conventions.
--

--- Patch [2]: [PATCH v4 2/3] media: iris: Add support for Milos (VPU v2.0) ---
commit 70c032abc00c4a3de218f6fa34ded1b140a7719c
Author: Alexander Koskovich <akoskovich@pm.me>

media: iris: Add support for Milos (VPU v2.0)

This commit adds support for the Milos Iris codec. It targets the variant
found on the SM7635-AB which has half of its pipes disabled.

> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c
> index c2dcb50a27824..353cda58514c2 100644
> --- a/drivers/media/platform/qcom/iris/iris_probe.c
> +++ b/drivers/media/platform/qcom/iris/iris_probe.c
> @@ -360,6 +360,10 @@ static const struct dev_pm_ops iris_pm_ops = {
>  };
>  
>  static const struct of_device_id iris_dt_match[] = {
> +	{
> +		.compatible = "qcom,milos-iris",

[Severity: Low]
This isn't a bug, but should the compatible string in iris_dt_match[] use the
SoC identifier (e.g., "qcom,sm7635-iris") instead of the internal codename
"milos"? 

Using codenames violates standard devicetree naming conventions for Qualcomm
blocks and creates a non-standard ABI that is difficult to deprecate once
merged.

> +		.data = &milos_data,
> +	},
>  	{
>  		.compatible = "qcom,qcs8300-iris",
>  		.data = &qcs8300_data,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-milos-iris-v4-0-119cbe0a7262@pm.me?part=2