From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B99BC43458 for ; Mon, 6 Jul 2026 23:02:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgsJH-0001S5-2F; Mon, 06 Jul 2026 19:01:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3rTNMagYKCJ4RGRSQPEMMEJC.AMKOCKS-8PKLMLELS.MPE@flex--titusr.bounces.google.com>) id 1wgsJF-0001Qh-Kw for qemu-arm@nongnu.org; Mon, 06 Jul 2026 19:01:05 -0400 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3rTNMagYKCJ4RGRSQPEMMEJC.AMKOCKS-8PKLMLELS.MPE@flex--titusr.bounces.google.com>) id 1wgsJE-00073c-27 for qemu-arm@nongnu.org; Mon, 06 Jul 2026 19:01:05 -0400 Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-c8894570b58so2500270a12.3 for ; Mon, 06 Jul 2026 16:01:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783378862; x=1783983662; darn=nongnu.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=m/PAM6KHxAEnovgWt0N1vdKaX4s46SRBVL3bS+2xlns=; b=JEpexdLTMkjmI5n6r+gYDB+r2I7PC+tZzis/chga2Z0GlNM1yxj8MRjD6R5OKDM99s lpMPzKfEAPynuRiQKbXclAK7Rd0ACIyTDXhM5Rz77nZPwmd2B7aF1AGBQEIIN+EGzdry ZZIH81ISCwm2+hANOLtqqsW3m+U0sOmhrfQM3n1eNkQYlYUAe2xFYtPtKZAKXAUCyCpP IIrxBlEtSa9a95IyKQBMar6adb2KYw04UuKScmIMqS132eOK0+k4ooRo6nF9pkUqjFCl bYkRFWiPGl/IRpjGp5WCn88V16GEXZOok6eMQ0YByzpZd0d6FpDczaqDsTOZEJn8FP1r VZ1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783378862; x=1783983662; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=m/PAM6KHxAEnovgWt0N1vdKaX4s46SRBVL3bS+2xlns=; b=lzp1LrCiLo+mmFlAgT1dsA32hl2Ery9YQmqoh0kKAY7T4VRuvCTBeT6JhANAQsxd+b wbFL60I61GcbRqXrOEpzlMT5jbEXAbmmKgP1j89XXRp0IJz0JZp0VsRexKxXIT6XMrwm aq1v3ov35mvE7ivXyxu7+hg+GsZ4Pb8/8jeftvAKTGqpsWyU6iaLqq4yLHvL9ZNpoKiG CHgR85BNhWqWxjsehfURFPOIzwGVt+/QBv+ioRBrVEDYinQDvwNCQ7YpFbLmiKvA8wmJ snzqTn9p3O/YQPX5be3YVVBQfBOtaBBm9jlKMgBKX9U4dXiLrOYne/17//r9QjBE6R5Z 3RlA== X-Gm-Message-State: AOJu0YyEZoQ34ySiTaQQb19VpXBIs2y4cTY0LJKBV9hVRFa4E6XMD/gQ N/DK+Ap4YIUSFFuP3ou/KV5xZThv8H9b8W9K2mbY74hqQX4YBHrNBIVFfVkWazTD1j67vywOROU m5x2GHQ== X-Received: from dyaz13-n2.prod.google.com ([2002:a05:693c:638d:20b0:30f:1818:9ce5]) (user=titusr job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:b94:b0:3c0:9c19:b272 with SMTP id adf61e73a8af0-3c09c19b393mr159280637.64.1783378861604; Mon, 06 Jul 2026 16:01:01 -0700 (PDT) Date: Mon, 6 Jul 2026 23:00:51 +0000 In-Reply-To: <20260706230056.1888992-1-titusr@google.com> Mime-Version: 1.0 References: <20260706230056.1888992-1-titusr@google.com> X-Mailer: git-send-email 2.55.0.rc2.803.g1fd1e6609c-goog Message-ID: <20260706230056.1888992-3-titusr@google.com> Subject: [PATCH 2/5] hw/i2c: pmbus: add milliunits linear mode functions From: Titus Rwantare To: peter.maydell@linaro.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kfting@nuvoton.com, imaginos32@gmail.com, wuhaotsh@google.com, philmd@mailo.com, Titus Rwantare Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::54a; envelope-from=3rTNMagYKCJ4RGRSQPEMMEJC.AMKOCKS-8PKLMLELS.MPE@flex--titusr.bounces.google.com; helo=mail-pg1-x54a.google.com X-Spam_score_int: -94 X-Spam_score: -9.5 X-Spam_bar: --------- X-Spam_report: (-9.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FUZZY_MILLION=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Because we are limited by unsigned ints, we need to be able to provide inputs in milliunits which can get scaled up to fit in the linear mode registers. For example: 3.4 is a valid input, and now we can provide 3400 and scale it into the register without losing the 0.4 Signed-off-by: Titus Rwantare --- hw/i2c/pmbus_device.c | 39 +++++++++++++++++++++++++++++++++++ include/hw/i2c/pmbus_device.h | 18 ++++++++++++++++ 2 files changed, 57 insertions(+) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index b1f9843f52..e2e1e0e945 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -8,6 +8,7 @@ #include "qemu/osdep.h" #include +#include #include "hw/i2c/pmbus_device.h" #include "migration/vmstate.h" #include "qemu/module.h" @@ -38,6 +39,25 @@ uint16_t pmbus_data2linear_mode(uint16_t value, int exp) return value >> exp; } +uint16_t pmbus_milliunits2linear_mode(uint32_t value, int exp) +{ + uint32_t ret; + + /* L = D * 2^(-e) */ + if (exp < 0) { + ret = DIV_ROUND_CLOSEST((value << (-exp)), 1000); + } else { + ret = DIV_ROUND_CLOSEST((value >> exp), 1000); + } + + /* clamp value to maximum if it exceeds representable value*/ + if (ret > UINT16_MAX) { + return UINT16_MAX; + } + + return ret; +} + uint16_t pmbus_linear_mode2data(uint16_t value, int exp) { /* D = L * 2^e */ @@ -47,6 +67,25 @@ uint16_t pmbus_linear_mode2data(uint16_t value, int exp) return value << exp; } +uint32_t pmbus_linear_mode2milliunits(uint16_t value, int exp) +{ + /* D = L * 2^e */ + uint64_t v = (uint64_t)value; + uint64_t ret; + + if (exp < 0) { + ret = (v * 1000) >> (-exp); + } else { + ret = (v << exp) * 1000; + } + + if (ret > UINT32_MAX) { + return UINT32_MAX; + } + + return (uint32_t)ret; +} + void pmbus_send(PMBusDevice *pmdev, const uint8_t *data, uint16_t len) { if (pmdev->out_buf_len + len > SMBUS_DATA_MAX_LEN) { diff --git a/include/hw/i2c/pmbus_device.h b/include/hw/i2c/pmbus_device.h index f195c11384..9f3569e997 100644 --- a/include/hw/i2c/pmbus_device.h +++ b/include/hw/i2c/pmbus_device.h @@ -481,6 +481,15 @@ uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value); */ uint16_t pmbus_data2linear_mode(uint16_t value, int exp); +/** + * Convert milliunit sensor value to linear mode format + * + * L = D * 2^(-e) + * + * @return uint16 + */ +uint16_t pmbus_milliunits2linear_mode(uint32_t value, int exp); + /** * Convert linear mode formatted data into sensor reading * @@ -490,6 +499,15 @@ uint16_t pmbus_data2linear_mode(uint16_t value, int exp); */ uint16_t pmbus_linear_mode2data(uint16_t value, int exp); +/** + * Convert linear mode formatted data into sensor reading in milliunits + * + * D = L * 2^e + * + * @return uint32 value in milliunits + */ +uint32_t pmbus_linear_mode2milliunits(uint16_t value, int exp); + /** * @brief Send a block of data over PMBus * Assumes that the bytes in the block are already ordered correctly, -- 2.55.0.rc2.803.g1fd1e6609c-goog