Re: [PATCH v7 1/5] dt-bindings: iio: add Open Sensor Fusion device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Device Tree binding intentionally omits the specific hardware product identity, restricting the `compatible` property to a generic protocol-level string.
--

--- Patch [1]: [PATCH v7 1/5] dt-bindings: iio: add Open Sensor Fusion device ---
commit 427a1ffc9a3a61dc0d7c28ad4dfc48f800f94f69
Author: Jinseob Kim <kimjinseob88@gmail.com>

dt-bindings: iio: add Open Sensor Fusion device

This commit introduces a binding for the generic Open Sensor Fusion host
interface. It specifies that sensor channels and protocol versions are
discovered at runtime, and sets the compatible string to a generic protocol
identifier.

> diff --git a/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml
> new file mode 100644
> index 0000000000000..3998390828cc0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/opensensorfusion,osf.yaml
[ ... ]
> +allOf:
> +  - $ref: /schemas/serial/serial-peripheral-props.yaml#
> +
> +properties:
> +  compatible:
> +    const: opensensorfusion,osf

[Severity: Medium]
Will omitting the specific hardware identity prevent the kernel from applying
hardware-specific quirks in the future?

The commit message notes that OSF GREEN is a product identity and intentionally
omitted from the compatible string. However, device trees are expected to
describe specific hardware, not just the generic protocol it speaks.

If the specific hardware requires workarounds in the future, such as power
sequencing adjustments, delays before the protocol responds, or errata
handling, the kernel will have no way to apply them because the device tree
only identifies it as a generic device.

Could the binding be updated to allow specific hardware compatible strings
alongside the generic fallback, rather than restricting it to a single const
value?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707014525.1015-1-kimjinseob88@gmail.com?part=1