From: Greg KH <gregkh@linuxfoundation.org>
To: Anirban Bose <boses156@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename camelcase variable bAllow
Date: Tue, 7 Jul 2026 12:16:16 +0200 [thread overview]
Message-ID: <2026070702-murkiness-upfront-3082@gregkh> (raw)
In-Reply-To: <20260524142309.88007-1-boses156@gmail.com>
On Sun, May 24, 2026 at 07:53:09PM +0530, Anirban Bose wrote:
> Rename the local variable 'bAllow' to 'allow' in rtw_cmd_filter() to fix
> a checkpatch CamelCase warning.
>
> Signed-off-by: Anirban Bose <boses156@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index b932670f5d63..aa4a810d8322 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -299,12 +299,12 @@ void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
> int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
> int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
> {
> - u8 bAllow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
> + u8 allow = false; /* set to true to allow enqueuing cmd when hw_init_completed is false */
Why isn't this converted to a boolean at the same time?
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-07 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 14:23 [PATCH] staging: rtl8723bs: rename camelcase variable bAllow Anirban Bose
2026-07-07 10:16 ` Greg KH [this message]
2026-07-08 6:19 ` [PATCH v2] " Anirban Bose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070702-murkiness-upfront-3082@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=boses156@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.