From: sashiko-bot@kernel.org
To: "Krishna Kurapati" <krishna.kurapati@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: kaanapali-qrd: Add PMIC Glink node
Date: Tue, 07 Jul 2026 05:18:19 +0000 [thread overview]
Message-ID: <20260707051820.1DF181F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260707-kaanapali-pmic-glink-v1-2-3f7d476672d9@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `&usb` node lacks the `usb-role-switch` property, causing the DWC3 controller to silently fall back to peripheral mode and breaking Type-C dual-role functionality.
--
--- Patch [2]: [PATCH 2/2] arm64: dts: qcom: kaanapali-qrd: Add PMIC Glink node ---
commit 904c19a1a664815102c7af84e0fb9891b1a979d7
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
arm64: dts: qcom: kaanapali-qrd: Add PMIC Glink node
Add PMIC Glink node on Kaanapali QRD Platform and add remote-endpoint
linkages to DWC3 controller and QMP phy respectively.
> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> index 55d02219ef4e9..a79ae73acf0de 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
[ ... ]
> @@ -823,8 +866,6 @@ &ufs_mem_phy {
> };
>
> &usb {
> - dr_mode = "peripheral";
> -
> status = "okay";
> };
[Severity: Medium]
Does removing dr_mode = "peripheral" without adding the usb-role-switch
property cause the DWC3 controller to silently fall back to peripheral mode?
During boot, when dwc3_get_dr_mode() initializes the DWC3 core driver,
omitting both dr_mode and the usb-role-switch property causes the driver
to fall back to USB_DR_MODE_PERIPHERAL and skip registering a USB role switch
device.
Because of this, does the PMIC GLINK Type-C driver fail to acquire the role
switch handle via the endpoint graph, breaking the intended Type-C dual-role
functionality?
Should the usb-role-switch property be added to this node to allow the
registration of the USB role switch?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707-kaanapali-pmic-glink-v1-0-3f7d476672d9@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-07 5:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 5:07 [PATCH 0/2] Enable PMIC Glink nodes on Kaanapali Krishna Kurapati
2026-07-07 5:07 ` [PATCH 1/2] arm64: dts: qcom: kaanapali-mtp: Add PMIC Glink node Krishna Kurapati
2026-07-07 5:21 ` sashiko-bot
2026-07-07 5:07 ` [PATCH 2/2] arm64: dts: qcom: kaanapali-qrd: " Krishna Kurapati
2026-07-07 5:18 ` sashiko-bot [this message]
2026-07-13 15:06 ` [PATCH 0/2] Enable PMIC Glink nodes on Kaanapali Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707051820.1DF181F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.