All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Avihai Horon" <avihaih@nvidia.com>, "Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 21/27] migration: Fix "switchover" used as a verb in comments and docs
Date: Tue,  7 Jul 2026 08:29:14 +0200	[thread overview]
Message-ID: <20260707062920.317302-22-clg@redhat.com> (raw)
In-Reply-To: <20260707062920.317302-1-clg@redhat.com>

From: Avihai Horon <avihaih@nvidia.com>

"Switchover" is a noun; the verb form is "switch over".  Replace all
instances where "switchover" was incorrectly used as a verb in comments
and documentation.

Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/qemu-devel/20260706085211.13905-17-avihaih@nvidia.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 qapi/migration.json   | 4 ++--
 migration/migration.h | 6 +++---
 migration/migration.c | 4 ++--
 migration/savevm.c    | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index d2f42c4b0ffd0a9e6bb757b8d105fed89b423537..66bd900465a2d757baf863baa0937a18b4585d2a 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -509,7 +509,7 @@
 #
 # @switchover-ack: If enabled, migration will not stop the source VM
 #     and complete the migration until the destination has
-#     acknowledged that it is OK to switchover.  The acknowledgement
+#     acknowledged that it is OK to switch over.  The acknowledgement
 #     may depend, for example, on some device's data being loaded in
 #     the destination before doing switchover.  This can reduce
 #     downtime if devices that support this capability are present.
@@ -919,7 +919,7 @@
 #     migration can use during switchover phase, in bytes per
 #     second.  **Note:** this does not limit the bandwidth during
 #     switchover, but only for calculations when making decisions to
-#     switchover.  By default, this value is zero, which means QEMU
+#     switch over.  By default, this value is zero, which means QEMU
 #     will estimate the bandwidth automatically.  This can be set
 #     when the estimated value is not accurate, while the user is
 #     able to guarantee such bandwidth is available when switching
diff --git a/migration/migration.h b/migration/migration.h
index 44bce199cd8c3518998ad7204d599566d1ef9ddd..631421c784bc1cee7073ff6ff0011188fc810592 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -496,12 +496,12 @@ struct MigrationState {
      * migration progresses, the devices on the destination acknowledge
      * switchover, decreasing the counter. When the counter reaches zero, a
      * single ACK message is sent to the source via the return path, indicating
-     * that it's OK to switchover.
+     * that it's OK to switch over.
      *
      * In new switchover-ack, the source is the one that keeps track of a
      * pending ACKs counter. As migration progresses, the destination sends ACK
      * message per-device via the return path, which decrements the source
-     * counter. When the counter reaches zero, it's OK to switchover. During
+     * counter. When the counter reaches zero, it's OK to switch over. During
      * precopy, source-side devices may request additional ACKs, which increment
      * the counter again.
      *
@@ -521,7 +521,7 @@ struct MigrationState {
     /*
      * Indicates the number of pending ACKs from the destination. The value may
      * increase or decrease during precopy as new ACKs are requested or
-     * received. When zero is reached, it's OK to switchover. In legacy
+     * received. When zero is reached, it's OK to switch over. In legacy
      * switchover-ack, it's initialized to 1 and decreased to zero upon ACK.
      */
     uint32_t switchover_ack_pending_num;
diff --git a/migration/migration.c b/migration/migration.c
index 7d5acd93c32393c9611731ab153b23f4bbc826a3..9736c14458b9eb87e14ac242e7aff0c6b5bf6900 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3293,7 +3293,7 @@ static bool migration_iteration_next_ready(MigrationState *s,
                                            MigPendingData *pending)
 {
     /*
-     * If the estimated values already suggest us to switchover, mark this
+     * If the estimated values already suggest us to switch over, mark this
      * iteration finished, time to do a slow sync.
      */
     if (pending->total_bytes <= s->threshold_size) {
@@ -3418,7 +3418,7 @@ static MigIterateState migration_iteration_run(MigrationState *s)
             migration_iteration_go_next(s, &pending);
         }
 
-        /* Check can switchover after qemu_savevm_query_pending() */
+        /* Check if we can switch over after qemu_savevm_query_pending() */
         can_switchover = migration_can_switchover(s);
 
         /* Should we switch to postcopy now? */
diff --git a/migration/savevm.c b/migration/savevm.c
index bbb8d2b47c6452b228c67cbbdaacc7c333985be7..34dd06f9f732dee7d3c6d0458da8bb67f23d76b4 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -2509,7 +2509,7 @@ static int loadvm_postcopy_handle_switchover_start(Error **errp)
 
 /*
  * If legacy switchover-ack is enabled but no device uses it, need to send an
- * ACK to source that it's OK to switchover.
+ * ACK to source that it's OK to switch over.
  */
 static int loadvm_switchover_ack_no_users_legacy(MigrationIncomingState *mis,
                                                  Error **errp)
-- 
2.54.0



  parent reply	other threads:[~2026-07-07  6:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  6:28 [PULL 00/27] vfio queue Cédric Le Goater
2026-07-07  6:28 ` [PULL 01/27] vfio/pci: Initialize rom_read_failed in vfio_pci_load_rom() Cédric Le Goater
2026-07-07  6:28 ` [PULL 02/27] vfio/pci: Fix information leak in vfio_rom_read() Cédric Le Goater
2026-07-07  6:28 ` [PULL 03/27] docs: Update vfio-user spec to describe DMA access mode bits Cédric Le Goater
2026-07-07  6:28 ` [PULL 04/27] vfio-user: validate VERSION replies Cédric Le Goater
2026-07-07  6:28 ` [PULL 05/27] vfio/iommufd: Merge .dma_map_file() into .dma_map() Cédric Le Goater
2026-07-07  6:28 ` [PULL 06/27] migration: Propagate errors in migration_completion_precopy() Cédric Le Goater
2026-07-07  6:29 ` [PULL 07/27] migration/ram: Use migration_bitmap_sync_precopy() for postcopy discard Cédric Le Goater
2026-07-07  6:29 ` [PULL 08/27] migration: Run final save_query_pending at switchover Cédric Le Goater
2026-07-07  6:29 ` [PULL 09/27] migration: Log the approver in qemu_loadvm_approve_switchover() Cédric Le Goater
2026-07-07  6:29 ` [PULL 10/27] migration: Replace switchover_ack_needed SaveVMHandler Cédric Le Goater
2026-07-07  6:29 ` [PULL 11/27] migration: Rename switchover-ack code to legacy Cédric Le Goater
2026-07-07  6:29 ` [PULL 12/27] migration: Make switchover-ack re-usable Cédric Le Goater
2026-07-07  6:29 ` [PULL 13/27] migration: Fail migration if switchover-ack is requested after switchover decision Cédric Le Goater
2026-07-07  6:29 ` [PULL 14/27] vfio/migration: Extract VFIO_MIG_FLAG_DEV_INIT_DATA_SENT sending to helper Cédric Le Goater
2026-07-07  6:29 ` [PULL 15/27] vfio/migration: Add Error ** parameter to vfio_migration_init() Cédric Le Goater
2026-07-07  6:29 ` [PULL 16/27] vfio/migration: Add new switchover-ack mechanism Cédric Le Goater
2026-07-07  6:29 ` [PULL 17/27] vfio/migration: Implement VFIO_PRECOPY_INFO_REINIT feature Cédric Le Goater
2026-07-07  6:29 ` [PULL 18/27] vfio/migration: Check VFIO_PRECOPY_INFO_REINIT during switchover Cédric Le Goater
2026-07-07  6:29 ` [PULL 19/27] migration: Enable new switchover-ack Cédric Le Goater
2026-07-07  6:29 ` [PULL 20/27] migration: Refactor migration_completion_precopy() to return bool Cédric Le Goater
2026-07-07  6:29 ` Cédric Le Goater [this message]
2026-07-07  6:29 ` [PULL 22/27] iommufd: Introduce handler for device ATS support Cédric Le Goater
2026-07-07  6:29 ` [PULL 23/27] vfio/pci: Add ats property Cédric Le Goater
2026-07-07  6:29 ` [PULL 24/27] vfio/pci: Propagate errors in vfio_pci_load_rom() using Error API Cédric Le Goater
2026-07-07  6:29 ` [PULL 25/27] vfio/listener: Fix translated_addr for non-identity-mapped RAM sections Cédric Le Goater
2026-07-07  6:29 ` [PULL 26/27] backends/iommufd: Fix dev_id and type order in viommu trace Cédric Le Goater
2026-07-07  6:29 ` [PULL 27/27] vfio/pci: Reject invalid MSI-X Table and PBA BIR values Cédric Le Goater
2026-07-08  5:53 ` [PULL 00/27] vfio queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707062920.317302-22-clg@redhat.com \
    --to=clg@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.