Re: [PATCH] tests/functional: use QMP to query available machines

[Thomas Huth <th.huth+qemu@posteo.eu>]

Am Fri, 3 Jul 2026 21:21:11 +0200
schrieb Thomas Huth <th.huth+qemu@posteo.eu>:

> Am Thu, 25 Jun 2026 12:53:10 -0400
> schrieb Ganesh Harshan <ganeshredcobra@gmail.com>:
> 
> > Replace parsing of "qemu -M help" in set_machine() with
> > QMP "query-machines".
> > 
> > The previous approach relied on parsing human-readable CLI
> > output and substring matching, which is fragile and prone to
> > incorrect matches. It is also sensitive to output format changes.
> > 
> > Use QMP instead to retrieve structured machine information,
> > ensuring accurate matching and better maintainability.
> > 
> > Cache the result at the class level to avoid repeated QEMU
> > startup overhead.
> > 
> > Signed-off-by: Ganesh Harshan <ganeshredcobra@gmail.com>
> > ---
> >  tests/functional/qemu_test/testcase.py | 32 +++++++++++++++++++++-----
> >  1 file changed, 26 insertions(+), 6 deletions(-)  
> 
>  Hi Ganesh,
> 
> seems like a bunch of tests are failing when I include this patch in my
> source tree:
> 
> 283/327 qemu:func-thorough+func-riscv64-thorough+thorough / func-riscv64-tuxrun               TIMEOUT         120.01s   killed by signal 15 SIGTERM
> 286/327 qemu:func-thorough+func-mipsel-thorough+thorough / func-mipsel-tuxrun                 TIMEOUT          90.01s   killed by signal 15 SIGTERM
> 289/327 qemu:func-thorough+func-mips-thorough+thorough / func-mips-tuxrun                     TIMEOUT          90.01s   killed by signal 15 SIGTERM
> 294/327 qemu:func-thorough+func-ppc64-thorough+thorough / func-ppc64-e500                     TIMEOUT          90.01s   killed by signal 15 SIGTERM
> 326/327 qemu:func-thorough+func-ppc-thorough+thorough / func-ppc-tuxrun                       TIMEOUT          90.01s   killed by signal 15 SIGTERM
> 327/327 qemu:func-thorough+func-xtensa-thorough+thorough / func-xtensa-lx60                   TIMEOUT          90.01s   killed by signal 15 SIGTERM
> 
> Are these working for you? Could you please have a look?
> 
> > diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> > index eaec1bea13..5920d6a784 100644
> > --- a/tests/functional/qemu_test/testcase.py
> > +++ b/tests/functional/qemu_test/testcase.py
> > @@ -314,14 +314,34 @@ def setUp(self):  
> ...
> > +        if machinename not in self._machines:
> >              self.skipTest('no support for machine ' + machinename)
> > +
> >          self.machine = machinename
> > +        self.vm.set_machine(machinename)  
> 
> The last line was not there before, why is it required now?

I noticed that the tests work fine again when I drop that line. So I'll go
ahead and pick up this patch without this line.

 Thomas