All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Noah Adkins <noahcadkins@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Teddy Wang <teddy.wang@siliconmotion.com>,
	"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>,
	"open list:STAGING SUBSYSTEM" <linux-staging@lists.linux.dev>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: sm750fb: convert camelCase parameters to snake_case
Date: Tue, 7 Jul 2026 11:13:14 +0200	[thread overview]
Message-ID: <2026070710-amusing-gecko-a39f@gregkh> (raw)
In-Reply-To: <20260615012837.90113-2-noahcadkins@gmail.com>

On Sun, Jun 14, 2026 at 09:28:38PM -0400, Noah Adkins wrote:
> Convert the camelCase parameters in the 2D acceleration helper
> prototypes to snake_case to conform to the kernel coding style
> and to make them consistent with the parameter names in the
> corresponding implementations.

But they don't seem to match up with what the .c file says, right?  Why
not?

For example:

>  int sm750_hw_copyarea(struct lynx_accel *accel,
> -		      unsigned int sBase, unsigned int sPitch,
> +		      unsigned int source_base, unsigned int source_pitch,
>  		      unsigned int sx, unsigned int sy,
> -		      unsigned int dBase, unsigned int dPitch,
> +		      unsigned int d_base, unsigned int d_pitch,

"d_base" is "dest_base" in the .c file.

Same for some other variables.

thanks,

greg k-h

      reply	other threads:[~2026-07-07  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-15  1:28 [PATCH] staging: sm750fb: convert camelCase parameters to snake_case Noah Adkins
2026-07-07  9:13 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070710-amusing-gecko-a39f@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=noahcadkins@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.