From: Greg KH <gregkh@linuxfoundation.org>
To: Jeeva Anandh <anandhjeeva215@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: simplify NULL pointer checks in rtw_recv.h
Date: Tue, 7 Jul 2026 13:16:19 +0200 [thread overview]
Message-ID: <2026070713-falcon-drier-1ef3@gregkh> (raw)
In-Reply-To: <20260603091411.21482-1-anandhjeeva215@gmail.com>
On Wed, Jun 03, 2026 at 09:14:11AM +0000, Jeeva Anandh wrote:
> Replace explicit NULL pointer comparisons with idiomatic
> pointer checks to improve readability and follow kernel style.
>
> Signed-off-by: Jeeva Anandh <anandhjeeva215@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/rtw_recv.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/rtw_recv.h b/drivers/staging/rtl8723bs/include/rtw_recv.h
> index 8e45871f07f0..9c32d480a20a 100644
> --- a/drivers/staging/rtl8723bs/include/rtw_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtw_recv.h
> @@ -349,7 +349,7 @@ s32 rtw_recv_entry(union recv_frame *precv_frame);
> static inline u8 *get_rxmem(union recv_frame *precvframe)
> {
> /* always return rx_head... */
> - if (precvframe == NULL)
> + if (!precvframe)
> return NULL;
>
> return precvframe->u.hdr.rx_head;
> @@ -362,7 +362,7 @@ static inline u8 *recvframe_pull(union recv_frame *precvframe, signed int sz)
> /* used for extract sz bytes from rx_data, update rx_data and return the updated rx_data to the caller */
>
>
> - if (precvframe == NULL)
> + if (!precvframe)
> return NULL;
>
>
> @@ -387,7 +387,7 @@ static inline u8 *recvframe_put(union recv_frame *precvframe, signed int sz)
> /* after putting, rx_tail must be still larger than rx_end. */
> unsigned char *prev_rx_tail;
>
> - if (precvframe == NULL)
> + if (!precvframe)
> return NULL;
>
> prev_rx_tail = precvframe->u.hdr.rx_tail;
> @@ -414,7 +414,7 @@ static inline u8 *recvframe_pull_tail(union recv_frame *precvframe, signed int s
> /* used for extract sz bytes from rx_end, update rx_end and return the updated rx_end to the caller */
> /* after pulling, rx_end must be still larger than rx_data. */
>
> - if (precvframe == NULL)
> + if (!precvframe)
> return NULL;
>
> precvframe->u.hdr.rx_tail -= sz;
> --
> 2.43.0
>
>
Does not apply to the tree :(
prev parent reply other threads:[~2026-07-07 11:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 9:14 [PATCH] staging: rtl8723bs: simplify NULL pointer checks in rtw_recv.h Jeeva Anandh
2026-07-07 11:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070713-falcon-drier-1ef3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=anandhjeeva215@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.