All of lore.kernel.org
 help / color / mirror / Atom feed
From: Usama Arif <usama.arif@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>,
	apopple@nvidia.com, baohua@kernel.org,
	baolin.wang@linux.alibaba.com, byungchul@sk.com,
	david@kernel.org, dev.jain@arm.com, gourry@gourry.net,
	jannh@google.com, joshua.hahnjy@gmail.com, lance.yang@linux.dev,
	liam@infradead.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ljs@kernel.org, matthew.brost@intel.com,
	npache@redhat.com, rakie.kim@sk.com, ryan.roberts@arm.com,
	usama.arif@linux.dev, vbabka@kernel.org,
	ying.huang@linux.alibaba.com, ziy@nvidia.com,
	shakeel.butt@linux.dev, hannes@cmpxchg.org
Cc: sashiko-bot <sashiko-bot@kernel.org>
Subject: [PATCH 2/3] mm/madvise: skip device-private PMDs in cold and pageout walks
Date: Tue,  7 Jul 2026 06:45:08 -0700	[thread overview]
Message-ID: <20260707135255.292870-3-usama.arif@linux.dev> (raw)
In-Reply-To: <20260707135255.292870-1-usama.arif@linux.dev>

madvise_cold_or_pageout_pte_range() takes pmd_trans_huge_lock(), whose
pmd_is_huge() check returns true for a device-private PMD. The subsequent
!pmd_present() branch has a VM_BUG_ON() asserting migration is the only
allowed non-present case; a device-private PMD trips it.

Potential trigger: an HMM-based GPU driver races with
madvise(MADV_COLD)/MADV_PAGEOUT: pmd_trans_huge(*pmd) reads true, then
migrate_vma_pages() flips the PMD to a device-private entry before the
PMD lock is acquired.

Skip device-private PMDs after taking the lock, before the !pmd_present()
check.

Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/patchset/20260703173903.3789516-1-usama.arif%40linux.dev?part=6
Fixes: 368076f52ebe ("mm/huge_memory: add device-private THP support to PMD operations")
Signed-off-by: Usama Arif <usama.arif@linux.dev>
---
 mm/madvise.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/madvise.c b/mm/madvise.c
index 9292f60b19aa..870be398c6f3 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -384,6 +384,9 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
 			return 0;
 
 		orig_pmd = *pmd;
+		if (pmd_is_device_private_entry(orig_pmd))
+			goto huge_unlock;
+
 		if (is_huge_zero_pmd(orig_pmd))
 			goto huge_unlock;
 
-- 
2.53.0-Meta



  parent reply	other threads:[~2026-07-07 13:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 13:45 [PATCH 0/3] mm: handle device-private PMDs in walk callbacks Usama Arif
2026-07-07 13:45 ` [PATCH 1/3] mm/mempolicy: skip device-private PMDs when queueing folios Usama Arif
2026-07-07 20:33   ` Zi Yan
2026-07-08 10:54     ` Usama Arif
2026-07-08 15:25       ` Zi Yan
2026-07-07 23:49   ` Balbir Singh
2026-07-07 13:45 ` Usama Arif [this message]
2026-07-07 20:41   ` [PATCH 2/3] mm/madvise: skip device-private PMDs in cold and pageout walks Zi Yan
2026-07-07 23:27   ` Balbir Singh
2026-07-07 13:45 ` [PATCH 3/3] mm/huge_memory: skip device-private PMDs in madvise_free_huge_pmd Usama Arif
2026-07-07 20:44   ` Zi Yan
2026-07-07 23:26   ` Balbir Singh
2026-07-07 14:01 ` [PATCH 0/3] mm: handle device-private PMDs in walk callbacks Lorenzo Stoakes
2026-07-07 14:12   ` Usama Arif
2026-07-08  8:23     ` Lorenzo Stoakes
2026-07-08  8:40       ` Balbir Singh
2026-07-07 15:30   ` Zi Yan
2026-07-07 22:57   ` Balbir Singh
2026-07-08  8:38     ` Lorenzo Stoakes
2026-07-07 19:19 ` Joshua Hahn
2026-07-08 12:22   ` Usama Arif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707135255.292870-3-usama.arif@linux.dev \
    --to=usama.arif@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=byungchul@sk.com \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=jannh@google.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=matthew.brost@intel.com \
    --cc=npache@redhat.com \
    --cc=rakie.kim@sk.com \
    --cc=ryan.roberts@arm.com \
    --cc=sashiko-bot@kernel.org \
    --cc=shakeel.butt@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.