From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1A7383310; Tue, 7 Jul 2026 14:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783433499; cv=none; b=f3sCzK+XkTQvNNZwdELUo8SaqcnEDsRbjjULKDYB7+yJEO/9QUQqAxfpus1bMk5rolxo8WJ7BBkez3WKxmYDP+miZjkkR26gLW+p5DbWxfhsTT9s7WqJLUkQg4/LWHKXp2/R3DlxeQ7IvIQh35ztuPhCbeBPrMAv9ZWf71meJIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783433499; c=relaxed/simple; bh=qKAmug+HfAmeMQQjw4jr6547Icst8f/y+UIGjYKsPiY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=lLybrSHaJXgMw49DJIoTkevyvu7+F5xIVUKYcN2JPbbPRXQlpmCx/WDbv48G3Ck80tLFAuFfg3TZqiK76/9aIHBhTKHYlu516qNgQEGuUH9rO5XX2b/02AtCBgOigPLD4GS9nDNGaWBtYzHC9YvFUPrVK8BBWwsBC2cU0GbOW3A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VVQLAHYL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVQLAHYL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 943421F000E9; Tue, 7 Jul 2026 14:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783433496; bh=nm0y0ggHgyoSIFEw/puAOvt8d3BgJyeQmpoK6IqR2TI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VVQLAHYLitZPOD6hz4ljD9bztAdGMzeyKCguU8ZNikNhGPg/habFh1ZqwmeiwAm8A gU+/FtTNIcwYgbJQDC2+cChk9FmDTdehA+USeLYIoz2r2lc2pkmquvse91dTDknMRT 8Kj+AwMDNQLdjDlBUVQuSdfjqZ+yNBeH0ubpaOgUMbhdsnoAjIsPmNpV5OS/YlMmAd LZtemV3Qiu7TEAdUkDca8k4xKnSkj5+QKj5Ne3I4R+nFp8Mja4joPmjyUp/+abd5VU uCVFtFKt9LvjIkE88bSpbok8vCiS8p6uIpoDtAKr2su1iMfuq+Zo5hA0LEAWTKeNl3 IpNDONfZMLOVg== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v12 1/7] dt-bindings: phy: document the serdes PHY on sa8255p Reply-To: sashiko-reviews@lists.linux.dev To: "Bartosz Golaszewski" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, linux-sunxi@lists.linux.dev, neil.armstrong@linaro.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com, Frank.Li@kernel.org, imx@lists.linux.dev In-Reply-To: <20260706-qcom-sa8255p-emac-v12-1-e3ab1ecf2901@oss.qualcomm.com> References: <20260706-qcom-sa8255p-emac-v12-0-e3ab1ecf2901@oss.qualcomm.com> <20260706-qcom-sa8255p-emac-v12-1-e3ab1ecf2901@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Jul 2026 14:11:35 +0000 Message-Id: <20260707141135.943421F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The `power-domain-names` property lacks a string value constraint, = allowing arbitrary strings to pass validation. -- commit da2d01b0c5abee156fdc9bf1e261e5789a2c6fb7 Author: Bartosz Golaszewski dt-bindings: phy: document the serdes PHY on sa8255p Describe the SGMII/SerDes PHY present on the Qualcomm sa8255p platforms. This is essentially the same hardware as sa8775p rev3 but the PHY is managed by firmware over SCMI. > diff --git a/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgm= ii-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgmi= i-phy.yaml > new file mode 100644 > index 0000000000000..9e846e3815555 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,sa8255p-dwmac-sgmii-phy.= yaml [ ... ] > + power-domains: > + maxItems: 1 > + > + power-domain-names: > + maxItems: 1 [Severity: Low] Does this property need a string value constraint?=20 The current schema limits the array length but allows arbitrary strings to = pass schema validation. Should it include an items list with a const value, such= as const: serdes, to match the usage in the example? > + > + "#phy-cells": > + const: 0 --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260706-qcom-sa825= 5p-emac-v12-0-e3ab1ecf2901@oss.qualcomm.com?part=3D1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B720C44501 for ; Tue, 7 Jul 2026 14:11:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xezUxc/1JfpH7Easm054iT8B7D47hw6b2rtZ+VyqwgU=; b=P6TpkyHDM0JghK B26CCjDnPWQ4kcUbJrUIRSSbNommhdIO9TPW1dO2w14Snc07cA4Neh08k7mtphiQESIcJanKIlVc0 AqWKSp1tVvl8QYD7pJg/LPtMi7vdA22U1IvOgFTs4eW1pHogRPm4HMZNMnhqtD0AfEe3xLO/3GK2V X9rt7zxyCn/dLlBTZup3OligafvAxnK0WCdzqETCuHIlnT6Ru/PGGzcQO0EtOW+GqegvqVFilg5cU NSm42M4syUIIP/0nDL7wPJr/25ZumYtC+1D69FHvlx/sa2PJ3ew2T2gufxiQ/2xejrxfbN4C+OJ4n PYAOW3p5Gwzdw9xGGuZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6WS-0000000F7QS-1JCI; Tue, 07 Jul 2026 14:11:40 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6WP-0000000F7Pg-1gL1 for linux-amlogic@lists.infradead.org; Tue, 07 Jul 2026 14:11:38 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6849460018; Tue, 7 Jul 2026 14:11:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 943421F000E9; Tue, 7 Jul 2026 14:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783433496; bh=nm0y0ggHgyoSIFEw/puAOvt8d3BgJyeQmpoK6IqR2TI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VVQLAHYLitZPOD6hz4ljD9bztAdGMzeyKCguU8ZNikNhGPg/habFh1ZqwmeiwAm8A gU+/FtTNIcwYgbJQDC2+cChk9FmDTdehA+USeLYIoz2r2lc2pkmquvse91dTDknMRT 8Kj+AwMDNQLdjDlBUVQuSdfjqZ+yNBeH0ubpaOgUMbhdsnoAjIsPmNpV5OS/YlMmAd LZtemV3Qiu7TEAdUkDca8k4xKnSkj5+QKj5Ne3I4R+nFp8Mja4joPmjyUp/+abd5VU uCVFtFKt9LvjIkE88bSpbok8vCiS8p6uIpoDtAKr2su1iMfuq+Zo5hA0LEAWTKeNl3 IpNDONfZMLOVg== From: sashiko-bot@kernel.org Subject: Re: [PATCH net-next v12 1/7] dt-bindings: phy: document the serdes PHY on sa8255p To: "Bartosz Golaszewski" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, robh@kernel.org, linux-sunxi@lists.linux.dev, neil.armstrong@linaro.org, conor+dt@kernel.org, wsa+renesas@sang-engineering.com, Frank.Li@kernel.org, imx@lists.linux.dev In-Reply-To: <20260706-qcom-sa8255p-emac-v12-1-e3ab1ecf2901@oss.qualcomm.com> References: <20260706-qcom-sa8255p-emac-v12-0-e3ab1ecf2901@oss.qualcomm.com> <20260706-qcom-sa8255p-emac-v12-1-e3ab1ecf2901@oss.qualcomm.com> Date: Tue, 07 Jul 2026 14:11:35 +0000 Message-Id: <20260707141135.943421F000E9@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIGBwb3dlci1kb21h aW4tbmFtZXNgIHByb3BlcnR5IGxhY2tzIGEgc3RyaW5nIHZhbHVlIGNvbnN0cmFpbnQsIGFsbG93 aW5nIGFyYml0cmFyeSBzdHJpbmdzIHRvIHBhc3MgdmFsaWRhdGlvbi4KLS0KCmNvbW1pdCBkYTJk MDFiMGM1YWJlZTE1NmZkYzliZjFlMjYxZTU3ODlhMmM2ZmI3CkF1dGhvcjogQmFydG9zeiBHb2xh c3pld3NraSA8YmFydG9zei5nb2xhc3pld3NraUBvc3MucXVhbGNvbW0uY29tPgoKZHQtYmluZGlu Z3M6IHBoeTogZG9jdW1lbnQgdGhlIHNlcmRlcyBQSFkgb24gc2E4MjU1cAoKRGVzY3JpYmUgdGhl IFNHTUlJL1NlckRlcyBQSFkgcHJlc2VudCBvbiB0aGUgUXVhbGNvbW0gc2E4MjU1cCBwbGF0Zm9y bXMuClRoaXMgaXMgZXNzZW50aWFsbHkgdGhlIHNhbWUgaGFyZHdhcmUgYXMgc2E4Nzc1cCByZXYz IGJ1dCB0aGUgUEhZIGlzCm1hbmFnZWQgYnkgZmlybXdhcmUgb3ZlciBTQ01JLgoKPiBkaWZmIC0t Z2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BoeS9xY29tLHNhODI1NXAt ZHdtYWMtc2dtaWktcGh5LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv cGh5L3Fjb20sc2E4MjU1cC1kd21hYy1zZ21paS1waHkueWFtbAo+IG5ldyBmaWxlIG1vZGUgMTAw NjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uOWU4NDZlMzgxNTU1NQo+IC0tLSAvZGV2L251bGwK PiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fjb20sc2E4MjU1 cC1kd21hYy1zZ21paS1waHkueWFtbApbIC4uLiBdCj4gKyAgcG93ZXItZG9tYWluczoKPiArICAg IG1heEl0ZW1zOiAxCj4gKwo+ICsgIHBvd2VyLWRvbWFpbi1uYW1lczoKPiArICAgIG1heEl0ZW1z OiAxCgpbU2V2ZXJpdHk6IExvd10KRG9lcyB0aGlzIHByb3BlcnR5IG5lZWQgYSBzdHJpbmcgdmFs dWUgY29uc3RyYWludD8gCgpUaGUgY3VycmVudCBzY2hlbWEgbGltaXRzIHRoZSBhcnJheSBsZW5n dGggYnV0IGFsbG93cyBhcmJpdHJhcnkgc3RyaW5ncyB0byBwYXNzCnNjaGVtYSB2YWxpZGF0aW9u LiBTaG91bGQgaXQgaW5jbHVkZSBhbiBpdGVtcyBsaXN0IHdpdGggYSBjb25zdCB2YWx1ZSwgc3Vj aCBhcwpjb25zdDogc2VyZGVzLCB0byBtYXRjaCB0aGUgdXNhZ2UgaW4gdGhlIGV4YW1wbGU/Cgo+ ICsKPiArICAiI3BoeS1jZWxscyI6Cj4gKyAgICBjb25zdDogMAoKLS0gClNhc2hpa28gQUkgcmV2 aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcwNi1xY29tLXNhODI1 NXAtZW1hYy12MTItMC1lM2FiMWVjZjI5MDFAb3NzLnF1YWxjb21tLmNvbT9wYXJ0PTEKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMg bWFpbGluZyBsaXN0CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK