From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 492523B2D0D for ; Tue, 7 Jul 2026 14:27:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434438; cv=none; b=WdoAkEEq69i99SqsGF6SX8lkh95peHI3Wals0IU4ElqElW80L4hcyL4sRhsFu9jljEBX6V0m1CbsxeO2bjoYzX8XbHv+MffiQihcCl87HLlIG7AeMakYEbHIT9trcEMwajp0gEeZBBWlgVCvB4IQKAvrTAiXOnif2z+3lerxuzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783434438; c=relaxed/simple; bh=rj2QpPqN7ySx5bLcwkgexTZWvVT8kHzevHavuTot/MU=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=UCPnaJ/igHKuSaHRCEny7X7P2Wf8Hev5LKi5Vr/sSLhOjmOZFpcrt7DPHDygD/Zy7TRqWBKamlWgqcIopJ4BLUTVuSmi5cQN3meR0JvzfjtDa3B8ifbyWXWim19DPk/1JkgevKnQH6JvtNYVWZa12txFiHeJmkyCent3aDq0YCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BosXBH9r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BosXBH9r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D03021F00AC4; Tue, 7 Jul 2026 14:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434434; bh=9ejetAl8MzDSoFJYgSbHLvtbPxpoS6PlRJW41QuvIVs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BosXBH9rxDr4wDdzAsIV/yyFwkLkT8dXAnXvl3sUysQ1HPPsxjVNQOsIuvaunYhQF j5FYwA/BVxVTU9wn3cmScF4NKsbDF/VG09DmkdhmnikWggql1pv8XBSXhLxzewdkYD OQ5MMrq1t9zeATktAKdhwFdB/6nPRfJHOYYqE+SEqS9mVJ0cVPgQdZEPECZFG6toSS MYWaNf6n1SeAUYfSSKfEIGKAB+qVFR9SDmvaCws1KpNBtBzwQIlTcMD1L+ewrHw79F nIxjSQsLRfv1l1OqA6yBL0OHiDNVLIvb3g/HErKa6p8ZkmCz/SpfSx41db8XSvolgV RtZfq7lTtOyGw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 02/12] phy: phy-mtk-dp: Rename regs to regmap in struct mtk_dp_phy Reply-To: sashiko-reviews@lists.linux.dev To: "AngeloGioacchino Del Regno" Cc: conor+dt@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, robh@kernel.org In-Reply-To: <20260707141931.191172-3-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-3-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Jul 2026 14:27:13 +0000 Message-Id: <20260707142713.D03021F00AC4@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Missing NULL check for `dev->platform_data` before dereferencing i= t in `mtk_dp_phy_probe`. -- --- Patch [2]: [PATCH v2 02/12] phy: phy-mtk-dp: Rename regs to regmap in s= truct mtk_dp_phy --- commit b41d4072a9780ff4f56cf8b17085088b1f2777ae Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Rename regs to regmap in struct mtk_dp_phy This commit renames the regs member of struct mtk_dp_phy to regmap to improve readability and align with common kernel driver naming conventions. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > index d7024a1443358..bf7b3a95e72d2 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > @@ -176,7 +176,7 @@ static int mtk_dp_phy_probe(struct platform_device *p= dev) [Severity: High] This is a pre-existing issue, but does mtk_dp_phy_probe() lack a NULL check= =20 for dev->platform_data before dereferencing it? If the platform device is probed without platform_data (for example, if=20 manually bound via the sysfs bind interface to a generic platform device=20 lacking this data), dev->platform_data will be NULL. Looking at the code in mtk_dp_phy_probe(): regs =3D *(struct regmap **)dev->platform_data; if (!regs) return dev_err_probe(dev, -EINVAL, ... Dereferencing dev->platform_data to assign regs before checking if=20 platform_data itself is valid will cause a kernel oops. > if (!dp_phy) > return -ENOMEM; > =20 > - dp_phy->regs =3D regs; > + dp_phy->regmap =3D regs; > phy =3D devm_phy_create(dev, NULL, &mtk_dp_phy_dev_ops); > if (IS_ERR(phy)) > return dev_err_probe(dev, PTR_ERR(phy), --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260707141931.1911= 72-1-angelogioacchino.delregno@collabora.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 837FEC43602 for ; Tue, 7 Jul 2026 14:27:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a6KH0ZNz6yPEYWKucPH06YbONUXhsVj0ILSCqxA8MnU=; b=IGVvtXB57IkIJB HqVeyGZFg6wJDdnqvM8kU3ZGII3mQKMtYEZyxhfCaxgQOYSyvg56m6y0l9gdj7ZvIBYlMcomJKzZB BkU8Ame2G+mLk9BAv6r4n4MujwizmtpoNTFbiwIYO5rKJObW5IK+xm5+G8KxPgHe4OygaKDtRiaJg pKtSLJrU9s3bGFP/r3E4PPXE/CxK+7BU79yw3AGFgWlqf39jRtNU3AoCqOrxMb3k6wg71rCu64L7W /3krFfrdDWkPAyVugSHyHCCRrsy6BiQeWrhIGb+R4T0akyXpW9E34VxzHK8XJzRdmYeMBIuULAUaU TBM+lKQJKRHIjVkup4vA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6la-0000000FB6n-0UqM; Tue, 07 Jul 2026 14:27:18 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6lY-0000000FB6J-2anY for linux-phy@lists.infradead.org; Tue, 07 Jul 2026 14:27:16 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id AEFF26138A; Tue, 7 Jul 2026 14:27:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D03021F00AC4; Tue, 7 Jul 2026 14:27:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434434; bh=9ejetAl8MzDSoFJYgSbHLvtbPxpoS6PlRJW41QuvIVs=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BosXBH9rxDr4wDdzAsIV/yyFwkLkT8dXAnXvl3sUysQ1HPPsxjVNQOsIuvaunYhQF j5FYwA/BVxVTU9wn3cmScF4NKsbDF/VG09DmkdhmnikWggql1pv8XBSXhLxzewdkYD OQ5MMrq1t9zeATktAKdhwFdB/6nPRfJHOYYqE+SEqS9mVJ0cVPgQdZEPECZFG6toSS MYWaNf6n1SeAUYfSSKfEIGKAB+qVFR9SDmvaCws1KpNBtBzwQIlTcMD1L+ewrHw79F nIxjSQsLRfv1l1OqA6yBL0OHiDNVLIvb3g/HErKa6p8ZkmCz/SpfSx41db8XSvolgV RtZfq7lTtOyGw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 02/12] phy: phy-mtk-dp: Rename regs to regmap in struct mtk_dp_phy To: "AngeloGioacchino Del Regno" Cc: conor+dt@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-phy@lists.infradead.org, olteanv@gmail.com, neil.armstrong@linaro.org, robh@kernel.org In-Reply-To: <20260707141931.191172-3-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-3-angelogioacchino.delregno@collabora.com> Date: Tue, 07 Jul 2026 14:27:13 +0000 Message-Id: <20260707142713.D03021F00AC4@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBNaXNzaW5nIE5VTEwgY2hlY2sgZm9yIGBkZXYtPnBsYXRmb3JtX2RhdGFgIGJlZm9y ZSBkZXJlZmVyZW5jaW5nIGl0IGluIGBtdGtfZHBfcGh5X3Byb2JlYC4KLS0KCi0tLSBQYXRjaCBb Ml06IFtQQVRDSCB2MiAwMi8xMl0gcGh5OiBwaHktbXRrLWRwOiBSZW5hbWUgcmVncyB0byByZWdt YXAgaW4gc3RydWN0IG10a19kcF9waHkgLS0tCmNvbW1pdCBiNDFkNDA3MmE5NzgwZmY0ZjU2Y2Y4 YjE3MDg1MDg4YjFmMjc3N2FlCkF1dGhvcjogQW5nZWxvR2lvYWNjaGlubyBEZWwgUmVnbm8gPGFu Z2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29sbGFib3JhLmNvbT4KCnBoeTogcGh5LW10ay1kcDog UmVuYW1lIHJlZ3MgdG8gcmVnbWFwIGluIHN0cnVjdCBtdGtfZHBfcGh5CgpUaGlzIGNvbW1pdCBy ZW5hbWVzIHRoZSByZWdzIG1lbWJlciBvZiBzdHJ1Y3QgbXRrX2RwX3BoeSB0byByZWdtYXAgdG8K aW1wcm92ZSByZWFkYWJpbGl0eSBhbmQgYWxpZ24gd2l0aCBjb21tb24ga2VybmVsIGRyaXZlciBu YW1pbmcgY29udmVudGlvbnMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9w aHktbXRrLWRwLmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmMKPiBpbmRleCBk NzAyNGExNDQzMzU4Li5iZjdiM2E5NWU3MmQyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L21l ZGlhdGVrL3BoeS1tdGstZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGst ZHAuYwoKWyAuLi4gXQoKPiBAQCAtMTc2LDcgKzE3Niw3IEBAIHN0YXRpYyBpbnQgbXRrX2RwX3Bo eV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQoKW1NldmVyaXR5OiBIaWdoXQpU aGlzIGlzIGEgcHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyBtdGtfZHBfcGh5X3Byb2JlKCkg bGFjayBhIE5VTEwgY2hlY2sgCmZvciBkZXYtPnBsYXRmb3JtX2RhdGEgYmVmb3JlIGRlcmVmZXJl bmNpbmcgaXQ/CgpJZiB0aGUgcGxhdGZvcm0gZGV2aWNlIGlzIHByb2JlZCB3aXRob3V0IHBsYXRm b3JtX2RhdGEgKGZvciBleGFtcGxlLCBpZiAKbWFudWFsbHkgYm91bmQgdmlhIHRoZSBzeXNmcyBi aW5kIGludGVyZmFjZSB0byBhIGdlbmVyaWMgcGxhdGZvcm0gZGV2aWNlIApsYWNraW5nIHRoaXMg ZGF0YSksIGRldi0+cGxhdGZvcm1fZGF0YSB3aWxsIGJlIE5VTEwuCgpMb29raW5nIGF0IHRoZSBj b2RlIGluIG10a19kcF9waHlfcHJvYmUoKToKCiAgICByZWdzID0gKihzdHJ1Y3QgcmVnbWFwICoq KWRldi0+cGxhdGZvcm1fZGF0YTsKICAgIGlmICghcmVncykKICAgICAgICByZXR1cm4gZGV2X2Vy cl9wcm9iZShkZXYsIC1FSU5WQUwsIC4uLgoKRGVyZWZlcmVuY2luZyBkZXYtPnBsYXRmb3JtX2Rh dGEgdG8gYXNzaWduIHJlZ3MgYmVmb3JlIGNoZWNraW5nIGlmIApwbGF0Zm9ybV9kYXRhIGl0c2Vs ZiBpcyB2YWxpZCB3aWxsIGNhdXNlIGEga2VybmVsIG9vcHMuCgo+ICAJaWYgKCFkcF9waHkpCj4g IAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JZHBfcGh5LT5yZWdzID0gcmVnczsKPiArCWRwX3Bo eS0+cmVnbWFwID0gcmVnczsKPiAgCXBoeSA9IGRldm1fcGh5X2NyZWF0ZShkZXYsIE5VTEwsICZt dGtfZHBfcGh5X2Rldl9vcHMpOwo+ICAJaWYgKElTX0VSUihwaHkpKQo+ICAJCXJldHVybiBkZXZf ZXJyX3Byb2JlKGRldiwgUFRSX0VSUihwaHkpLAoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcwNzE0MTkzMS4xOTExNzItMS1hbmdl bG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20/cGFydD0yCgotLSAKbGludXgtcGh5 IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK