From: Andreas Kemnade <andreas@kemnade.info>
To: sashiko-bot@kernel.org, Helge Deller <deller@gmx.de>
Cc: sashiko-reviews@lists.linux.dev, dri-devel@lists.freedesktop.org,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
sashiko-bot@kernel.org, Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH] fb: omap2: dsi: do not copy isr table
Date: Tue, 7 Jul 2026 14:32:54 +0200 [thread overview]
Message-ID: <20260707143254.76bbb791@kemnade.info> (raw)
In-Reply-To: <20260702160541.340B11F000E9@smtp.kernel.org>
On Thu, 02 Jul 2026 16:05:40 +0000
sashiko-bot@kernel.org wrote:
> [Severity: High]
> This isn't a bug introduced by this patch, but it appears the identical
> use-after-free vulnerability you are fixing here remains unpatched in the
> equivalent DRM driver.
>
> Does drivers/gpu/drm/omapdrm/dss/dsi.c:omap_dsi_irq_handler() need the same
> fix? It still copies the table and drops the lock:
>
> drivers/gpu/drm/omapdrm/dss/dsi.c:omap_dsi_irq_handler() {
> ...
> memcpy(&dsi->isr_tables_copy, &dsi->isr_tables, sizeof(dsi->isr_tables));
> spin_unlock(&dsi->irq_lock);
> dsi_handle_isrs(&dsi->isr_tables_copy, irqstatus, vcstatus, ciostatus);
> ...
> }
>
> This could still race with a timeout in dsi_sync_vc_vp(), which creates a
> completion on the stack:
>
> drivers/gpu/drm/omapdrm/dss/dsi.c:dsi_sync_vc_vp() {
> DECLARE_COMPLETION_ONSTACK(completion);
> ...
> }
Enitities with access to cerebral richness can find the link in the patch
to the version for the drm driver.
Regards,
Andreas
prev parent reply other threads:[~2026-07-07 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 15:50 [PATCH] fb: omap2: dsi: do not copy isr table Andreas Kemnade
2026-07-02 16:05 ` sashiko-bot
2026-07-07 12:32 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707143254.76bbb791@kemnade.info \
--to=andreas@kemnade.info \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.