From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F51C44501 for ; Tue, 7 Jul 2026 14:34:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 94C9910EDA4; Tue, 7 Jul 2026 14:34:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PCS4s/rT"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3FD4810EDA4 for ; Tue, 7 Jul 2026 14:34:05 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B867060018; Tue, 7 Jul 2026 14:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA05D1F000E9; Tue, 7 Jul 2026 14:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434844; bh=qPPLFALCz8NXXZOTdxsis98fvVnKcnAHTN9imvn7xk4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PCS4s/rTRQ+a8cNa8Nteawau5Lr+JrTiaM6VmA88+sza4mEnr1QJGnfYGiHoQvNWr LU51Brvxvoh9zmgdQw+SU7m+PRVfHAn4EuSsTzZ6FEHwtO055ujhN3wM1F3cNgKEx7 8ZLN12/KQlG+2+gS4RJNAulBn+WWOPXUHK6icBi3QLlOzCX8mXqaDzDFKpXuKhsOKo moxUNqBitsqJYgEn63nmVCwJf8DRLXWq/kqOlnxti1pEbY+sj1crb/PIVN041vhhgd MeCjXrUWx4sKIthh4n3NpgnYkuieJP2EfWTIh0mBys/dqPPCyN7tR7KVi5fRBD0ron dyBGlB5B4IKKQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 06/12] phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup To: "AngeloGioacchino Del Regno" Cc: olteanv@gmail.com, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Jul 2026 14:34:03 +0000 Message-Id: <20260707143403.EA05D1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Missing NULL check on device_get_match_data() result leads to pote= ntial NULL pointer dereference. - [Low] Undeclared variable 'ret' causes a build failure. -- --- Patch [6]: [PATCH v2 06/12] phy: phy-mtk-dp: Support set_lanes in confi= gure and properly cleanup --- commit 564fc9b179c0513c9ad23d3689aaf0c8211c61c3 Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup Add support for enabling a specifically requested number of lanes in the .configure() callback and disable all lanes in power off and reset callbacks for proper hardware cleanup. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > +static int mtk_dp_phy_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct phy_provider *provider; > + struct mtk_dp_phy *dp_phy; > + void __iomem *base; > + struct phy *phy; > + > + dp_phy =3D devm_kzalloc(dev, sizeof(*dp_phy), GFP_KERNEL); > + if (!dp_phy) > + return -ENOMEM; > + > + dp_phy->dev =3D dev; > + > + /* If there's no devicetree, go for legacy pdev probe */ > + if (!dev->of_node) > + return mtk_dp_phy_legacy_probe(pdev, dp_phy); > + > + base =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + dp_phy->regmap =3D devm_regmap_init_mmio(dev, base, &mtk_dp_phy_regmap_= cfg); > + if (IS_ERR(dp_phy->regmap)) > + return PTR_ERR(dp_phy->regmap); > + > + dp_phy->pdata =3D device_get_match_data(dev); > + > + phy =3D devm_phy_create(dev, NULL, &mtk_dp_phy_dev_ops); [Severity: High] Can dp_phy->pdata be NULL here if the driver is bound manually? If a user writes the driver name to 'driver_override' in sysfs for an unrelated platform device, device_get_match_data() will return NULL since the compatible string won't match. The probe will succeed, but subsequent PHY framework calls to .init or .configure will unconditionally dereference dp_phy->pdata, which could lead to a kernel panic. Would it be safer to verify the result of device_get_match_data() before proceeding? > + if (IS_ERR(phy)) > + return dev_err_probe(dev, PTR_ERR(phy), > + "Failed to create DP PHY\n"); > + > + phy_set_drvdata(phy, dp_phy); > + > + provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); > + if (IS_ERR(provider)) > + return PTR_ERR(provider); > + > + ret =3D devm_pm_runtime_enable(dev); [Severity: Low] Is the variable 'ret' missing a declaration in this function? It appears 'ret' is assigned and checked here, but it wasn't declared in the variable block at the start of mtk_dp_phy_probe(), which will cause a build failure. > + if (ret) > + return ret; > + > + return 0; > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260707141931.1911= 72-1-angelogioacchino.delregno@collabora.com?part=3D6 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8C92C43458 for ; Tue, 7 Jul 2026 14:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w9iiqPXrS94Y0Ld1m7PRptaJuaXs2nI8/VnSUeGvwOw=; b=LwNE5YmkeIGJ2i iVvpEmEwoGY5X+yj+BW80/Ups8mVNQLn4Yr8t0353d/X3fBcUkUQoB6bIuaMwdgTjPdKW0wEQxH6O S130a/n8fO0LWS8eE7mTx6jfM1pnh4Lt44QN02X6eBDVg7k1gr67EiNT0yKTqYX9v6MpJxijeNAn5 NiXOEuG36BbLqPzjKCBLH+0c8t8INJHVioR89vKvjWQIB3dpxSZ7203elc5kC0+9t0Bv+8xp1IhSF kEfJMsxoA/4RXw/SKhtASSKN49bBO+YvYdxDO7uEMWpY6292U8+lYFmRaMB4pABCrtTY2aZFuIIbv 38ngaIq8p4Zjvrvfa6XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6sA-0000000FBZb-1tqi; Tue, 07 Jul 2026 14:34:06 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh6s9-0000000FBZM-1oPF for linux-phy@lists.infradead.org; Tue, 07 Jul 2026 14:34:05 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B867060018; Tue, 7 Jul 2026 14:34:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA05D1F000E9; Tue, 7 Jul 2026 14:34:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783434844; bh=qPPLFALCz8NXXZOTdxsis98fvVnKcnAHTN9imvn7xk4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PCS4s/rTRQ+a8cNa8Nteawau5Lr+JrTiaM6VmA88+sza4mEnr1QJGnfYGiHoQvNWr LU51Brvxvoh9zmgdQw+SU7m+PRVfHAn4EuSsTzZ6FEHwtO055ujhN3wM1F3cNgKEx7 8ZLN12/KQlG+2+gS4RJNAulBn+WWOPXUHK6icBi3QLlOzCX8mXqaDzDFKpXuKhsOKo moxUNqBitsqJYgEn63nmVCwJf8DRLXWq/kqOlnxti1pEbY+sj1crb/PIVN041vhhgd MeCjXrUWx4sKIthh4n3NpgnYkuieJP2EfWTIh0mBys/dqPPCyN7tR7KVi5fRBD0ron dyBGlB5B4IKKQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 06/12] phy: phy-mtk-dp: Support set_lanes in configure and properly cleanup To: "AngeloGioacchino Del Regno" Cc: olteanv@gmail.com, robh@kernel.org, linux-phy@lists.infradead.org, vkoul@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> References: <20260707141931.191172-1-angelogioacchino.delregno@collabora.com> <20260707141931.191172-7-angelogioacchino.delregno@collabora.com> Date: Tue, 07 Jul 2026 14:34:03 +0000 Message-Id: <20260707143403.EA05D1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgTlVMTCBj aGVjayBvbiBkZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSByZXN1bHQgbGVhZHMgdG8gcG90ZW50aWFs IE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZS4KLSBbTG93XSBVbmRlY2xhcmVkIHZhcmlhYmxlICdy ZXQnIGNhdXNlcyBhIGJ1aWxkIGZhaWx1cmUuCi0tCgotLS0gUGF0Y2ggWzZdOiBbUEFUQ0ggdjIg MDYvMTJdIHBoeTogcGh5LW10ay1kcDogU3VwcG9ydCBzZXRfbGFuZXMgaW4gY29uZmlndXJlIGFu ZCBwcm9wZXJseSBjbGVhbnVwIC0tLQpjb21taXQgNTY0ZmM5YjE3OWMwNTEzYzlhZDIzZDM2ODlh YWYwYzgyMTFjNjFjMwpBdXRob3I6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9n aW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxhYm9yYS5jb20+CgpwaHk6IHBoeS1tdGstZHA6IFN1cHBv cnQgc2V0X2xhbmVzIGluIGNvbmZpZ3VyZSBhbmQgcHJvcGVybHkgY2xlYW51cAoKQWRkIHN1cHBv cnQgZm9yIGVuYWJsaW5nIGEgc3BlY2lmaWNhbGx5IHJlcXVlc3RlZCBudW1iZXIgb2YgbGFuZXMK aW4gdGhlIC5jb25maWd1cmUoKSBjYWxsYmFjayBhbmQgZGlzYWJsZSBhbGwgbGFuZXMgaW4gcG93 ZXIgb2ZmCmFuZCByZXNldCBjYWxsYmFja3MgZm9yIHByb3BlciBoYXJkd2FyZSBjbGVhbnVwLgoK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jIGIvZHJpdmVy cy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jCj4gLS0tIGEvZHJpdmVycy9waHkvbWVkaWF0ZWsv cGh5LW10ay1kcC5jCj4gKysrIGIvZHJpdmVycy9waHkvbWVkaWF0ZWsvcGh5LW10ay1kcC5jCgpb IC4uLiBdCgo+ICtzdGF0aWMgaW50IG10a19kcF9waHlfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiArewo+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiAr CXN0cnVjdCBwaHlfcHJvdmlkZXIgKnByb3ZpZGVyOwo+ICsJc3RydWN0IG10a19kcF9waHkgKmRw X3BoeTsKPiArCXZvaWQgX19pb21lbSAqYmFzZTsKPiArCXN0cnVjdCBwaHkgKnBoeTsKPiArCj4g KwlkcF9waHkgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKmRwX3BoeSksIEdGUF9LRVJORUwp Owo+ICsJaWYgKCFkcF9waHkpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwo+ICsJZHBfcGh5LT5k ZXYgPSBkZXY7Cj4gKwo+ICsJLyogSWYgdGhlcmUncyBubyBkZXZpY2V0cmVlLCBnbyBmb3IgbGVn YWN5IHBkZXYgcHJvYmUgKi8KPiArCWlmICghZGV2LT5vZl9ub2RlKQo+ICsJCXJldHVybiBtdGtf ZHBfcGh5X2xlZ2FjeV9wcm9iZShwZGV2LCBkcF9waHkpOwo+ICsKPiArCWJhc2UgPSBkZXZtX3Bs YXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gKwlpZiAoSVNfRVJSKGJhc2UpKQo+ ICsJCXJldHVybiBQVFJfRVJSKGJhc2UpOwo+ICsKPiArCWRwX3BoeS0+cmVnbWFwID0gZGV2bV9y ZWdtYXBfaW5pdF9tbWlvKGRldiwgYmFzZSwgJm10a19kcF9waHlfcmVnbWFwX2NmZyk7Cj4gKwlp ZiAoSVNfRVJSKGRwX3BoeS0+cmVnbWFwKSkKPiArCQlyZXR1cm4gUFRSX0VSUihkcF9waHktPnJl Z21hcCk7Cj4gKwo+ICsJZHBfcGh5LT5wZGF0YSA9IGRldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYp Owo+ICsKPiArCXBoeSA9IGRldm1fcGh5X2NyZWF0ZShkZXYsIE5VTEwsICZtdGtfZHBfcGh5X2Rl dl9vcHMpOwoKW1NldmVyaXR5OiBIaWdoXQpDYW4gZHBfcGh5LT5wZGF0YSBiZSBOVUxMIGhlcmUg aWYgdGhlIGRyaXZlciBpcyBib3VuZCBtYW51YWxseT8KCklmIGEgdXNlciB3cml0ZXMgdGhlIGRy aXZlciBuYW1lIHRvICdkcml2ZXJfb3ZlcnJpZGUnIGluIHN5c2ZzIGZvciBhbgp1bnJlbGF0ZWQg cGxhdGZvcm0gZGV2aWNlLCBkZXZpY2VfZ2V0X21hdGNoX2RhdGEoKSB3aWxsIHJldHVybiBOVUxM IHNpbmNlCnRoZSBjb21wYXRpYmxlIHN0cmluZyB3b24ndCBtYXRjaC4KClRoZSBwcm9iZSB3aWxs IHN1Y2NlZWQsIGJ1dCBzdWJzZXF1ZW50IFBIWSBmcmFtZXdvcmsgY2FsbHMgdG8gLmluaXQgb3IK LmNvbmZpZ3VyZSB3aWxsIHVuY29uZGl0aW9uYWxseSBkZXJlZmVyZW5jZSBkcF9waHktPnBkYXRh LCB3aGljaCBjb3VsZCBsZWFkCnRvIGEga2VybmVsIHBhbmljLgoKV291bGQgaXQgYmUgc2FmZXIg dG8gdmVyaWZ5IHRoZSByZXN1bHQgb2YgZGV2aWNlX2dldF9tYXRjaF9kYXRhKCkgYmVmb3JlCnBy b2NlZWRpbmc/Cgo+ICsJaWYgKElTX0VSUihwaHkpKQo+ICsJCXJldHVybiBkZXZfZXJyX3Byb2Jl KGRldiwgUFRSX0VSUihwaHkpLAo+ICsJCQkJICAgICAiRmFpbGVkIHRvIGNyZWF0ZSBEUCBQSFlc biIpOwo+ICsKPiArCXBoeV9zZXRfZHJ2ZGF0YShwaHksIGRwX3BoeSk7Cj4gKwo+ICsJcHJvdmlk ZXIgPSBkZXZtX29mX3BoeV9wcm92aWRlcl9yZWdpc3RlcihkZXYsIG9mX3BoeV9zaW1wbGVfeGxh dGUpOwo+ICsJaWYgKElTX0VSUihwcm92aWRlcikpCj4gKwkJcmV0dXJuIFBUUl9FUlIocHJvdmlk ZXIpOwo+ICsKPiArCXJldCA9IGRldm1fcG1fcnVudGltZV9lbmFibGUoZGV2KTsKCltTZXZlcml0 eTogTG93XQpJcyB0aGUgdmFyaWFibGUgJ3JldCcgbWlzc2luZyBhIGRlY2xhcmF0aW9uIGluIHRo aXMgZnVuY3Rpb24/CgpJdCBhcHBlYXJzICdyZXQnIGlzIGFzc2lnbmVkIGFuZCBjaGVja2VkIGhl cmUsIGJ1dCBpdCB3YXNuJ3QgZGVjbGFyZWQgaW4KdGhlIHZhcmlhYmxlIGJsb2NrIGF0IHRoZSBz dGFydCBvZiBtdGtfZHBfcGh5X3Byb2JlKCksIHdoaWNoIHdpbGwgY2F1c2UgYQpidWlsZCBmYWls dXJlLgoKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJuIHJldDsKPiArCj4gKwlyZXR1cm4gMDsKPiAr fQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNl dC8yMDI2MDcwNzE0MTkzMS4xOTExNzItMS1hbmdlbG9naW9hY2NoaW5vLmRlbHJlZ25vQGNvbGxh Ym9yYS5jb20/cGFydD02CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1waHkK